i am trying to make a simple database template(?). adding and deleting from the mysql database worked fine untill I tried to add edit, the edit wont work. also it always says 'Record has been deleted from database', its only supposed to say that when you delete from it. I also tried to use a switch to control everything but nothing worked after that. can someone look at my code and tell me whats wrong? (my webhost doesnt support php so its just a text file.)
Tek-Tips is the largest IT community on the Internet today!
Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!
-
Congratulations strongm on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!
bad control structures? 3
- Thread starter streetbmx
- Start date
DiamondLil
Technical User
Well I'll be...
Did as you suggested. It fixed that error, took me down another 10 or so lines to a few others, which were probably stray tabs that I put in thinking it wouldn't affect it.
Then I got a few more on the other pages that I took care off, now they are ok - but I cannot add a record. I don't get an error after I submit, I get nothing.
I'll need to take another look....
Did as you suggested. It fixed that error, took me down another 10 or so lines to a few others, which were probably stray tabs that I put in thinking it wouldn't affect it.
Then I got a few more on the other pages that I took care off, now they are ok - but I cannot add a record. I don't get an error after I submit, I get nothing.
I'll need to take another look....
DiamondLil
Technical User
Ok - Now I'm getting errors on the list.php pg around lines 21-22 which are at the beginning of the while loop :
<?php
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("select * from $db_table"
;
while($r=mysql_fetch_array($result))
{
$id=$r["id"];
$loaddate=$r["loaddate"];
$origcity=$r["origcity"];
$origstate=$r["origstate"];
$destcity=$r["destcity"];
$deststate=$r["deststate"];
?>
<tr>
<td><? echo $id ?></td>
<td><? echo $loaddate ?></td>
<td><? echo $origcity ?></td>
<td><? echo $origstate ?></td>
<td><? echo $destcity ?></td>
<td><? echo $deststate ?></td>
<td><a href="mailto:<? echo $email ?>"><? echo $email ?></a></td>
<td><a href="index.php?todo=delete&deleteid=<? echo $id ?>">delete</td>
<td><a href="index.php?todo=edit&editid=<? echo $id ?>">edit</td>
</tr>
<?
}
?>
the error message is :Warning: Supplied argument is not a valid MySQL result resource in /usr/local/etc/httpd/htdocs/prologi/editbox/list.php on line 21
<?php
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("select * from $db_table"
;while($r=mysql_fetch_array($result))
{
$id=$r["id"];
$loaddate=$r["loaddate"];
$origcity=$r["origcity"];
$origstate=$r["origstate"];
$destcity=$r["destcity"];
$deststate=$r["deststate"];
?>
<tr>
<td><? echo $id ?></td>
<td><? echo $loaddate ?></td>
<td><? echo $origcity ?></td>
<td><? echo $origstate ?></td>
<td><? echo $destcity ?></td>
<td><? echo $deststate ?></td>
<td><a href="mailto:<? echo $email ?>"><? echo $email ?></a></td>
<td><a href="index.php?todo=delete&deleteid=<? echo $id ?>">delete</td>
<td><a href="index.php?todo=edit&editid=<? echo $id ?>">edit</td>
</tr>
<?
}
?>
the error message is :Warning: Supplied argument is not a valid MySQL result resource in /usr/local/etc/httpd/htdocs/prologi/editbox/list.php on line 21
DiamondLil
Technical User
If I close the bracket before the series of echo stmnt, that fixes that error , but it just gives me another on the stray
<?
}
?>
<?
}
?>
danielhozac
Programmer
Does the db_table variable contain what you think it does? Try echoing the query to see if it's correct. //Daniel
sleipnir214
Programmer
DiamondLil,
I have found that staying in PHP mode and using print or echo statements for output makes debugging PHP a lot easier.
[tt]
[tt] ______________________________________________________________________
TANSTAAFL!
I have found that staying in PHP mode and using print or echo statements for output makes debugging PHP a lot easier.
[tt]
Code:
<?php
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("select * from $db_table");
while($r=mysql_fetch_array($result[b], MYSQL_ASSOC[/b]))
{
$id = $r['id'];
$loaddate = $r['loaddate'];
$origcity = $r['origcity'];
$origstate = $r['origstate'];
$destcity = $r['destcity'];
$deststate = $r['deststate'];
print '
<tr>
<td>' . $id . '</td>
<td>' . $loaddate . '</td>
<td>' . $origcity . '</td>
<td>' . $origstate . '</td>
<td>' . $destcity . '</td>
<td>' . $deststate . '</td>
<td><a href="mailto:' . $email . '">' . $email . '</a></td>
<td><a href="index.php?todo=delete&deleteid=' . $id . '">delete</td>
<td><a href="index.php?todo=edit&editid=' . $id . '">edit</td>
</tr>';
}
?>TANSTAAFL!
DiamondLil
Technical User
hi guys, thank you. I'm back, let me try this again...
DiamondLil
Technical User
Ok, actually vars.php did have an error, I fixed it, and still I get :
Warning: Supplied argument is not a valid MySQL result resource in usr/local/etc/httpd/htdocs/prologi/editbox/list.php on line 21
list.php page :
<div align="center">
<h2>Database Template</h2>
<a href="index.php?todo=add">Add a Record</a>
<br>
<br>
<table border="1">
<tr bgcolor="#DADADA" align="center">
<td><strong>ID</strong></td>
<td><strong>Load Date</strong></td>
<td><strong>Originating City</strong></td>
<td><strong>Originating State</strong></td>
<td><strong>Destination City</strong></td>
<td><strong>Destination State</strong></td>
<td><strong>Delete</strong></td>
<td><strong>Edit</strong></td>
</tr>
<?php
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("select * from $db_table"
while($r=mysql_fetch_array($result, MYSQL_ASSOC))
{
$id = $r['id'];
$loaddate = $r['loaddate'];
$origcity = $r['origcity'];
$origstate = $r['origstate'];
$destcity = $r['destcity'];
$deststate = $r['deststate'];
print '
<tr>
<td>' . $id . '</td>
<td>' . $loaddate . '</td>
<td>' . $origcity . '</td>
<td>' . $origstate . '</td>
<td>' . $destcity . '</td>
<td>' . $deststate . '</td>
<td><a href="mailto:' . $email . '">' . $email . '</a></td>
<td><a href="index.php?todo=delete&deleteid=' . $id . '">delete</td>
<td><a href="index.php?todo=edit&editid=' . $id . '">edit</td>
</tr>';
}
?>
</table>
<br>
<a href="#top">Top of Page</a>
</div>
The records are not being added to the table. Line 21 is: while($r=mysql_fetch_array($result, MYSQL_ASSOC))
-L
Warning: Supplied argument is not a valid MySQL result resource in usr/local/etc/httpd/htdocs/prologi/editbox/list.php on line 21
list.php page :
<div align="center">
<h2>Database Template</h2>
<a href="index.php?todo=add">Add a Record</a>
<br>
<br>
<table border="1">
<tr bgcolor="#DADADA" align="center">
<td><strong>ID</strong></td>
<td><strong>Load Date</strong></td>
<td><strong>Originating City</strong></td>
<td><strong>Originating State</strong></td>
<td><strong>Destination City</strong></td>
<td><strong>Destination State</strong></td>
<td><strong>Delete</strong></td>
<td><strong>Edit</strong></td>
</tr>
<?php
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("select * from $db_table"
;while($r=mysql_fetch_array($result, MYSQL_ASSOC))
{
$id = $r['id'];
$loaddate = $r['loaddate'];
$origcity = $r['origcity'];
$origstate = $r['origstate'];
$destcity = $r['destcity'];
$deststate = $r['deststate'];
print '
<tr>
<td>' . $id . '</td>
<td>' . $loaddate . '</td>
<td>' . $origcity . '</td>
<td>' . $origstate . '</td>
<td>' . $destcity . '</td>
<td>' . $deststate . '</td>
<td><a href="mailto:' . $email . '">' . $email . '</a></td>
<td><a href="index.php?todo=delete&deleteid=' . $id . '">delete</td>
<td><a href="index.php?todo=edit&editid=' . $id . '">edit</td>
</tr>';
}
?>
</table>
<br>
<a href="#top">Top of Page</a>
</div>
The records are not being added to the table. Line 21 is: while($r=mysql_fetch_array($result, MYSQL_ASSOC))
-L
danielhozac
Programmer
Try echo'ing your variables. Does db_table, db_host, db_name, db_user and db_pass have the correct values? //Daniel
DiamondLil
Technical User
Hi,
That's how I had it before (see 7 posts, 8 from this one, ago). Yes, I just double-checked and all the variables are correct.
-L
That's how I had it before (see 7 posts, 8 from this one, ago). Yes, I just double-checked and all the variables are correct.
-L
DiamondLil
Technical User
ok - now, no error, but i'm not adding records. Can add records through telnet/mysql, though.
danielhozac
Programmer
You do know that your file only selects and output records, right? It has no insertion anywhere. //Daniel
DiamondLil
Technical User
Yes, this page. But I do have an add.php that theoretically is supposed to be adding records.
DiamondLil
Technical User
ok - smarty..
As I had mentioned before I was using gerrygerry's code from earlier in this thread:
------------
add.php:
------------
<form method="post" action="index.php">
<input type="hidden" name="todo" value="save">
<table>
<tr>
<td>Load Date:</td>
<td><input type="text" name="loaddate"></td>
</tr>
<tr>
<td>Originating City:</td>
<td><input type="text" name="origcity"></td>
</tr>
<tr>
<td>Originating State:</td>
<td><input type="text" name="origstate"></td>
</tr>
<tr>
<td>Destination City:</td>
<td><input type="text" name="destcity"></td>
</tr>
<tr>
<td>Destination State:</td>
<td><input type="text" name="deststate"></td>
</tr>
<tr>
<td></td>
<td><input type="submit" name="submit" value="add"></td>
</tr>
</table>
</form>
----------------
update.php:
----------------
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("UPDATE $db_table SET loaddate=$loaddate,origcity=$origcity,origstate=$origstate,destcity=$destcity,deststate=$deststate WHERE id=$id"
?>
---------------
edit.php:
---------------
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("SELECT * FROM $db_table WHERE id=$editid"
$edit = mysql_fetch_array($result);
?>
<form method="post" action="index.php">
<input type="hidden" name="todo" value="update">
<input type="hidden" name="id" value="<? echo $edit["id"] ?>">
<table>
<tr>
<td>Load Date:</td>
<td><input type="text" name="loaddate" value="<? echo $edit["loaddate"] ?>"></td>
</tr>
<tr>
<td>Originating City:</td>
<td><input type="text" name="origcity" value="<? echo $edit["origcity"] ?>"></td>
</tr>
<tr>
<td>Originating State:</td>
<td><input type="text" name="origstate" value="<? echo $edit["origstate"] ?>"></td>
</tr>
<tr>
<td>Destination City:</td>
<td><input type="text" name="destcity" value="<? echo $edit["destcity"] ?>"></td>
</tr>
<tr>
<td>Destination State:</td>
<td><input type="text" name="deststate" value="<? echo $edit["deststate"] ?>"></td>
</tr>
<tr>
<td></td>
<td><input type="submit" name="submit" value="update"></td>
</tr>
</table>
</form>
----------
save.php
-----------
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("INSERT INTO $db_table (id,loaddate,origcity,origstate,destcity,deststate) VALUES ('NULL', '$loaddate', '$origcity', '$origstate', '$destcity', '$deststate')"
?>
-----------
index.php
-----------
<?
require("vars.php" //for database connection vars
switch ($todo) {
case "add":
//dispaly a blank form
$title="Add new entry"; //used by header
require("header.php" // your page header
require("add.php" // submits to index.php?todo=save
require("footer.php" // your page footer
break;
case "edit":
// pull the data from db and plugs into form
$title = "Edit Existing Entry"; // used by header
require("header.php" // your page header
require("edit.php" // edits $editid, submits to index.php?todo=update
require("footer.php" // your page footer
break;
case "delete":
require("delete.php" // deletes $deleteid from the db
header("Location: index.php" // go to listing
break;
case "save":
require("save.php" // add new entry to db
header("Location: index.php" // go to listing
break;
case "update":
require("update.php" // update the db where id=$id
header("Location: index.php" // go to listing
break;
default:
$title = "Viewing All Entries"; // used by header
require("header.php" // your page header
require("list.php" //show all entries
require("footer.php" // your page footer
break;
}
?>
------------
delete.php
------------
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("DELETE FROM $db_table WHERE id=$deleteid"
?>
link:
As I was pasting the code here, I noticed something else <oops, goofy error> I fixed it. And now - we're adding records! Still getting occasional Warning: Supplied argument is not a valid MySQL result resource errors. Let me go through the pages again with what you and gerrygerry told me about invisible characters and see if that's it. Bear with me....
As I had mentioned before I was using gerrygerry's code from earlier in this thread:
------------
add.php:
------------
<form method="post" action="index.php">
<input type="hidden" name="todo" value="save">
<table>
<tr>
<td>Load Date:</td>
<td><input type="text" name="loaddate"></td>
</tr>
<tr>
<td>Originating City:</td>
<td><input type="text" name="origcity"></td>
</tr>
<tr>
<td>Originating State:</td>
<td><input type="text" name="origstate"></td>
</tr>
<tr>
<td>Destination City:</td>
<td><input type="text" name="destcity"></td>
</tr>
<tr>
<td>Destination State:</td>
<td><input type="text" name="deststate"></td>
</tr>
<tr>
<td></td>
<td><input type="submit" name="submit" value="add"></td>
</tr>
</table>
</form>
----------------
update.php:
----------------
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("UPDATE $db_table SET loaddate=$loaddate,origcity=$origcity,origstate=$origstate,destcity=$destcity,deststate=$deststate WHERE id=$id"
;?>
---------------
edit.php:
---------------
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("SELECT * FROM $db_table WHERE id=$editid"
;$edit = mysql_fetch_array($result);
?>
<form method="post" action="index.php">
<input type="hidden" name="todo" value="update">
<input type="hidden" name="id" value="<? echo $edit["id"] ?>">
<table>
<tr>
<td>Load Date:</td>
<td><input type="text" name="loaddate" value="<? echo $edit["loaddate"] ?>"></td>
</tr>
<tr>
<td>Originating City:</td>
<td><input type="text" name="origcity" value="<? echo $edit["origcity"] ?>"></td>
</tr>
<tr>
<td>Originating State:</td>
<td><input type="text" name="origstate" value="<? echo $edit["origstate"] ?>"></td>
</tr>
<tr>
<td>Destination City:</td>
<td><input type="text" name="destcity" value="<? echo $edit["destcity"] ?>"></td>
</tr>
<tr>
<td>Destination State:</td>
<td><input type="text" name="deststate" value="<? echo $edit["deststate"] ?>"></td>
</tr>
<tr>
<td></td>
<td><input type="submit" name="submit" value="update"></td>
</tr>
</table>
</form>
----------
save.php
-----------
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("INSERT INTO $db_table (id,loaddate,origcity,origstate,destcity,deststate) VALUES ('NULL', '$loaddate', '$origcity', '$origstate', '$destcity', '$deststate')"
;?>
-----------
index.php
-----------
<?
require("vars.php"
; //for database connection varsswitch ($todo) {
case "add":
//dispaly a blank form
$title="Add new entry"; //used by header
require("header.php"
; // your page headerrequire("add.php"
; // submits to index.php?todo=saverequire("footer.php"
; // your page footerbreak;
case "edit":
// pull the data from db and plugs into form
$title = "Edit Existing Entry"; // used by header
require("header.php"
; // your page headerrequire("edit.php"
; // edits $editid, submits to index.php?todo=updaterequire("footer.php"
; // your page footerbreak;
case "delete":
require("delete.php"
; // deletes $deleteid from the dbheader("Location: index.php"
; // go to listingbreak;
case "save":
require("save.php"
; // add new entry to dbheader("Location: index.php"
; // go to listingbreak;
case "update":
require("update.php"
; // update the db where id=$idheader("Location: index.php"
; // go to listingbreak;
default:
$title = "Viewing All Entries"; // used by header
require("header.php"
; // your page headerrequire("list.php"
; //show all entries require("footer.php"
; // your page footerbreak;
}
?>
------------
delete.php
------------
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("DELETE FROM $db_table WHERE id=$deleteid"
;?>
link:
As I was pasting the code here, I noticed something else <oops, goofy error> I fixed it. And now - we're adding records! Still getting occasional Warning: Supplied argument is not a valid MySQL result resource errors. Let me go through the pages again with what you and gerrygerry told me about invisible characters and see if that's it. Bear with me....
DiamondLil
Technical User
aargg. help. please.
(this is even harder because I'm supposed to be working on two completely different projects, preventing me from concentrating on one of them until it's done...)
The link:
The code is the same as in last post, because even though I have gone through each of the pages, I'm not finding any stray characters. I've deleted and re-typed certain pieces.
I can add records so I know that I'm connecting & that the variables are ok, but when I click on "edit" on index.php, it does not grab the values of the cells and plug them into the form fields for the edit.php pg.
When I hit "edit", I'm getting : Warning: Supplied argument is not a valid MySQL result resource in /usr/local/etc/httpd/htdocs/prologi/editbox/edit.php on line 5.
Here are the first 6 lines of edit.php:
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("SELECT * FROM $db_table WHERE id=$editid"
$edit = mysql_fetch_array($result);
?>
Also, the "delete" link isn't working. It looks like it is reading delete.php and refreshing the index.php pg, but it's not deleting the info. It's not giving me an error message.
I'm editing the pages in SimpleText so I know that it's not a GoLive wysiwyg messing with the code thing.
Any ideas?
(this is even harder because I'm supposed to be working on two completely different projects, preventing me from concentrating on one of them until it's done...)
The link:
The code is the same as in last post, because even though I have gone through each of the pages, I'm not finding any stray characters. I've deleted and re-typed certain pieces.
I can add records so I know that I'm connecting & that the variables are ok, but when I click on "edit" on index.php, it does not grab the values of the cells and plug them into the form fields for the edit.php pg.
When I hit "edit", I'm getting : Warning: Supplied argument is not a valid MySQL result resource in /usr/local/etc/httpd/htdocs/prologi/editbox/edit.php on line 5.
Here are the first 6 lines of edit.php:
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("SELECT * FROM $db_table WHERE id=$editid"
;$edit = mysql_fetch_array($result);
?>
Also, the "delete" link isn't working. It looks like it is reading delete.php and refreshing the index.php pg, but it's not deleting the info. It's not giving me an error message.
I'm editing the pages in SimpleText so I know that it's not a GoLive wysiwyg messing with the code thing.
Any ideas?
DiamondLil
Technical User
arg. At least the index and list pgs WERE working until I added a stylesheet and broke it somewhere.
DiamondLil
Technical User
Now I am back to where I was (same errors) as before the stylesheet. Add records: good, delete & edit : ng.
DiamondLil
Technical User
? help ?
still having problems if anyone can help. when I click the "edit" link of the index.php, I'm getting an error that directs me to line 37 (the last line of edit.php) which isn't even php.
The last few lines of edit.php are:
<td><input type="submit" name="submit" value="update"></td>
</tr>
</table>
</form>
and there are no stray characters, nothing...
help?
still having problems if anyone can help. when I click the "edit" link of the index.php, I'm getting an error that directs me to line 37 (the last line of edit.php) which isn't even php.
The last few lines of edit.php are:
<td><input type="submit" name="submit" value="update"></td>
</tr>
</table>
</form>
and there are no stray characters, nothing...
help?
danielhozac
Programmer
That usually indicates that you have a missing } or something similar. Have you tried putting ;'s after all your echo's (<?=$variable?> works the same way and is better IMO). //Daniel
DiamondLil
Technical User
hi daniel.
So you are saying that :
<input type="text" name="loaddate" value="<? echo $edit["loaddate"] ?>">
should be:
<input type="text" name="loaddate" value="<? echo $edit["loaddate"]; ?>">
-l
So you are saying that :
<input type="text" name="loaddate" value="<? echo $edit["loaddate"] ?>">
should be:
<input type="text" name="loaddate" value="<? echo $edit["loaddate"]; ?>">
-l
- Status