Why does this location.href function not work in an iframe?

[ShawnMolloy]

Per the subject, this doesn't work in an iframe.

function album_go(albId) 
  {
      alert('Won't see this...');
      location.href = 'tray_photos.aspx?albumId='+albId;
   }

Shawn Molloy
Seattle, WA

 

[mbrooks]

It should be done like this

function album_go(albId) {
	alert('Won't see this...');
	window.location.href = 'tray_photos.aspx?albumId = ' + albId;
}

M. Brooks

http://mbrooks.info

 

[BillyRayPreachersSon]

Both are wrong, and will cause errors. The reason? An unescaped single quote that would cause a JS error:

alert('Won[!]\[/!]'t see this...');

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[mbrooks]

Totally missed that one. Good job Dan!

M. Brooks

http://mbrooks.info

 

[ShawnMolloy]

Yeah great catch! Stupid mistake on my part....

Another reason why it wasn't working (and I was getting no error) was because, for some weird reason the calling function wasn't being recoginzed if typed like this:

<div onclick='album_go('4');'>

but when I changed it to the double quotes it was fine:

<div onclick="album_go('5');">




Shawn Molloy
Seattle, WA

 

[BillyRayPreachersSon]

That's also nested single quotes.

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]