Weird IF error, not catching If statement.

[redeemasp]

Hi there

I've this weird IF error that isn't catching any of my IF statement, but running the last statement.

code:

If Left(GroupName ({Command.RRE_Code}),1) = "A"
// Business Services
then
shared stringvar shdvarACode = 'A';
shared currencyvar shdvarASellingPrice := Sum ({@Selling Price}, {Command.RRE_Code});
shared currencyvar shdvarANetSellingPrice := Sum ({@Selling Discount}, {Command.RRE_Code});
shared stringvar shdvarAdept := "Business Services";

If Left(GroupName ({Command.RRE_Code}),1) = "D"
// Consumer, Trade & Retail
then
shared stringvar shdvarDCode = 'D';
shared currencyvar shdvarDSellingPrice := Sum ({@Selling Price}, {Command.RRE_Code});
shared currencyvar shdvarDNetSellingPrice := Sum ({@Selling Discount}, {Command.RRE_Code});
shared stringvar shdvarDdept := "Consumer, Trade & Retail";

If Left(GroupName ({Command.RRE_Code}),1) = "E"
// IT/Telecoms
then
shared stringvar shdvarECode = 'E';
shared currencyvar shdvarESellingPrice := Sum ({@Selling Price}, {Command.RRE_Code});
shared currencyvar shdvarENetSellingPrice := Sum ({@Selling Discount}, {Command.RRE_Code});
shared stringvar shdvarEdept := "IT/Telecoms";

It seems that it keeps defaulting to IT Telecoms.?!?

Isn't Crystal wonderful..lol

 

[GMcNamara]

When performing multiple assignments within a single if statement, you should use (). For example:

If (condition) then
(assignment 1;
assignment 2;

This shows that both assignments should be executed as a result of the condition. The way your formula works, the first assignment after the THEN is the only one that is conditional. You are always returning "IT Telecoms" because this is the last assignment statement and you have not designated a return value.

 

[mbarron]

It may be because your last group of variables are for the "E" group.

Try changing it to an "If Then Else" instead of an "If Then ;"

If Left(GroupName ({Command.RRE_Code}),1) = "A" 
// Business Services
then 
    [b]([/b]shared stringvar shdvarACode = 'A';
    shared currencyvar shdvarASellingPrice := Sum ({@Selling Price}, {Command.RRE_Code}); 
    shared currencyvar shdvarANetSellingPrice := Sum ({@Selling Discount}, {Command.RRE_Code});
    shared stringvar shdvarAdept := "Business Services") [b])else[/b]

If Left(GroupName ({Command.RRE_Code}),1) = "D" 
// Consumer, Trade & Retail
then 
    [b]([/b]shared stringvar shdvarDCode = 'D';
    shared currencyvar shdvarDSellingPrice := Sum ({@Selling Price}, {Command.RRE_Code}); 
    shared currencyvar shdvarDNetSellingPrice := Sum ({@Selling Discount}, {Command.RRE_Code});
    shared stringvar shdvarDdept := "Consumer, Trade & Retail" [b])else[/b] 
the rest...

Where are you using the shared variables? Is this where the data is "defaulting to"? Are you using the correct variables in that location?


Mike

 

[lbass]

I think Mike is right about using the "else's". It looks like you are using Crystal syntax, so I also think you are forgetting the ":" in each clause where you are trying to set the shdvarDCode.

-LB