validation not executed 1

mkisanko · Jun 16, 2003

Hi I have this code but no validation is done please help I am a bigginer in javascript.
<html>
<head>
<script language="javascript">
function display()
{
var pass = string(document.registration.password.value);
var confirmpass = sring(document.registration.confirmpassword.value);

if (pass != confirmpass)
{
alert("Password and Confirm Password must be the same&quot

;
return false;
}

If (isNaN(document.registration.phonenumber.value)==true)
{
alert("Phone number must be numbers&quot

;
return false;
}

If (isNaN(document.registration.age.value)==true)
{
alert("Age must be in number&quot

;
document.registration.age.focus();
return false;
}

If (isNaN(document.registration.zip.value)==true)
{
alert("Zip must be number&quot

;
return false;
}
}
</script>
</head>
<body>
<form method = "POST" name="registration" action = "

http://localhost/mk/details.asp"

onSubmit = "display()">
Username                  <input type ="text" name="username" size="30"><br>
Password                  <input type ="text" name="password" size="30"><br>
Confirm Password     <input type ="text" name="confirmpassword" size="30"><br>
Age                           <input type ="text" name="age" size="2"><br>
Sex                           <select name="sex" size="1"><br>
<option>Female
<option>Male
</select><br>
Address                    <input type ="text" name="address" size="30"><br>
Phone Number          <input type ="text" name="phonenumber" size="30"><br>
Country                     <select name="country" size="1"><br>
<option>Tanzania
<option>Kenya
<option>Uganda
<option>Zambia
<option>Zimbabwe
<option>Mozambique
</select><br>
Zip Code                   <input type ="text" name="zip" size="30"><br><br>

<input type="submit" value="Submit">

<input type="reset" value="Reset">
</form>
</body>
</html>

HellTel · Jun 16, 2003

onSubmit = "[red]return[/red] display()"

should do it for you.
Check out my faq faq216-2809

Let us know what happens then.....

Hope I helped / Thanks for helping
if ((Math.abs(x)<10&&Math.abs<10) && (((parseInt(Math.abs(x).toString()+Math.abs.toString())-Math.abs(x)-Math.abs)%9)!=0)) {alert("I'm a monkey's uncle"}

mit99mh · Jun 16, 2003

I agree with HellTel however to make your function work you have to also return "true" if the form is valid otherwise the form will never be submitted - you could change your function to:

function display()
{
var pass = string(document.registration.password.value);
var confirmpass = sring(document.registration.confirmpassword.value);

if (pass != confirmpass)
{
alert("Password and Confirm Password must be the same&quot

;
return false;
}

If (isNaN(document.registration.phonenumber.value)==true)
{
alert("Phone number must be numbers&quot

;
return false;
}

If (isNaN(document.registration.age.value)==true)
{
alert("Age must be in number&quot

;
document.registration.age.focus();
return false;
}

If (isNaN(document.registration.zip.value)==true)
{
alert("Zip must be number&quot

;
return false;
}
// else form is valid
return true;
}

HellTel · Jun 16, 2003

That's right, sorry.
Must learn to read sometime... [bigsmile]

(or ask my boss for more free-time [lol]

)

Hope I helped / Thanks for helping
if ((Math.abs(x)<10&&Math.abs<10) && (((parseInt(Math.abs(x).toString()+Math.abs.toString())-Math.abs(x)-Math.abs)%9)!=0)) {alert("I'm a monkey's uncle"}

mkisanko · Jun 16, 2003

I made the suggested changes but still the validation is not done and the form is submitted.
<html>
<head>
<script language="javascript">
function display()
{
var pass = string(document.registration.password.value);
var confirmpass = sring(document.registration.confirmpassword.value);

if (pass != confirmpass)
{
alert("Password and Confirm Password must be the same&quot

;
return false;
}
else
{
alert('That is correct, form will submit');
return true;
}

If (isNaN(document.registration.phonenumber.value)==true)
{
alert("Phone number must be numbers&quot

;
return false;
}
else
{
alert('That is correct, form will submit');
return true;
}

If (isNaN(document.registration.age.value)==true)
{
alert("Age must be in number&quot

;
document.registration.age.focus();
return false;
}
else
{
alert('That is correct, form will submit');
return true;
}

If (isNaN(document.registration.zip.value)==true)
{
alert("Zip must be number&quot

;
return false;
}
else
{
alert('That is correct, form will submit');
return true;
}
return true;
}
</script>
</head>
<body>
<form method = "POST" name="registration" action = "

http://localhost/callcenter/details.asp"

onSubmit = "return display()">
Username                  <input type ="text" name="username" size="30"><br>
Password                  <input type ="text" name="password" size="30"><br>
Confirm Password     <input type ="text" name="confirmpassword" size="30"><br>
Age                           <input type ="text" name="age" size="2"><br>
Sex                           <select name="sex" size="1"><br>
<option>Female
<option>Male
</select><br>
Address                    <input type ="text" name="address" size="30"><br>
Phone Number          <input type ="text" name="phonenumber" size="30"><br>
Country                     <select name="country" size="1"><br>
<option>Tanzania
<option>Kenya
<option>Uganda
<option>Zambia
<option>Zimbabwe
<option>Mozambique
</select><br>
Zip Code                   <input type ="text" name="zip" size="30"><br><br>
            
<input type="submit" value="Submit">
            
<input type="reset" value="Reset">
</form>
</body>
</html>

mit99mh · Jun 16, 2003

i think your function should read something like:
Hope this helps

function display()
{
var pass = string(document.registration.password.value);
var confirmpass = string(document.registration.confirmpassword.value);
var msg = "";

if (pass != confirmpass)
{
msg +="Password and Confirm Password must be the same";
}

if (isNaN(document.registration.phonenumber.value)==true)
{
msg +="Phone number must be numbers\n";
}

if (isNaN(document.registration.age.value)==true)
{
msg +="Age must be in number\n";
}

if (isNaN(document.registration.zip.value)==true)
{
msg +="Zip must be number\n";
}
if( msg.length == 0){
myForm.submit();
}
else{
alert(msg);
return false;
}
}

mkisanko · Jun 16, 2003

mit99mh; it is the same even that did not help.
Is there any other way I can do these validations?

HellTel · Jun 16, 2003

Here is a slightly rewritten function for you:

function display()
{
var isOK = true;

var pass = document.registration.password.value;
var confirmpass = document.registration.confirmpassword.value;

if (pass != confirmpass)
{
alert("Password and Confirm Password must be the same&quot

;
isOK = false;
}

if (isNaN(document.registration.phonenumber.value)==true)
{
alert("Phone number must be numbers&quot

;
isOK = false;
}

if (isNaN(document.registration.age.value)==true)
{
alert("Age must be in number&quot

;
document.registration.age.focus();
isOK = false;
}

if (isNaN(document.registration.zip.value)==true)
{
alert("Zip must be number&quot

;
return false;
}

return isOK;
}

Your if statements should not have a capital I.
if is if not If

Also, your function would submit straight away if the first condition was met because you were returning true then. This will exit the function and return to the caller. Better to send it back at the end like my example.

Hope I helped / Thanks for helping
if ((Math.abs(x)<10&&Math.abs<10) && (((parseInt(Math.abs(x).toString()+Math.abs.toString())-Math.abs(x)-Math.abs)%9)!=0)) {alert("I'm a monkey's uncle"}

HellTel · Jun 16, 2003

Here is a slightly rewritten function for you:

function display()
{
var isOK = true;

var pass = document.registration.password.value;
var confirmpass = document.registration.confirmpassword.value;

if (pass != confirmpass)
{
alert("Password and Confirm Password must be the same&quot

;
isOK = false;
}

if (isNaN(document.registration.phonenumber.value)==true)
{
alert("Phone number must be numbers&quot

;
isOK = false;
}

if (isNaN(document.registration.age.value)==true)
{
alert("Age must be in number&quot

;
document.registration.age.focus();
isOK = false;
}

if (isNaN(document.registration.zip.value)==true)
{
alert("Zip must be number&quot

;
isOK = false;
}

return isOK;
}

Your if statements should not have a capital I.
if is if not If

Also, your function would submit straight away if the first condition was met because you were returning true then. This will exit the function and return to the caller. Better to send it back at the end like my example.

Hope I helped / Thanks for helping
if ((Math.abs(x)<10&&Math.abs<10) && (((parseInt(Math.abs(x).toString()+Math.abs.toString())-Math.abs(x)-Math.abs)%9)!=0)) {alert("I'm a monkey's uncle"}

HellTel · Jun 16, 2003

Oops, use the second one.

Hope I helped / Thanks for helping
if ((Math.abs(x)<10&&Math.abs<10) && (((parseInt(Math.abs(x).toString()+Math.abs.toString())-Math.abs(x)-Math.abs)%9)!=0)) {alert("I'm a monkey's uncle"}

mkisanko · Jun 16, 2003

Thank you so much Helltel. Is there a way to do it on insert of each field?

HellTel · Jun 16, 2003

You could call a separate validation function for each field by doing something like this:
<input type ="text" name="confirmpassword" onchange="valPass()" size="30" ID="Text3">

and then having each function like this:

function valPass(){
var pass = document.registration.password.value;
var confirmpass = document.registration.confirmpassword.value;

if (pass != confirmpass)
{
alert("Password and Confirm Password must be the same&quot

;
isOK = false;
}
}

var isOK would have to be defined outside of all functions to make it global.
Then you'd have to check for the value of isOK in a validation function that executes when the form is submitted. But you'd also then have to check for empty fields.

It'd be more of a pain to do it that way, but is possible. If you don't like all the alerts, try concatenating the messages into a string, similar to mit99mh's method above and displaying the whole message at once.

Make sense? If not, give us a shout again.

Hope I helped / Thanks for helping
if ((Math.abs(x)<10&&Math.abs<10) && (((parseInt(Math.abs(x).toString()+Math.abs.toString())-Math.abs(x)-Math.abs)%9)!=0)) {alert("I'm a monkey's uncle"}

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

validation not executed 1

mkisanko

Programmer

HellTel

Programmer

mit99mh

Programmer

HellTel

Programmer

mkisanko

Programmer

mit99mh

Programmer

mkisanko

Programmer

HellTel

Programmer

HellTel

Programmer

HellTel

Programmer

mkisanko

Programmer

HellTel

Programmer

Similar threads

Part and Inventory Search

Sponsor