Using InStr and Select Case help 2

[EchoAlertcom]

Hello,

I need to use InStr and Select Case together and I'm not sure what to do. I would like to process a string and do something depending on which word is found. Could someone suggest where I'm going wrong. Or suggest an all-around better way to do it please?

strLine = "Georgia is on the East Coast"


Select Case strLine

	Case If InStr(strLine, "Florida") > 0 Then
		
		Response.Write "Florida"
		
	Case If InStr(strLine, "Georgia") > 0 Then
	
		Response.Write "Georgia"
		
	Case If InStr(strLine, "Alabama") > 0 Then
	
		Response.Write "Alabama"

	Case Else
		
		Response.Write "Other States"
		
End Case

Thank you,
Steve

 

[tsuji]

This is how it can be done.

[tt]strLine = "Georgia is on the East Coast"
Select Case true
Case InStr(1,strLine, "Florida",1) <> 0
Response.Write "Florida"
Case InStr(1,strLine, "Georgia",1) <> 0
Response.Write "Georgia"
Case InStr(1,strLine, "Alabama",1) <> 0
Response.Write "Alabama"
Case Else
Response.Write "Other States"
End Select
[/tt]
Notes: [1] Testing "<>0" is more efficient. [2] Add parameters (1,.,.,1) for case insensitivity.

 

[Sheco]

Using an array may be even more efficient:[tt]

strLine = "Georgia is on the East Coast"
arrWords = Split(strLine, " ")
For x = 0 to uBound(arrWords)
strState = arrWords(x)
Select Case strState
Case "Florida"
Exit For
Case "Georgia"
Exit For
Case "Alabama"
Exit For
Case Else
strState = "Other States"
End Select
Next
Response.Write strState
[/tt]

 

[tsuji]

>Using an array may be even more efficient:
I don't think so here. If one knows the place being the first word, why testing x=0 to ubound()? Just test data at x=0? No intention to ridiculize the method which is valid---I don't disagree. Efficient? I don't think so... But this is such a small matter that I wouldn't insist or convert even proven being wrong.

 

[Sheco]

I was thinking along the lines that calling InStr() for each state would be slower because it would parse the string for each state. So if there only 3 states this is not so bad but if there are 50 states then it could be improved.

 

[tsuji]

There is regexp too if we want more...

 

[EchoAlertcom]

Thank you both. It worked great.

I especially like the tip about case insensitivity.

Warmest Regards,
Steve