Trim filenames in folder from specific character 2

[Nu2Java]

I am using this code to trim filenames. I cannot figure out how to expand this to trim ALL files in the folder after the first SPACE from the left in the filename.

Before: 41-010 Rev A.txt
After: 41-010.txt

My Code:

strComputer = "."

Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")

Set colFiles = objWMIService.ExecQuery _
("ASSOCIATORS OF {Win32_Directory.Name='C:\Scripts'} Where " & "ResultClass = CIM_DataFile")

For Each objFile In colFiles

    strPath = objFile.Drive & objFile.Path
    strExtension = objFile.Extension
    strFileName = objFile.FileName


    If Right(strFileName, 1) = "A" Then

        intLength = Len(strFileName)
        strFileName = Left(strFileName, intLength - 6)

    End If

    strNewName = strPath & strFileName & "." & strExtension
    errResult = objFile.Rename(strNewName)

Next

 

[guitarzan]

Something like this should work

For Each objFile In colFiles

    strPath = objFile.Drive & objFile.Path
    strExtension = objFile.Extension
    strFileName = objFile.FileName

    [highlight #FCE94F]p = InStr(strFileName, " ")[/highlight]
    [highlight #FCE94F]If p > 0 Then[/highlight]
        [highlight #FCE94F]strFileName = Left(strFileName, p - 1)[/highlight]
        strNewName = strPath & strFileName & "." & strExtension
        errResult = objFile.Rename(strNewName)
    [highlight #FCE94F]End If[/highlight]
Next

 

[Nu2Java]

Thanks guitarzan, this works great!

 

[strongm]

Or, if you like brevity, the slightly shorter:

[blue]For Each objFile In colFiles
    With objFile
        errResult = .Rename(.Drive & .Path & Split(.FileName, " ")(0) & "." & .Extension)
    End With
Next[/blue]

 

[Nu2Java]

Thanks strongm, this is another great option that works great.

 

[Nu2Java]

Strangely, I ran both methods two different times and got a couple filenames that did not change. Maybe one of you can figure out why.

4-961010-02 revE.txt

** UPDATE: This seems to happen just randomly. It will just skip some files for what seems like no apparent reason. After it finishes, I delete all other files in the folder and keep a handful that did not change. When I re-run the code, those files change and are correct.

 

[strongm]

>It will just skip some files for what seems like no apparent reason

I suspect that may be down to the usage of WMI to get the folder listing

 

[Nu2Java]

strongm; is there a way to fix that?

 

[strongm]

Yes, you could use the filesystemobject

 

[Nu2Java]

I'm lost... not sure how I need to incorporate that into this code.

 

[guitarzan]

The quick answer is, your loop would change to:

Set fso = CreateObject("Scripting.FileSystemObject")
Set colFiles = fso.GetFolder("C:\Scripts").Files

For Each objFile In colFiles

   ...

Next

But the FileSystem Object has different methods than the WMI way you were using, so the code inside the loop would have to change. For now, here is a reference to FSO's methods

http://www.devguru.com/content/technologies/vbscript/14048.html