string parsing problems

[malonep]

Hi,

I have this small function to replace characters so symbols can be properly displayed in a textarea. In one function it is called multiple times

  comment = replaceAll(comment,'#','#');
	    comment = replaceAll(comment,'>','>');
	    comment = replaceAll(comment,'&lt;','<');
   	    comment = replaceAll(comment,'&#58;','?');
	    comment = replaceAll(comment,'&#39;','\''); 
	    comment = replaceAll(comment,'&#37;','%');
	    comment = replaceAll(comment,'&#45;','-');
	    comment = replaceAll(comment,'&#47;','//');
	    comment = replaceAll(comment,'&#34;','"');

The function that does this is

function replaceAll(str,old,to) {
        var index;
        var newstr;
   	 	
        newstr = str;
        index = newstr.indexOf( old );	
   	while ( index > -1 ) {
   		newstr = newstr.replace( old, to ); 
   		index = newstr.indexOf( old );
   	}
   	return newstr;
}

This method is working perfectly for windows ie/netscape and mac safari but for some reason on a mac IE I get the error "Invalid Character" and the line number indicates "var index;" line in the replace all function

Any help would be appreciated
Thanks,
malonep

 

[tgreer]

I don't have a Mac to test with. I'm just noting that "index" is often a reserved word in many programming languages.



Thomas D. Greer

http://www.tgreer.com

Providing PostScript & PDF
Training, Development & Consulting

 

[malonep]

Hi,

I changed index to be idx and the same issue is occurring

Thanks,

 

[chessbot]

Why are you using a replaceAll function when you can use regex?

  comment = comment.replace(/#/g,'#');
  comment = comment.replace(/>/g,'>');
  comment = comment.replace(/</g,'&lt;');
  comment = comment.replace(/\?/g,'&#58;');
  comment = comment.replace(/'/g,'&#39;');
  comment = comment.replace(/%/g,'&#37;');
  comment = comment.replace(/-/g,'&#45;');
  comment = comment.replace(/\//g,'&#47;');
  comment = comment.replace(/"/g,'&#34;');

Also, you are calling

   comment = replaceAll(comment,'/','//');

"//" initalizes a comment. Try using "\/".

--Chessbot

"Violence is the last refuge of the incompetent." -- Asimov, Foundation