str_replace and semicolons

[nationavon]

I have the following function:

// convert characters to html
function convertstring($string) {
// variables
$search = array("~","`","!","@","#","\$","%","^","&","*","(",")","_","-","+","=","{",
"[","}","]","|","\\",":",";",'"',"'","<",",",">",".","?","/");
$replace = array("&#126;","&#96;","&#33;","&#64;","&#35;","&#36;","&#37;","&#94;",
"&#38;","&#42;","&#40;","&#41;","&#95;","&#45;","&#43;","&#61;","&#123;",
"&#91;","&#125;","&#93;","&#124;","&#92;","&#58;","&#59;","&#34;","&#39;",
"&#60;","&#44;","&#62;","&#46;","&#63;","&#47;");
return str_replace($search, $replace, $string);
}

If I pass it something like

http://www.tek-tips.com

it returns:
http&#58&#59;&#47;&#47;

http://www&#46;tek&#45&#59;tips&#46;com

or
http:;//

http://www.tek-;tips.com

For some reason it is also converting the semi-colon in the first &#58; to &#59;. Any ideas why this is? If I remove the semi-colon from the search array it works correctly.

Thanks,
Nathan

 

[jman78]

Hi Nathan...

The why first -

You are sending the string (

http://www.tek-tips.com)

through the loop and modifying it each time. Since you check for the semi-colon after you check for several other characters, it will convert all semi-colons (including semi-colons that were put in the string by your function from previous loops!)


i.e. -

iterations - output
===========================
0 - [URL unfurl="true"]http://www.tek-tips.com[/URL]
1 - [URL unfurl="true"]http://www.tek-tips.com[/URL]
.
.
.
14 - [URL unfurl="true"]http://www.tek-tips.com[/URL]
.
.
23 - http://[URL unfurl="true"]www.tek-tips.com[/URL]
24 - http&#58&#59;//[URL unfurl="true"]www.tek&#45&#59;tips.com[/URL] //<-- this is where it parses the semi-colons out
...

A simple fix would be to check for the semi-colon on the first iteration.


Jason

 

[nationavon]

Jason,

Thanks for the reply! I understand the why now. If I move the semicolon to the first position, it fixes an example like

http://www.tek-tips.com.

The problem now is if I pass Hello; I get:

Hello&#38;#59;

I think the best thing would be to create a loop that works on a character in the string at a time.

Nathan

 

[jpadie]

use strtr() instead

function convertstring($string) {
  // variables
  $search = array("~","`","!","@","#","\$","%","^","&","*","(",")","_","-","+","=","{",
"[","}","]","|","\\",":",";",'"',"'","<",",",">",".","?","/");
  $replace = array("&#126;","&#96;","&#33;","&#64;","&#35;","&#36;","&#37;","&#94;",
"&#38;","&#42;","&#40;","&#41;","&#95;","&#45;","&#43;","&#61;","&#123;",
"&#91;","&#125;","&#93;","&#124;","&#92;","&#58;","&#59;","&#34;","&#39;",
"&#60;","&#44;","&#62;","&#46;","&#63;","&#47;");
  return strtr($search, $replace, $string);
}

 

[jpadie]

oops, i forgot to translate your arrays first. they must be in pairs; not to mention that the strtr function arguments are reversed...

<?php
function convertstring($string) {
	// variables
	$search = array("~","`","!","@","#","\$","%","^","&","*","(",")","_","-","+","=","{",
"[","}","]","|","\\",":",";",'"',"'","<",",",">",".","?","/");
	$replace = array("&#126;","&#96;","&#33;","&#64;","&#35;","&#36;","&#37;","&#94;",
"&#38;","&#42;","&#40;","&#41;","&#95;","&#45;","&#43;","&#61;","&#123;",
"&#91;","&#125;","&#93;","&#124;","&#92;","&#58;","&#59;","&#34;","&#39;",
"&#60;","&#44;","&#62;","&#46;","&#63;","&#47;");
	
	return strtr($string, convertArray($search, $replace));
}

function convertArray($search, $replace){
	$return = array();
	foreach ($search as $key=>$val){
		$return[$val] = $replace[$key];
	}
	return $return;
}
?>

 

[nationavon]

jpadie,

That worked like a charm!

Thanks,
Nathan