Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Register Log in
  • Congratulations Mike Lewis on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

simple MySQL problem 2

Status
Not open for further replies.
Murugs

Murugs

Technical User
Jun 24, 2002
549
0
0
US
My HTML
<html>
<head>
<h1>
User Registration
</h1>
<form method=post action=&quot;create_entry.php&quot;>
</head>
<body bgcolor=&quot;green&quot;>
<b>
<br>
Username
<br>
</b>
<input type=text size=15 name=username>
<br>
<b>
UserPassword
</b>
<br>
<input type=password size=15 name=password>
<br>
<input type=submit name=submit value=&quot;Register&quot;>
<input type=reset name=reset value=&quot;Clear&quot;>
</form>
</body>
</html>

This is My PHP create_entry.php script
<?php

mysql_connect(&quot;localhost&quot;, &quot;root&quot;, &quot;root&quot;) or
die (&quot;Could not connect to database&quot;);
mysql_select_db(&quot;user&quot;) or
dir (&quot;Could not select database&quot;);

if ($submit == &quot;Register&quot;)
{
$query = &quot;insert into users (username, password) values ('$username', '$password')&quot;;
mysql_query($query) or
die (mysql_error());
}
?>
<h3>You are now registered</h3>
<a href=&quot;login.html&quot;>Go back to main page</a>

user is my database
users is my table inside the database.

But when I enter some username and password nothing is updated in to the database.

where is the problem..

regards
MP
 
Sort by date Sort by votes
I see multiple problems here.

First, none of your code will work without the PHP runtime configuration directive &quot;register_globals&quot; being set to &quot;on&quot;. The default is &quot;off&quot;, and it should be left that way ( You should reference your variables via the superglobal arrays, specifically in this case $_POST (
Second, your code depends on a submit button's actually submitting something to the server. This is not necessarily the case, particularly with newer browsers. Check for the presence of one of your text fields instead.

General debugging advice: faq434-2999

Want the best answers? Ask the best questions: TANSTAAFL!!
 
Upvote 0 Downvote
Try echoing $submit to check its value. I think you need to use $_GET($submit). (Also for $username & $password)

Also, I would put in some logic to let you know the update happened. If it didn't it will exit the IF ($submit == &quot;Register&quot;) statement and still give a message that you are registered. (include the message within the IF statment and create an ELSE statement with an error message).

Regards,
 
Upvote 0 Downvote
sorry, it should have been $_POST(...) to get the form variable not $_GET.....
 
Upvote 0 Downvote
Finally It worked ..
if ($_POST['submit'] == &quot;Register&quot;)

and

$query = &quot;INSERT INTO users values
('$_POST[username]','$_POST[password]')&quot;;

Thanks guys...
 
Upvote 0 Downvote
I am really new to PHP and MySQl..What is this register_globals..and how important is this php.ini file.
My current case is set for register_globals to off.
 
Upvote 0 Downvote
Hello Sleipnir..
I have read thru the link and getting a feel of PHP...
Today is my first day in PHP..I know I need to do more homework..Thanks for ur tips and suggestions...But now I am in next part...and again same problem..
Now I am authenticating the users with the values entered in to the database.


if ($_POST['submit'] == &quot;Login&quot;)
{
mysql_connect(&quot;localhost&quot;, &quot;root&quot;, &quot;root&quot;) or
die (&quot;Could not connect to database&quot;);

mysql_select_db(&quot;user&quot;) or
dir (&quot;Could not select database&quot;);

$result=mysql_query(&quot;select * from user where username='$_POST[username]'&quot;)
or die (&quot;cant do it&quot;);

while ($row=mysql_fetch_array($result)) {
if ($row[&quot;password&quot;]=='$_POST[password]' )
{
printf(&quot;Successfully Logged In!&quot;);
}else{
print(&quot;Nope&quot;);

getting execution errors all the time.
 
Upvote 0 Downvote
&quot;execution errors all the time&quot; is awfully vague.

PHP's error messages are pretty good. The only one that really gives people fits is &quot;Parse error&quot;, but this is only because PHP does not report the line number at which it became confused, but rather the line number at which it realized it became confused. A lot of the time, the actual code error that forced a parse error exists on a line earlier than reported.

Beyond that advice, I can only comment generally.

This line:
Code: 
result=mysql_query(&quot;select * from user where username='$_POST[username]'&quot;) or die (&quot;cant do it&quot;);

is going to give PHP heartburn. PHP doesn't handle well associative array references inside of quotes. I've generally found it safer to use something like:

Code: 
result=mysql_query(&quot;select * from user where username='&quot; . $_POST['username'] . &quot;'&quot;) or die (&quot;cant do it&quot;);

Want the best answers? Ask the best questions: TANSTAAFL!!
 
Upvote 0 Downvote
Status
Not open for further replies.

Similar threads

SashaBuilder3
  • Locked
  • Question
import CSV file into MySql table in PhpMyAdmin
Replies
0
Views
120
SashaBuilder3
SashaBuilder3
lexer
  • Locked
  • Question
Join two mysql tables for populate datatable
Replies
3
Views
97
spamjim
spamjim
EdLentz
  • Locked
  • Question
I need a simple example of how to send a table of info .
Replies
8
Views
146
EdLentz
EdLentz
ersatz
  • Locked
  • Question
How to send 2 select from mysql database in email like tables
Replies
5
Views
152
ersatz
ersatz
lexer
  • Locked
  • Question
Fetching Data from Mysql and filling Inputs in a Form
Replies
0
Views
57
lexer
lexer

Part and Inventory Search

Sponsor

Back
Top