Separating repeating code in c#

[mellenburg]

I'm very new to programming in .Net and object-oriented programming. I have a working program that can be refactored by putting repeated lines of code in a single location and the n referencing that piece of code. For example, I have the following code in my OnLoad event:

private void Page_Load(object sender, System.EventArgs e)
{
  if (!IsPostBack) 
  {
    SqlConnection sqlConn = new SqlConnection("Data Source=XXXX;Database=XXXX;user id=XXXX;password=XXXX;");
    
    // Retrieve User appointments
    SqlCommand sqlGetAppointments = new SqlCommand("MassageGetAppointmentsForUser", sqlConn);
    sqlGetAppointments.CommandType = CommandType.StoredProcedure;
    sqlGetAppointments.Parameters.Add("@UserID", SqlDbType.VarChar).Value = User.Identity.Name;
    sqlConn.Open();
    SqlDataReader sqlDRAppointments = sqlGetAppointments.ExecuteReader();
    dgMassageAppointments.DataSource=sqlDRAppointments;
    dgMassageAppointments.DataBind();
    sqlConn.Close();  
  }
}

The SqlConnection line gets used in other places in the code behind file. Rather than have the entire connection string, I'd like to be able to replace the line with something like

GetConnection();

How do I do this?

Matt

 

[jbenson001]

I would put that code in a function in a class file that returns a string.

 

[jmeckley]

use the connection string settings in the web.config to store the connection string. you can encrypt the connection string in the web.config if security is an issue.

Jason Meckley
Programmer
Specialty Bakers, Inc.

 

[mellenburg]

I'm very new to c# and OOP, so I understand both suggestions, but I don't know how to do either. Can someone give me some sample code?

 

[ca8msm]

Use the ConfigurationManager.ConnectionStrings property


____________________________________________________________
Mark,
[URL unfurl="true"]http://aspnetlibrary.com[/url]

Need help finding an answer? Try the Search Facility or read FAQ222-2244.

 

[mellenburg]

Ok, so I have this in my web.config page now.

 <appSettings>
		<add key="SqlConnect" value="server=xxxx;database=xxx;uid=xxx;pwd=xxx;" />		
 </appSettings>

How do I make use of the SqlConnect key instead of writing the line

    SqlConnection sqlConn = new SqlConnection("Data Source=XXXX;Database=XXXX;user id=XXXX;password=XXXX;");

in my onload event?

 

[ca8msm]

If you've placed the variable in the appSettings section then you would use:

ConfigurationManager.AppSettings["MyKey"]

However, connection strings should be placed in the connectionStrings section and retrived by using:

ConfigurationManager.ConnectionStrings["myConKey"].ConnectionString

You may also want to read

http://msdn2.microsoft.com/en-us/library/ms178411(vs.90).aspx

____________________________________________________________
Mark,
[URL unfurl="true"]http://aspnetlibrary.com[/url]

Need help finding an answer? Try the Search Facility or read FAQ222-2244.