Replacing spaces in perl with %20 for netscape

oshjosh · Aug 10, 2002

Hi I have a search program that searches using a "keyword" search parameter. Sometimes the keywords have a space.

My program starts like this.

#!/usr/bin/perl
use CGI;
$req = new CGI;
$keywordpara = $req->param('Keywords');
$datadir = "/home/

http://www/shopinfo";

open(FILE,"$datadir/data.log&quot

;
@data = <FILE>;
close(FILE);
print "content-type:text/html\n\n";
$num = @data;
$result=0; $i=0; $j=0; $a=0;
foreach $data (@data) {
($id,$simage,$bimage,$artist,$ref,$size,$desc,$price,$title,$display,$Category,$Keywords) = split(/::/, $data);
if (($artist =~ /\b$keywordpara/i)||($title =~ /\b$keywordpara/i)) {
#if (($Category eq $categorypara)) {
$result++;
}
}
$page = $req->param('page');
if ($page eq '') { $page=0;}
else { $line = $page*6; }

Then prints the data depending on the keywords using this.

foreach $data (@data) {
($id,$simage,$bimage,$artist,$ref,$size,$desc,$price,$title,$display,$Category,$Keywords) = split(/::/, $data);
if (($artist =~ /\b$keywordpara/i)||($title =~ /\b$keywordpara/i)) {
$a++;
if ($a <= $line) {
next;
}
else {
$i++;$j++;
if ($j <= 6) {
if ($i==1) {
print "<tr>";
}
etc...

It works fine for the first search as I have replaced all the spaces in my links with %20

However at the end of the program I have a link to next page section:

print "<CENTER><table><tr><td>page - ";
$num_of_page = $result/6;
for($b=0;$b<$num_of_page;$b++)
{
$view = $b+1;
print "<a class=\"cgilink\" href=\"

http://www.abacus-gallery.com/cgi-b...ywords=$keywordpara\">$view</a> ";

}
print "</td></tr></table></CENTER>";

The problem is that in Netscape even when the URL has the spaces replaced in the keywords with %20 the link to page part of the cgi program (search.cgi?page=$b&Keywords=$keywordpara) is not picking this up and therefore is not displaying the next page results in Netscape.

I'm not very experienced in perl so simple answers would be much appreciated..

Thanks in advance.. Rob

abbeman · Aug 11, 2002

To replace all spaces with "%20" you would do

my $string = "test of replace"
$string =~ s/ /%20/g

However, there are several other characters that have to be escaped if ther are to be sent in paremeters through a URL (such as "?", ";" or "&&quot

. My guess is there is a function to handle this sort of escaping in the CGI package.

oshjosh · Aug 11, 2002

Thanks for taking the time to respond however where would I put that? my perl knowledge wont even take me that far I am afraid..

Thanks again..
Rob

abbeman · Aug 12, 2002

I'm not sure I've gotten your code correctly, but I think you would want it in the last for-loop. just before printing the URL. Do it on all the variables you use for constructing the URL, ie $b and $keywordpara.

That should do it.

oshjosh · Aug 12, 2002

Hi abbeman

I have pasted the whole script below in the hope you can help further.. Ive added in as you said at the bottom on the loop just before printing the URL, however netscape is still showing the URL with spaces and gives it as a bad reqest.

Example..

http://www.abacus-gallery.com/cgi-bin/shop/search-key.cgi?Keywords=van+gogh

works Ok as the link has the space replaced with a + however at the bottom of the page the next page links are still using a space rather than replacing it with %20

Thanks if you can help

Rob

#!/usr/bin/perl
use CGI;
$req = new CGI;
$keywordpara = $req->param('Keywords');
$datadir = "/home/oshjosh/abacus-gallery.com/

http://www/shopinfo";

open(FILE,"$datadir/data.log&quot

;
@data = <FILE>;
close(FILE);
print "content-type:text/html\n\n";
$num = @data;
$result=0; $i=0; $j=0; $a=0;
foreach $data (@data) {
($id,$simage,$bimage,$artist,$ref,$size,$desc,$price,$title,$display,$Category,$Keywords) = split(/::/, $data);
if (($artist =~ /\b$keywordpara/i)||($title =~ /\b$keywordpara/i)) {
#if (($Category eq $categorypara)) {
$result++;
}
}
$page = $req->param('page');
if ($page eq '') { $page=0;}
else { $line = $page*6; }
######header########
open(FILE,"top.txt&quot

;
@header = <FILE>;
close(FILE);
foreach $header (@header) {
print "$header";
}
#####3##############
print "<table><tr><td width=\"39\" valign=\"top\" align=\"left\"></td><td width=\"409\" valign=\"top\" align=\"left\">$keywordpara <img src=\"

http://www.abacus-gallery.com/media/images/short-horiz.gif\"

width=\"260\" height=\"11\"></td><td width=\"326\" valign=\"top\" align=\"left\"></td></tr></table> ";

#start Bonnard Testimonial
if ($keywordpara eq "Pierre Bonnard&quot

{
print "<center>\"Thank you so much for a wonderful painting. Bonnard is my favorite artist and now I own a perfect reproduction. It arrived on time just as you promised.\" Mario Schiavonne, Milan, Italy.</center> ";
}
#end changes Bonnard Testimonial

#start Monet Testimonial
if ($keywordpara eq "Claude Monet&quot

{
print "<center>\"My designer recommended you and I am so glad she did. The Monet painting is fabulous and I will for sure be ordering another very shortly. A fantastic painting! Thank you.\" Betsey Drover, Michigan Il.</center> ";
}
#end changes Monet Testimonial

#start Warhol Testimonial
if ($keywordpara eq "Andy Warhol&quot

{
print "<center>\"My wife and I were truly delighted to receive our \"Warhol Shoes\" from you. It is an excellent reproduction for which we are most grateful. \" Robert and Sarah Mullen, Leicester. UK.</center> ";
}
#end changes Warhol Testimonial

#start Edward Hopper Testimonial
if ($keywordpara eq "Edward Hopper&quot

{
print "<center>\"My painting arrived this morning. You have captured the light perfectly; it's an excellent piece of work. Thank you so much. \" Abrams, Charleston. (Hopper's Sunday Morning).</center> ";
}
#end Edward Hopper Testimonial

#start Paul Gauguin Testimonial
if ($keywordpara eq "Paul Gauguin&quot

{
print "<center>\"Dear Sirs, A few months back I ordered Tahitian Women by Paul Gauguin and I now wish to order Tahitian Mountains as I am so pleased with the first one. I look forward to receiving this painting soon. \" Fiona McNally, Fulham, London.</center> ";
}
#end Paul Gauguin Testimonial

#start Tamara de Lempicka Testimonial
if ($keywordpara eq "Tamara de Lempicka&quot

{
print "<center>\"Hi Katie, I just received my Auto-Portrait reproduction of Tamara de Lempicka's work. How do you do it? It's amazing, you've been so sweet and patient answering all my questions and I am thrilled with the result. Thank you again. \" Timothy Charlston, Sacramento.</center> ";
}
#end Tamara de Lempicka Testimonial

#start Picasso Testimonial
if ($keywordpara eq "Pablo Picasso&quot

{
print "<center>\"Hello, My fabulous painting arrived yesterday. I can't wait to get it to the framers and up on the wall. It just adds the finishing touches to my new home. Could you do another Picasso for me? The one I want isn't shown but I can give you all the details? \" Paul and Jackie Lo, Florida.</center> ";
}
#end Picasso Testimonial

#start Monet Testimonial
if ($keywordpara eq "Claude Monet&quot

{
print "<center>\"Great Service and Great Painting. Keep up the good work. \" Cherie Marsden, Nairobi. (Monet and van Gogh).</center> ";
}
#end Monet Testimonial

#start Van Gogh Testimonial
if ($keywordpara eq "Vincent van Gogh&quot

{
print "<center>\"Great Service and Great Painting. Keep up the good work. \" Cherie Marsden, Nairobi. (Monet and van Gogh).</center> ";
}
#end Van Gogh Testimonial

#start Matisse Testimonial
if ($keywordpara eq "Henri Matisse&quot

{
print "<center>\"I had to write to congratulate you on the service you offer. My painting (Matisse 'The Dream') arrived was so beautifully packaged and it arrived just on time as you promised it would. I am sure to be in contacting you again.\" Jerome Nibbs, Southampton UK.</center> ";
}
#end Matisse Testimonial

#start Klimt Testimonial
if ($keywordpara eq "Gustav Klimt&quot

{
print "<center>\"My wife has always admired the work of Klimt and The Kiss is her favourites. I am so pleased to have been recommended to you by a friend and chosen this painting for our 10th Wedding anniversary. She is delighted with the present and it will give us both much pleasure over the next 10 years.\" Sincerely, Joshua Cohen, Hampstead, London.</center> ";
}
#end Klimt Testimonial

print "<table cellpadding=0 cellspacing=0 width=100%>";

foreach $data (@data) {
($id,$simage,$bimage,$artist,$ref,$size,$desc,$price,$title,$display,$Category,$Keywords) = split(/::/, $data);
if (($artist =~ /\b$keywordpara/i)||($title =~ /\b$keywordpara/i)) {
#if (($Medium eq $mediumpara) && ($Category eq $categorypara)) {
$a++;
if ($a <= $line) {
next;
}
else {
$i++;$j++;
if ($j <= 6) {
if ($i==1) {
print "<tr>";
}
print"<td width=30% align=center valign=top>";
print "<table border=\"1\" cellpadding=\"0\" cellspacing=\"0\" bordercolor=\"#727272\" bordercolorlight=\"#727272\" bordercolordark=\"#727272\"><tr><td><img src=\"$simage\" alt=\"$artist $title\"></a></td></tr></table> \$$price $artist $title $size <a class=\"cgilink\" href=\"

http://www.abacus-gallery.com/cgi-bin/shop/shop.pl?fid=$id&cgifunction=form\">Order

this Painting<a/> ";

if ($poster eq "1&quot

{
print "or <a class=\"cgilink\" href=\"

https://www.2checkout.com/cgi-bin/b...=3146&total=$posterprice&cart_order_id=$title

poster\">Order a Color Poster</a> $Postersize,\$$posterprice ";
}
print "</td>";
if ($i == 3) {
print "</tr><tr height=\"22\"></tr>";
$i = 0;
}
} # end j <=6
else { last;}
} # end show
} # end if

} # end foreach
print "</table>";

print "<CENTER><table><tr><td>page - ";
$num_of_page = $result/6;
for($b=0;$b<$num_of_page;$b++)
{
$view = $b+1;
my $string = "test of replace"
$string =~ s/ /%20/g
print "<a class=\"cgilink\" href=\"

http://www.abacus-gallery.com/cgi-b...ywords=$keywordpara\">$view</a> ";

}
print "</td></tr></table></CENTER>";
#### footer #######
open(FILE,"bottom.txt&quot

;
@footer = <FILE>;
close(FILE);
foreach $footer (@footer) {
print "$footer";
}

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Replacing spaces in perl with %20 for netscape

oshjosh

Technical User

abbeman

Programmer

oshjosh

Technical User

abbeman

Programmer

oshjosh

Technical User

Similar threads

Part and Inventory Search

Sponsor