remove a , from a string 1

[MJB3K]

Hi, i have this code which outputs data from a MySQL db seperated by ,'s. i would like to know how to remove the last , from the list... any ideas??

mycode:

<?php

include "../../nep-yb/config.php";

$i=0;

$qT = mysql_query("SELECT uid FROM member") or die(mysql_error());
$amt = mysql_num_rows($qT);
echo "&amnt=$amt";
//
echo "&user=";
$q = mysql_query("SELECT nick FROM member") or die(mysql_error());
	while(list($n) = mysql_fetch_row($q)){
		echo $n . ",";
	}
//
echo "&uid=";
$q = mysql_query("SELECT uid FROM member") or die(mysql_error());
	while(list($uid) = mysql_fetch_row($q)){
		echo $uid . ",";
	}
?>

any ideas??


Regards,

Martin

Gaming Help And Info:

http://gaming.webrevolt.biz

 

[kenrbnsn]

Instead of building the list like you're doing, use a temporary array and then use implode to echo your comma seperated string.

$tmp = array();
$q = mysql_query("SELECT nick FROM member") or die(mysql_error());
    while(list($n) = mysql_fetch_row($q))
        $tmp[] = $n;
    echo implode(',',$tmp);

Do the same for your other list.

Ken

 

[GOstlund]

<?php

include "../../nep-yb/config.php";

$i=0;

$qT = mysql_query("SELECT uid FROM member") or die(mysql_error());
$amt = mysql_num_rows($qT);
echo "&amnt=$amt";
//
echo "&user=";
$q = mysql_query("SELECT nick FROM member") or die(mysql_error());
    while(list($n) = mysql_fetch_row($q)){
        echo $n . ($i++<=$amt)?",":"";
    }
//
echo "&uid=";
$i=0;
$q = mysql_query("SELECT uid FROM member") or die(mysql_error());
    while(list($uid) = mysql_fetch_row($q)){
        echo $uid . ($i++<=$amt)?",":"";
    }
?>

----------
HTH
Gavin Ostlund

 

[MJB3K]

none of them work, GOstlund your one just produces lots of ,,,,,,

any other ideas??

Regards,

Martin

Gaming Help And Info:

http://gaming.webrevolt.biz

 

[GOstlund]

Ok, I admit, I was trying to be lazy and change as little as possible by just inserting 3 small parts... I shoulda thought it through and done it right, which I'll endevour to do now.

<?php

include "../../nep-yb/config.php";

$i=0;

$qT = mysql_query("SELECT uid FROM member") or die(mysql_error());
$amt = mysql_num_rows($qT);
echo "&amnt=$amt";
//
echo "&user=";
$q = mysql_query("SELECT nick FROM member") or die(mysql_error());
    while(list($n) = mysql_fetch_row($q)){
        echo $n;
        if($i++<=$amt)
                echo ",";
    }
//
echo "&uid=";
$i=0;
$q = mysql_query("SELECT uid FROM member") or die(mysql_error());
    while(list($uid) = mysql_fetch_row($q)){
        echo $uid;
        if($i++<=$amt)
                echo ",";
    }
?>

That *should* work better... however, I don't have immediate access to a php parser to confirm it...

----------
HTH
Gavin Ostlund

 

[MJB3K]

yea, it doesn't take away the last ,

http://www.webrevolt.biz/work/lobby/getUserList2.php

^^ see ^^

any other ideas??

would substr be needed?

Regards,

Martin

Gaming Help And Info:

http://gaming.webrevolt.biz

 

[GOstlund]

Aight, in my last submission, change the <= to just < and that should finally fix it...

----------
HTH
Gavin Ostlund

 

[skiflyer]

You can also do an

rtrim($string, ',');

to remove any trailing commas

 

[kenrbnsn]

When you said "none of them work", what happened when you tried the implode method?

Ken