Question about if statment

[MinnisotaFreezing]

Hey,

I have written and seen if statments writen both of the following ways:

CString string = "Happy";
if (string.GetLength() != 0)
DoSomthing

and

if (int ret = string.GetLength() != 0)
DoSomthing

As far as I can tell, they both work the same way, but it seems like MSDN prefers the second way. I like the first because it is shorter. Any arguments for or against either one?

CJB

 

[gxlzlu]

I prefer to the first one!

 

[IonelBurtan]

The first one is better because you don't have to allocate and assign an supplementary int value.

However, the second for is more often used in other statements where it helps claryfing the code:

if(TRUE == (IsThisNumber2()== 2)) ....

or in COM in comparison with constant like NOERROR, E_FAIL and so on...

HTH, s-)

Blessed is he who in the name of justice and goodwill, sheperds the weak through the valley of darkness...

http://www20.brinkster.com/ionelb

 

[VincentP]

In the second case, you can have:

if( (int ret = string.GetLength())!= 0 )
{
do something using ret instead of calling GetLength again
}

That's what is usefull in that case.

Vincent

 

[DavesTips]

Of course, ret will always be 1, which is maybe not so useful

More sensible is maybe

if (int len = string.GetLength())

where you have the string length in len...
Hope that this helped!