Public variables?

[ejrhodes]

I am experimenting with AJAX and I am running into an issue.


On my page, I have multiple spans with a similar naming convention. eg showtext1, showtext2, showtext3. On the click of another span, I pass my AJAX functions a paramater. One of these parameters is a number that corresponds to the number following showtext. I want to pass the resulting response text to the innerhtml of the correct span.


My current code is:


id=showtext1
id=showtext2, etc.

What I want to do is on the click of a span, I call a javascript function. I pass the function a parameter called temp3 that contains an integer (1, 2, 3, etc)

Code:

function showQuestion(url2, str, temp3, temp4)

{ xmlHttp=GetXmlHttpObject()

if (xmlHttp==null)

{
alert ("Browser does not support HTTP Request")
return
}

public var a=temp3;
var url=url2;
url=url+"?id="+str;
xmlHttp.onreadystatechange=stateChanged2;

xmlHttp.open("POST",url,true);

xmlHttp.send(null);

}

function stateChanged2()

{

if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")

{
b="showtext" + a;
document.getElementById(b).innerHTML=xmlHttp.responseText

}

}



I am trying to pass a public variable to my 2nd function stateChanged2 but I keep getting an error about a missing ;. If I cant set a public variable, how can I dynmically call the correct showtext span?

 

[BillyRayPreachersSon]

Remove the words "public var" from your variable declaration.

"Public" isn't a valid keyword in JS to define a varible (AFAIK), and using "var" will give it local scope.

That aside, why not pass it into your return function? That way, you'l be able to use this reuqest more than once without causing issues.

Hope this helps,
Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[ejrhodes]

I tried passing it to my function but I kept getting a type mismatch error.

I originally tried:

function showQuestion(url2, str, temp3, temp4)

{ xmlHttp=GetXmlHttpObject()

if (xmlHttp==null)

{
alert ("Browser does not support HTTP Request")
return
}


var url=url2;
url=url+"?id="+str;
xmlHttp.onreadystatechange=stateChanged2(temp3);

xmlHttp.open("POST",url,true);

xmlHttp.send(null);

}

function stateChanged2(a)

{

if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")

{
b="showtext" + a;
document.getElementById(b).innerHTML=xmlHttp.responseText

}

}

 

[BillyRayPreachersSon]

You can't do this:

xmlHttp.onreadystatechange=stateChanged2(temp3);

as that will call the callback function immediately.

Dan

Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[ejrhodes]

So then how would I pass the variable to the function?

 

[cLFlaVA]

you can try this:

xmlHttp.onreadystatechange= function() { stateChanged2(temp3); };

*cLFlaVA
----------------------------
[tt]somebody set up us the bomb![/tt]

[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[ejrhodes]

CLFlava, as always, you are the man. Thanks for your help, that fixed it.

 

[cLFlaVA]

Dan is a better man than I, although I appreciate your kind words. Glad we could help.



*cLFlaVA
----------------------------
[tt]somebody set up us the bomb![/tt]

[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[ejrhodes]

Well you both are the man THis was driving me absolutely crazy.

 

[BillyRayPreachersSon]

I wouldn't say better... just older ;-)



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]