Problems getting 'onClick' to work via function

[SLaut]

I've recently started learning JavaScript to get a portfolio done and run into a problem I just can't solve...

I have a bunch of thumbnails whose linked images and their links (with pop-up windows) should change along what section the viewer's at. I've gotten the pictures to work perfectly with a function that changes them with the document.getElementById('x').src="x.jpg" bit but for some reason, when I get a link by its id and change the onClick value (the code I'm using is document.getElementById('kuva2').onClick="javascript:window.open('digital-paintings/1.htm','dip1','toolbar=0,scrollbars=0,width=850,height=700')"; ), nothing happens. By typing javascript: to Mozilla's address box I get no errors though.

In case it's necessary, here's one image's slice of the function with the linked image code it refers to:

function digitalpaintings () {
document.getElementById('kuva1').src="thumbnails/dip1.jpg";
document.getElementById('linkki1').onClick="javascript:window.open('digital-paintings/1.htm','dip1','toolbar=0,scrollbars=0,width=850,height=700')";
}
...
<a href="#" id="linkki1" onClick=""><img id="kuva1" src="layout/spacer.gif" width="100" height="100" style="position:absolute; left:0; top:5;" border="0"></a>

 

[BillyRayPreachersSon]

I can see why you would think that would work... but like a few other attributes (the "style" attribute for example), while they are set in HTML as strings, setting them in JS sometimes requires you to do things a bit differently.

If you change this:

document.getElementById('linkki1').onClick="javascript:window.open('digital-paintings/1.htm', 'dip1', 'toolbar=0,scrollbars=0,width=850,height=700')";

to this:

document.getElementById('linkki1').onclick = function() {
	window.open('digital-paintings/1.htm', 'dip1', 'toolbar=0,scrollbars=0,width=850,height=700');
}

You should be home and dry.

Hope this helps,
Dan

Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[SLaut]

Awesome, it works like a dream!

Thanks a lot!