Problem with ASP and Form in JavaScript 1

finnoscar · Aug 21, 2002

Could somebody help me sort this out. I need to add radio buttons to this script so that a user would have a choice of Small,medium or large and have the list of dogs meeting their choices returned as an ASP. I would be really grateful for as much help as possible

<%@ LANGUAGE = JavaScript%>
<HTML>
<BODY>
<TABLE BORDER=1>
<THEAD>
<TR>
<TH>Breed Name</TH>

<TH></TH>
</TR>
</THEAD>

<%
// Open connection to database, then populate a recordset with list of stock
var adoConnection = Server.CreateObject("ADODB.Connection&quot

;
var adoRecordSet;
var mySQL;
adoConnection.Open("DSN=DogDSN&quot

;
var mySQL = "SELECT BreedName" +
" FROM Breeds";
adoRecordSet = adoConnection.Execute(mySQL);

// Loop through recordset and write Breed Names out to page
while ( adoRecordSet.Eof == false )
{
%>
<TR>
<TD><%=adoRecordSet("BreedName&quot

.Value%></TD>

</TR>
<%
adoRecordSet.MoveNext();
}

// Close Recordset and connections
// and release memory used by Recordset and Connection objects
adoRecordSet.Close();
adoRecordSet = null;
adoConnection.Close();
adoConnection = null;
%>
</TABLE>
</BODY>
</HTML>

finnoscar · Aug 25, 2002

This is my code in it's entirety and when I run it the radio buttons just clear and nothing is returned

<%@ LANGUAGE = "JavaScript"%>
<html>
<body>
<table border="1">
<%var str_DogSize = new String(Request.Form("DogSize&quot

);
var str_DogGrooming = new String(Request.Form("DogGrooming&quot

);
var str_DogExercise = new String(Request.Form("DogExercise&quot

);
var str_DogSpace = new String(Request.Form("DogSpace&quot

);
var str_DogFeed =new String(Request.Form("DogFeed&quot

);
if (str_DogSize!="undefined" && str_DogGrooming!="undefined" && str_DogExercise!="undefined" &&
str_DogSpace!="undefined" && str_DogFeed!="undefined&quot

{

%> <tr>
<td align="left" style="font-weight:bold;">Breed Name</td>
</tr>
<% // Open connection to database, then populate a recordset with list of breeds
var adoConnection = Server.CreateObject("ADODB.Connection&quot

;
adoConnection.Open("DSN=DogDSN&quot

;
var mySQL = 'SELECT BreedName FROM Breeds ';
mySQL += 'WHERE Size="' + str_DogSize +'"';
mySQL +='and Grooming="' +str_DogGrooming +'"';
mySQL +='and ExerciseReq="' +str_DogExercise +'"';
mySQL +='and SpaceReq="' +str_DogSpace +'"';
mySQL +='and FeedingReq="' +str_DogFeed +'"';
var adoRecordSet = adoConnection.Execute(mySQL);
// Loop through recordset and write Breed Names out to page
while (!adoRecordSet.Eof){
%> <tr>
<td><%=adoRecordSet.Fields("BreedName&quot

.Value%></td>
</tr>
<% adoRecordSet.MoveNext();
}
// Close Recordset and connections
// and release memory used by Recordset and Connection objects
adoRecordSet.Close();
adoRecordSet = null;
adoConnection.Close();
adoConnection = null;
}else{
%> <tr>
<td valign="top" align="right">Breed Size: </td>
<td align=left>
<form method="post">
<input type="radio" name="DogSize" value="S">Small<br>
<input type="radio" name="DogSize" value="M">Medium<br>
<input type="radio" name="DogSize" value="L">Large<br>
<input type="radio" name="DogSize" value="XL">Giant<br>
<form>
</td>
</tr>
<tr>
<td valign="top" align="right">Grooming Required: </td>
<td align=left>
<form method="post">
<input type="radio" name="DogGrooming" value="Lt">Little<br>
<input type="radio" name="DogGrooming" value="Mod">Moderate<br>
<input type="radio" name="DogGrooming" value="Con">Considerable<br>
</form>
</td>
</tr>
<tr>
<td valign="top" align="right">Exercise Required: </td>
<td align=left>
<form method="post">
<input type="radio" name="DogExercise" value="Lt">Little<br>
<input type="radio" name="DogExercise" value="Mod">Moderate<br>
<input type="radio" name="DogExercise" value="Con">Considerable<br>

</form>
</td>
</tr>
<tr>
<td valign="top" align="right">Space Required: </td>
<td align=left>
<form method="post">
<input type="radio" name="DogSpace" value="Lt">Little<br>
<input type="radio" name="DogSpace" value="Mod">Moderate<br>
<input type="radio" name="DogSpace" value="Con">Considerable<br>
<form>
</td>
</tr>
<tr>
<td valign="top" align="right">Feeding Required: </td>
<td align=left>
<form method="post">
<input type="radio" name="DogFeed" value="Lt">Little<br>
<input type="radio" name="DogFeed" value="Mod">Moderate<br>
<input type="radio" name="DogFeed" value="Con">Considerable<br>
<input type="submit" value="Search">

<form>
</td>
</tr>

<%}
%>
</table>
</body>
</html>

finnoscar · Aug 25, 2002

What could the problem be?

codestorm · Aug 25, 2002

ahhh .. put the <form> tag just after the <body> tag and the </form> tag just before the </body> tag - you only need one form.

Given you have a separate form for each radio group, but only a submit button on the last form, it is only ever submitting the DogFeed category. Putting form tags around the whole lot of the input tags means they'll all be submitted.

You have a dog yourself? codestorm
Fire bad. Tree pretty. - Buffy
select * from population where talent > 'average'
You're not a complete programmer unless you know how to guess.
I hope I never consider myself an 'expert'.
<insert witticism here>

finnoscar · Aug 26, 2002

Now when I run it I get the message too few parameters.4 expected line 29 which is this line

var adoRecordSet = adoConnection.Execute(mySQL);

Yes,I have two Irish Wolfhounds.

finnoscar · Aug 26, 2002

If this were to run what way would it would it print the list of dogs out. I mean where on the page would they be printed out above the form,below it or beside it?

codestorm · Aug 26, 2002

var mySQL = 'SELECT BreedName FROM Breeds ';
mySQL += 'WHERE Size="' + str_DogSize +'" ';
mySQL +='and Grooming="' +str_DogGrooming +'" ';
mySQL +='and ExerciseReq="' +str_DogExercise +'" ';
mySQL +='and SpaceReq="' +str_DogSpace +'" ';
mySQL +='and FeedingReq="' +str_DogFeed +'" ';

needed to add some spaces in (as above).

the list will appear instead of the form. codestorm
Fire bad. Tree pretty. - Buffy
select * from population where talent > 'average'
You're not a complete programmer unless you know how to guess.
I hope I never consider myself an 'expert'.
<insert witticism here>

finnoscar · Aug 26, 2002

I have it exactly as you've shown but I still get an error message saying:

Error Type:
Microsoft OLE DB Provider for ODBC Drivers (0x80040E10)
[Microsoft][ODBC Microsoft Access Driver] Too few parameters. Expected 3.
/PickADog.asp, line 29

What's wrong?

finnoscar · Aug 26, 2002

How would I add a link to this page to take me back to the homepage or to other pages?

codestorm · Aug 26, 2002

to debug, post the results of doing below:
//var adoRecordSet = adoConnection.Execute(mySQL);
Response.write(mySQL);
Response.End;

is this the homepage? if not:

adoConnection = null;
%> <tr>
<td>
<a href="homepage.asp">
Back to homepage
</a>
</td>
</tr>
<%}else{
%> <tr> codestorm
Fire bad. Tree pretty. - Buffy
select * from population where talent > 'average'
You're not a complete programmer unless you know how to guess.
I hope I never consider myself an 'expert'.
<insert witticism here>

finnoscar · Aug 27, 2002

This is the way I inserted your code

<%@ LANGUAGE = "JavaScript"%>
<html>

<head>
<meta name="Microsoft Theme" content="indust 110, default">
</head>

<body><table border="1">
<%var str_DogSize = new String(Request.Form("DogSize&quot

);
var str_DogGrooming = new String(Request.Form("DogGrooming&quot

);
var str_DogExercise = new String(Request.Form("DogExercise&quot

);
var str_DogSpace = new String(Request.Form("DogSpace&quot

);
var str_DogFeed =new String(Request.Form("DogFeed&quot

);
if (str_DogSize!="undefined" && str_DogGrooming!="undefined" && str_DogExercise!="undefined" &&
str_DogSpace!="undefined" && str_DogFeed!="undefined&quot

{

%> <tr>
<td align="left" style="font-weight:bold;">Breed Name</td>
</tr>
<% // Open connection to database, then populate a recordset with list of breeds
var adoConnection = Server.CreateObject("ADODB.Connection&quot

;
adoConnection.Open("DSN=DogDSN&quot

;
var mySQL = 'SELECT BreedName FROM Breeds ';
mySQL += 'WHERE Size="' + str_DogSize +'" ';
mySQL += 'and Grooming="' +str_DogGrooming +'" ';
mySQL += 'and ExerciseReq="' +str_DogExercise +'" ';
mySQL += 'and SpaceReq="' +str_DogSpace +'" ';
mySQL += 'and FeedingReq="' +str_DogFeed +'" ';
var adoRecordSet = adoConnection.Execute(mySQL);
// Loop through recordset and write Breed Names out to page
while (!adoRecordSet.Eof){
%> <tr>
<td><%=adoRecordSet.Fields("BreedName&quot

.Value%></td>
</tr>
<% adoRecordSet.MoveNext();
}
// Close Recordset and connections
// and release memory used by Recordset and Connection objects
adoRecordSet.Close();
adoRecordSet = null;
adoConnection.Close();
adoConnection = null;
}else{
%> <tr>
<td valign="top" align="right">Breed Size:</td>
<td align=left>
<form method="post">
<input type="radio" name="DogSize" value="S">Small<br>
<input type="radio" name="DogSize" value="M">Medium<br>
<input type="radio" name="DogSize" value="L">Large<br>
<input type="radio" name="DogSize" value="XL">Giant<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Grooming Required:</td>
<td align=left>

<input type="radio" name="DogGrooming" value="Lt">Little<br>
<input type="radio" name="DogGrooming" value="Mod">Moderate<br>
<input type="radio" name="DogGrooming" value="Con">Considerable<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Exercise Required:</td>
<td align=left>

<input type="radio" name="DogExercise" value="Lt">Little<br>
<input type="radio" name="DogExercise" value="Mod">Moderate<br>
<input type="radio" name="DogExercise" value="Con">Considerable<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Space Required:</td>
<td align=left>

<input type="radio" name="DogSpace" value="Lt">Little<br>
<input type="radio" name="DogSpace" value="Mod">Moderate<br>
<input type="radio" name="DogSpace" value="Con">Considerable<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Feeding Required:</td>
<td align=left>

<input type="radio" name="DogFeed" value="Lt">Little<br>
<input type="radio" name="DogFeed" value="Mod">Moderate<br>
<input type="radio" name="DogFeed" value="Con">Considerable<br>
<input type="submit" value="Search">

<form>
</td>
</tr>

<%}
%>
<% //var adoRecordSet = adoConnection.Execute(mySQL);
Response.write(mySQL);
Response.End;

is this the homepage? if not:

adoConnection = null;
%> <tr>
<td>
<a href="homepage.asp">
Back to homepage
</a>
</td>
</tr>
<%}else{
%>
</table></body>
</html>

and this is the message it returns

Error Type:
Microsoft JScript compilation (0x800A03EC)
Expected ';'
/PickADog.asp, line 105, column 3
is this the homepage? if not:
--^
I don't know if I have inserted the code correctly or not

codestorm · Aug 27, 2002

ANSWER 1:
//var adoRecordSet = adoConnection.Execute(mySQL); <-- this is a line of your code i commented out to show ou how to debug
Response.write(mySQL); // <-- this is a line i added to output the query to the screen
Response.End; // <-- this is a line i added to stop page execution after outputting the query

the above lines of code are meant to be inserted after the (now commented out) line in your code listed above.

codestorm
Fire bad. Tree pretty. - Buffy
select * from population where talent > 'average'
You're not a complete programmer unless you know how to guess.
I hope I never consider myself an 'expert'.
<insert witticism here>

codestorm · Aug 27, 2002

ANSWER 2 - if the 'homepage' you refer to is not the current page (the page listing the breeds), you can add the code below (NOTE as in post above, code is meant to be inserted into your code between the lines of your code you recognise below)

adoConnection = null;
%> <tr>
<td>
<a href="homepage.asp">
Back to homepage
</a>
</td>
</tr>
<%}else{
%> <tr> codestorm
Fire bad. Tree pretty. - Buffy
select * from population where talent > 'average'
You're not a complete programmer unless you know how to guess.
I hope I never consider myself an 'expert'.
<insert witticism here>

finnoscar · Aug 27, 2002

How would I insert a key on the right hand side of the page to let users know what each of the categories they are picking means?

finnoscar · Aug 27, 2002

Breed Name SELECT BreedName FROM Breeds WHERE Size="L" and Grooming="Mod" and ExerciseReq="Mod" and SpaceReq="Mod" and FeedingReq="Mod"

This is what is returned when I pick these radio buttons and submit it

codestorm · Aug 27, 2002

and now if you comment out the
Response.write(mySQL);
and
Response.End;
lines and uncomment the
//var adoRecordSet = adoConnection.Execute(mySQL);
line, what happens?

if it still gives a Too Few Parameters error, it's likely wrongly named table fields, or trying to use wrong data types as criteria.
codestorm
Fire bad. Tree pretty. - Buffy
select * from population where talent > 'average'
You're not a complete programmer unless you know how to guess.
I hope I never consider myself an 'expert'.
<insert witticism here>

codestorm · Aug 27, 2002

<%@ LANGUAGE = "JavaScript"%>
<html>

<head>
<meta name="Microsoft Theme" content="indust 110, default">
</head>

<body><table border="1">
<%var str_DogSize = new String(Request.Form("DogSize&quot

);
var str_DogGrooming = new String(Request.Form("DogGrooming&quot

);
var str_DogExercise = new String(Request.Form("DogExercise&quot

);
var str_DogSpace = new String(Request.Form("DogSpace&quot

);
var str_DogFeed =new String(Request.Form("DogFeed&quot

);
if (str_DogSize!="undefined" && str_DogGrooming!="undefined" && str_DogExercise!="undefined" &&
str_DogSpace!="undefined" && str_DogFeed!="undefined&quot

{

%> <tr>
<td align="left" style="font-weight:bold;">Breed Name</td>
</tr>
<% // Open connection to database, then populate a recordset with list of breeds
var adoConnection = Server.CreateObject("ADODB.Connection&quot

;
adoConnection.Open("DSN=DogDSN&quot

;
var mySQL = 'SELECT BreedName FROM Breeds ';
mySQL += 'WHERE Size="' + str_DogSize +'" ';
mySQL += 'and Grooming="' +str_DogGrooming +'" ';
mySQL += 'and ExerciseReq="' +str_DogExercise +'" ';
mySQL += 'and SpaceReq="' +str_DogSpace +'" ';
mySQL += 'and FeedingReq="' +str_DogFeed +'" ';
var adoRecordSet = adoConnection.Execute(mySQL);
// Loop through recordset and write Breed Names out to page
while (!adoRecordSet.Eof){
%> <tr>
<td><%=adoRecordSet.Fields("BreedName&quot

.Value%></td>
</tr>
<% adoRecordSet.MoveNext();
}
// Close Recordset and connections
// and release memory used by Recordset and Connection objects
adoRecordSet.Close();
adoRecordSet = null;
adoConnection.Close();
adoConnection = null;
}else{
%> <tr>
<td valign="top" align="right">Breed Size refers to ...</td>
<td valign="top" align="right">Breed Size:</td>
<td align=left>
<form method="post">
<input type="radio" name="DogSize" value="S">Small<br>
<input type="radio" name="DogSize" value="M">Medium<br>
<input type="radio" name="DogSize" value="L">Large<br>
<input type="radio" name="DogSize" value="XL">Giant<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Grooming Required refers to ...</td> <td valign="top" align="right">Grooming Required:</td>
<td align=left>

<input type="radio" name="DogGrooming" value="Lt">Little<br>
<input type="radio" name="DogGrooming" value="Mod">Moderate<br>
<input type="radio" name="DogGrooming" value="Con">Considerable<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Exercise Required refers to ...</td> <td valign="top" align="right">Exercise Required:</td>
<td align=left>

<input type="radio" name="DogExercise" value="Lt">Little<br>
<input type="radio" name="DogExercise" value="Mod">Moderate<br>
<input type="radio" name="DogExercise" value="Con">Considerable<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Space Required refers to ...</td> <td valign="top" align="right">Space Required:</td>
<td align=left>

<input type="radio" name="DogSpace" value="Lt">Little<br>
<input type="radio" name="DogSpace" value="Mod">Moderate<br>
<input type="radio" name="DogSpace" value="Con">Considerable<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Feeding Required refers to ...</td> <td valign="top" align="right">Feeding Required:</td>
<td align=left>

<input type="radio" name="DogFeed" value="Lt">Little<br>
<input type="radio" name="DogFeed" value="Mod">Moderate<br>
<input type="radio" name="DogFeed" value="Con">Considerable<br>
<input type="submit" value="Search">

<form>
</td>
</tr>

<%}
%> <tr>
<td colspan="2">
<a href="homepage.asp">
Back to homepage
</a>
</td>
</tr>
<%}else{
%>
</table></body>
</html>

I've got Aussie Shepherds

codestorm
Fire bad. Tree pretty. - Buffy
select * from population where talent > 'average'
You're not a complete programmer unless you know how to guess.
I hope I never consider myself an 'expert'.
<insert witticism here>

finnoscar · Aug 27, 2002

Thanks a million codestorm you've been a life saver.

finnoscar · Aug 28, 2002

One of the table fields was incorrectly named and when I corrected it the error message changed to:

Error Type:
Microsoft OLE DB Provider for ODBC Drivers (0x80040E10)
[Microsoft][ODBC Microsoft Access Driver] Too few parameters. Expected 2.
/PickADog.asp, line 29

They are all text fields apart from the BreedName which is a hyperlink

finnoscar · Aug 28, 2002

One of the table fields was incorrectly named and when I corrected it the error message changed to:

Error Type:
Microsoft OLE DB Provider for ODBC Drivers (0x80040E10)
[Microsoft][ODBC Microsoft Access Driver] Too few parameters. Expected 2.
/PickADog.asp, line 29

They are all text fields apart from the BreedName which is a hyperlink

Michael27 · Aug 28, 2002

This is the code exactly as I have it now

<html>

<head>
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252">
<meta name="GENERATOR" content="Microsoft FrontPage 4.0">
<meta name="ProgId" content="FrontPage.Editor.Document">
<meta name="Microsoft Theme" content="indust 110, default">
</head>

<body><%@ LANGUAGE = "JavaScript"%>
<table border="1">
<%var str_DogSize = new String(Request.Form("DogSize&quot

);
var str_DogGrooming = new String(Request.Form("DogGrooming&quot

);
var str_DogExercise = new String(Request.Form("DogExercise&quot

);
var str_DogSpace = new String(Request.Form("DogSpace&quot

);
var str_DogFeed =new String(Request.Form("DogFeed&quot

);
if (str_DogSize!="undefined" && str_DogGrooming!="undefined" && str_DogExercise!="undefined" &&
str_DogSpace!="undefined" && str_DogFeed!="undefined&quot

{

%> <tr>
<td align="left" style="font-weight:bold;">Breed Name</td>
</tr>
<% // Open connection to database, then populate a recordset with list of breeds
var adoConnection = Server.CreateObject("ADODB.Connection&quot

;
adoConnection.Open("DSN=DogDSN&quot

;
var mySQL = 'SELECT BreedName FROM Breeds ';
mySQL += 'WHERE Size="' + str_DogSize +'" ';
mySQL += 'and Grooming="' +str_DogGrooming +'" ';
mySQL += 'and Exercise="' +str_DogExercise +'" ';
mySQL += 'and SpaceReq="' +str_DogSpace +'" ';
mySQL += 'and FeedingReq="' +str_DogFeed +'" ';
var adoRecordSet = adoConnection.Execute(mySQL);
// Loop through recordset and write Breed Names out to page
while (!adoRecordSet.Eof){
%> <tr>
<td><%=adoRecordSet.Fields("BreedName&quot

.Value%></td>
</tr>
<% adoRecordSet.MoveNext();
}
// Close Recordset and connections
// and release memory used by Recordset and Connection objects
adoRecordSet.Close();
adoRecordSet = null;
adoConnection.Close();
adoConnection = null;
}else{
%> <tr>
<td valign="top" align="right">Breed Size refers to ...</td>
<td valign="top" align="right">Breed Size:</td>
<td align=left>
<form method="post">
<input type="radio" name="DogSize" value="S">Small<br>
<input type="radio" name="DogSize" value="M">Medium<br>
<input type="radio" name="DogSize" value="L">Large<br>
<input type="radio" name="DogSize" value="XL">Giant<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Grooming Required refers to ...</td> <td valign="top" align="right">Grooming Required:</td>
<td align=left>

<input type="radio" name="DogGrooming" value="Lt">Little<br>
<input type="radio" name="DogGrooming" value="Mod">Moderate<br>
<input type="radio" name="DogGrooming" value="Con">Considerable<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Exercise Required refers to ...</td> <td valign="top" align="right">Exercise Required:</td>
<td align=left>

<input type="radio" name="DogExercise" value="Lt">Little<br>
<input type="radio" name="DogExercise" value="Mod">Moderate<br>
<input type="radio" name="DogExercise" value="Con">Considerable<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Space Required refers to ...</td> <td valign="top" align="right">Space Required:</td>
<td align=left>

<input type="radio" name="DogSpace" value="Lt">Little<br>
<input type="radio" name="DogSpace" value="Mod">Moderate<br>
<input type="radio" name="DogSpace" value="Con">Considerable<br>

</td>
</tr>
<tr>
<td valign="top" align="right">Feeding Required refers to ...</td> <td valign="top" align="right">Feeding Required:</td>
<td align=left>

<input type="radio" name="DogFeed" value="Lt">Little<br>
<input type="radio" name="DogFeed" value="Mod">Moderate<br>
<input type="radio" name="DogFeed" value="Con">Considerable<br>
<input type="submit" value="Search">

<form>
</td>
</tr>

<%}
%> <tr>
<td colspan="2">
<a href="homepage.asp">
Back to homepage
</a>
</td>
</tr>
<%
%>
</table></body>
</html>

I am still receiving the same error message and all the field names are correct and the data types are all text

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Problem with ASP and Form in JavaScript 1

Technical User

Technical User

Technical User

Programmer

Technical User

Technical User

Programmer

Technical User

Technical User

Programmer

Technical User

Programmer

Programmer

Technical User

Technical User

Programmer

Programmer

Technical User

Technical User

Technical User

Technical User

Similar threads

Log in

Part and Inventory Search

Sponsor