Problem with AND OR

[PSFMIS]

I'm trying to only allow number keys, period, decimal point, and dash.

Why does this generate an error? Something is wrong with my if statment syntax.

<SCRIPT language=Javascript>
      <!--
      function isNumberKey(evt)
      {
         var charCode = (evt.which) ? evt.which : event.keyCode
         
		 if ((charCode >= 48 && charCode <= 57) || charCode = 189 || charCode = 190 || charCode = 110)
			 return true;
		 return false;

      }
      //-->
   </SCRIPT>

Thanks,
Aaron

 

[theniteowl]

You are using = which is an assignment operator rather than using == which is a comparator. Try this:

<SCRIPT language=Javascript>
      <!--
      function isNumberKey(evt)
      {
         var charCode = (evt.which) ? evt.which : event.keyCode
         
         if ((charCode >= 48 && charCode <= 57) || charCode =[COLOR=red]=[/color] 189 || charCode =[COLOR=red]=[/color] 190 || charCode =[COLOR=red]=[/color] 110)
             return true;
         return false;

      }
      //-->
   </SCRIPT>

Stamp out, eliminate and abolish redundancy!

 

[PSFMIS]

I don't get the syntax error anymore however it does not let me enter the dash, period, or decimal point either...

Aaron

 

[theniteowl]

BTW, I noticed your charCodes seem to be off.
48-57 are numbers 0-9 but 110 is a lower case n and 189 and 190 are 1/2 and 3/4 fractional symbols.

You said you want to check for period and decimal point but those are the same symbol.

Your best bet is to use a regular expression. This one should do what you need.

function isNumberKey(evt)
{
  var charCode = (evt.which) ? evt.which : event.keyCode       
  var re = /^[\d.\-]+$/;
  return re.test(value);
}

Stamp out, eliminate and abolish redundancy!

 

[PSFMIS]

I got it working like this.... Now I need to figure out how to only allow a dash if its the first character and only allow one decimal point to be entered.

      function isNumberKey(evt)
      {
         var charCode = (evt.which) ? evt.which : event.keyCode
         
		 if ((charCode >= 48 && charCode <= 57) || charCode == 45 || charCode == 46)
			 return true;
		 return false;

      }

 

[theniteowl]

Actually, what I think you want to do is a test for signed integers.
Google regular expression signed integer and see what you come up with. I was looking at some functions for exactly that late last week but have not done anything with them yet.

I am only just beginning to learn regular expressions but they are very flexible and can do everything you want to do in a single line without having to have a whole bunch of if statements.


Stamp out, eliminate and abolish redundancy!