Prob. with returning an Array & GetOpenFilename 2

[Gallowgate]

hi All

Firstly, I'm a beginner with VB. Got the following out of a book and works when I select some files, however, when I choose Cancel in the Openfile Dlg, it returns msg 'Error 13: Type mismatch' on the FOR loop. How can I check if the array is empty(ie no files selected or cancel was pressed). In the debugger, fname equals 'false' when cancel is pressed, why is it false?

Const iTitle = "Pick file"
Const Filterlist = _
 "Word(*.doc), *.doc, Excel(*.xls), *.xls"
Dim i As Integer

With Application
    Fname = .GetOpenFilename(Title:=iTitle, _
    filefilter:=Filterlist, _
    FilterIndex:=2, _
    MultiSelect:=True)
End With
 
For i = LBound(Fname) To UBound(Fname)
   tbfilename.Text = tbfilename.Text & Fname(i) & "; "
Next i

thanks for any help
Martin

 

[SkipVought]

Hi,

You need to test Fname

If Fname <> False Then
'your loop
End If

Skip,
Skip@TheOfficeExperts.com

http://www.TheOfficeExperts.com

 

[Gallowgate]

Thanks for the reply,

I tried that this morning and when I put the if statement to catch the cancel error, it then fails on the OK button when I have selected files. Error is Type Mismatch.


Thanks again.

Martin

 

[SkipVought]

Fname as to be a variant.

Skip,
Skip@TheOfficeExperts.com

http://www.TheOfficeExperts.com

 

[Gallowgate]

hi Skip
Tried to declare it as a variant (remember I'm a beginner here, so please be patient with me).

This is the code as it stands and I get a Type mismatch on the IF statement. Could you give me the corrected version, please, as I'm confused with it?

Dim Fname As Variant
Dim i As Integer


With Application
    Fname = .GetOpenFilename(Title:=iTitle, _
    filefilter:=Filterlist, _
    FilterIndex:=2, _
    MultiSelect:=True)
End With
 
If Fname <> False Then
 For i = LBound(Fname) To UBound(Fname)
   tbfilename.Text = tbfilename.Text & Fname(i) & &quot;; &quot;
Next i
End If

 

[SkipVought]

whats in iTitle & Filterlist?

Skip,
Skip@TheOfficeExperts.com

http://www.TheOfficeExperts.com

 

[Gallowgate]

Herewith whole thing...

 Const iTitle = "Pick file"
Const Filterlist = _
 "Word(*.doc), *.doc, Excel(*.xls), *.xls"
Dim Fname As Variant
Dim i As Integer


With Application
    Fname = .GetOpenFilename(Title:=iTitle, _
    filefilter:=Filterlist, _
    FilterIndex:=2, _
    MultiSelect:=True)
End With

 Rem Label1.Caption = Fname

 Rem if (fname is ) = false then
 
If Fname <> False Then
 For i = LBound(Fname) To UBound(Fname)
   tbfilename.Text = tbfilename.Text & Fname(i) & &quot;; &quot;
Next i
End If

End Sub

 

[SkipVought]

Try this

If Not IsError(Fname) Then

Skip,
Skip@TheOfficeExperts.com

http://www.TheOfficeExperts.com

 

[Gallowgate]

Skip,

Thanks a lot - that works great !

Martin

 

[LucieLastic]

hi

(Firstly, to avoid any confusion, I've been working with Gallowgate on this one.)

The IsError started to give us problems(not sure why) and wasn't trapping the pressing of Cancel.

We have since discovered that because Fname is a variant, Excel will return the result "False" converted to a string if Cancel is pressed - why it can't convert it to Boolean(False), I don't know . The following now works better [phew]:-

if Fname = "False" then ...

lou