Poor Performance

[mikew194]

Any ideas as to why this code runs so slow?

Thanks
Mike

if (this.textBox1.Text.Length <= 5) return;

xmlDoc = InitXMLDocument();

object oNull = Type.Missing;

Excel.Application xl = new Excel.Application();
Excel._Workbook wb = (Excel._Workbook)xl.Workbooks.Open(this.textBox1.Text,oNull,true,oNull ,oNull ,false ,oNull ,oNull ,oNull ,false,false,oNull ,false );
Excel._Worksheet ws = (Excel._Worksheet)wb.Worksheets.get_Item(SHEET);

int nRows = ws.UsedRange.Count;
int r=4;
string vBCellID = "";
string vFCellID = "";
object m_MissingValue = Type.Missing;

try
{
do
{
vBCellID = "B" + r.ToString();
vFCellID = "F" + r.ToString();

Excel.Range range = ws.get_Range(vBCellID, vFCellID);
System.Array myvalues = (System.Array)range.Cells.Value;
string[] strArray = ConvertToStringArray(myvalues);

AddNode(ref xmlDoc, strArray[0], strArray[1], strArray[2], strArray[3], strArray[0]);

r++;
txtMsgBox.Text = "row processed " + r.ToString();
}
while (r < nRows);
}
catch (SystemException se)
{
string s = se.Message.ToString();
txtMsgBox.Text = s;
}
finally
{
wb.Close(false, oNull, oNull);
wb = null;

xl.Quit();
xl = null;

this.btnGenXML.Enabled = true;
}

 

[chiph]

If you have the Team Developer Edition of Visual Studio, it comes with a profiler, which can help you find statements which are consuming a lot of time.

Sometimes, it's surprising what it'll find.

Chip H.


____________________________________________________________________
If you want to get the best response to a question, please read FAQ222-2244 first

 

[stevexff]

Failing that, you can always throw a few Console.WriteLine()s in there at strategic points. If it's that slow, you should be able to see it...

Steve

[small]"Every program can be reduced by one instruction, and every program has at least one bug. Therefore, any program can be reduced to one instruction which doesn't work." (Object:erlDesignPatterns)[/small]