please give me tips on simplifing this code (its my first php script)

Guest_imported · Oct 11, 2001

(
case 3:
print "<script language=\"JavaScript1.2\" src=\"st3.js\"></script>";
print "<form method=\"post\" action=\"form.php?st=4\">";
print "<input type=\"hidden\" name=\"Hplan\" value=\"$Hplan\">";
print "<input type=\"hidden\" name=\"Dplan\" value=\"$Dplan\">";
if(isset($siteDescript)){
print "<input type=\"hidden\" name=\"haveURL\" value=\"$haveURL\">";
print "<input type=\"hidden\" name=\"similarSite\" value=\"$similarSite\">";
print "<input type=\"hidden\" name=\"siteDescript\" value=\"$siteDescript\">";
}
print "<input type=\"hidden\" name=\"name\" value=\"$fullName\">";
print "<input type=\"hidden\" name=\"compName\" value=\"$compName\">";
print "<input type=\"hidden\" name=\"add1\" value=\"$add1\">";
print "<input type=\"hidden\" name=\"add2\" value=\"$add2\">";
print "<input type=\"hidden\" name=\"city\" value=\"$city\">";
print "<input type=\"hidden\" name=\"state\" value=\"$state\">";
print "<input type=\"hidden\" name=\"zip\" value=\"$zip\">";
print "<input type=\"hidden\" name=\"email\" value=\"$email\">";
print "<input type=\"hidden\" name=\"dayPhone\" value=\"$dayPhone\">";
print "<input type=\"hidden\" name=\"evePhone\" value=\"$evePhone\">";
print "<input type=\"hidden\" name=\"fax\" value=\"$fax\">";
$body="<h1>Customer Info</h1>\n\n";
$body="Name:\t$fullName<br><br>";
$body+="Company:\t$compName<br><br>";
$body+="Address(line 1):\t$add1<br><br>";
$body+="Address(line 2):\t$add2<br><br>";
$body+="City:\t$city<br><br>";
$body+="State:\t$state<br><br>";
$body+="Zip:\t$zip<br><br>";
$body+="E-mail:\t$email<br><br>";
$body+="Day Phone:\t$dayPhone<br><br>";
$body+="Evening Phone:\t$evePhone<br><br>";
$body+="Fax:\t$fax<br><br>";
$body+="<h1>Billing Info</h1>\n\n";
$body+="Payment Type:\t$payment<br><br>";
if($payment != "checkMO&quot

{
$body += "Name On Card:\t$nameOnCard<br><br>";
$body += "Card Number:\t";
$body += "Exp Month and Year:\t$expMonth\\$expYear<br><br>";
}
if(!creditCardSame){
$body+="Billing Address(Line1):\t$BILLadd1<br><br>";
$body+="Billing Address(Line1):\t$BILLadd1<br><br>";
$body+="Billing City:\t$BILLcity<br><br>";
$body+="Billing State:\t$BILLstate<br><br>";
$body+="State:\t$state<br><br>";
}
else{
$body+="<b>USE CUSTOMER INFO FOR BILLING INFO</b><br><br>";
}
$body+="<h1>HOSTING PLAN</h1>";
$body+="Plan:\t$Hplan<br><br>";
if(isset($siteDescript)){
$body+="<h1>DESIGN PLAN</h1>";
$body+="Plan:\t$Dplan<br><br>";
$body+="Existing URL:\t$haveURL<br><br>";
$body+="Similar URL:\t$similarSite<br><br>";
$body+="Site Description:\t$siteDescript<br><br>";
}
print "$body";
print "<table border=\"0\" bgcolor=\"yellow\">";
print " <tr>";
print " <td width=\"150\">Payment Type*</td>";
print " <td width=\"250\"><select size=\"1\" name=\"payment\">";
print " <option value=\"visa\">Visa</option>";
print " <option value=\"master\">Master Card</option>";
print " <option value=\"amEx\">American Express</option>";
print " <option value=\"discover\">Discover</option>";
print " <option value=\"checkMO\">Check/Money Order</option>";
print " </select>";
print " </td>";
print " </tr>";
print " <tr>";
print " <td width=\"150\">Expiration Date</td>";
print " <td width=\"250\"><select name=\"expMonth\" size=\"1\">";
print " <option VALUE=\"01\" SELECTED > Jan </option>";
print " <option VALUE=\"02\" > Feb </option>";
print " <option VALUE=\"03\" > Mar </option>";
print " <option VALUE=\"04\" > Apr </option>";
print " <option VALUE=\"05\" > May </option>";
print " <option VALUE=\"06\" > Jun </option>";
print " <option VALUE=\"07\" > Jul </option>";
print " <option VALUE=\"08\" > Aug </option>";
print " <option VALUE=\"09\" > Sep </option>";
print " <option VALUE=\"10\" > Oct </option>";
print " <option VALUE=\"11\" > Nov </option>";
print " <option VALUE=\"12\" > Dec </option>";
print " </select>";
print " <select name=\"expYear\" size=\"1\">";
print " <option VALUE=\"01\" SELECTED> 2001 </option>";
print " <option VALUE=\"02\" > 2002 </option>";
print " <option VALUE=\"03\" > 2003 </option>";
print " <option VALUE=\"04\" > 2004 </option>";
print " <option VALUE=\"05\" > 2005 </option>";
print " <option VALUE=\"06\" > 2006 </option>";
print " <option VALUE=\"07\" > 2007 </option>";
print " <option VALUE=\"08\" > 2008 </option>";
print " </select></td>";
print " </tr>";
print " <tr>";
print " <td width=\"150\">Name On Card</td>";
print " <td width=\"250\"><input type=\"text\" size=\"30\" maxlength=\"50\" name=\"nameOnCard\"></td>";
print " </tr>";
print " <tr>";
print " <td colspan=\"2\">Is your contact address the same as your billing address?<input NAME=\"creditCardSame\" TYPE=\"checkbox\" checked></td>";
print " </tr>";
print " <tr>";
print " <td width=\"150\">Address- Line1* </td>";
print " <td width=\"250\"><input type=\"text\" size=\"30\" maxlength=\"50\" name=\"BILLadd1\"></td>";
print " </tr>";
print " <tr>";
print " <td width=\"150\">Address- Line 2</td>";
print " <td width=\"250\"><input type=\"text\" size=\"30\" maxlength=\"50\" name=\"BILLadd2\"></td>";
print " </tr>";
print " <tr>";
print " <td width=\"150\">City*</td>";
print " <td width=\"250\"><input type=\"text\" size=\"15\" maxlength=\"30\" name=\"BILLcity\"></td>";
print " </tr>";
print " <tr>";
print " <td width=\"150\">State*</td>";
print " <td width=\"250\"><input type=\"text\" size=\"10\" maxlength=\"25\" name=\"BILLstate\"></td>";
print " </tr>";
print " <tr>";
print " <td width=\"150\">Zip Code*</td>";
print " <td width=\"250\"><input type=\"text\" size=\"5\" maxlength=\"10\" name=\"BILLzip\"></td>";
print " </tr>";
print " <tr><td valign=\"top\" colspan=\"2\" width=\"400\"><b>AGREEMENT TO TERMS</b><br>";
print " By typing your name in the  "On-line Signature" below, and pressing the";
print " "Purchase Now" button below, you hereby agree to the <a href=\"terms.htm\" target=\"_blank\">Terms and";
print " Conditions</a> and hereby authorize all expenses associated with this account.";
print " Additionally, any monthly, quarterly or annual charges are authorized to be billed, when";
print " due, to this account.";
print " </td></tr>";
print " <tr>";
print " <td width=\"150\">Online Signature*</td>";
print " <td width=\"250\"><input type=\"text\" size=\"30\" maxlength=\"50\" name=\"Signature\"></td>";
print " </tr>";
print "If the above info is correct proceed by pressing process<br>";
print "<input type=\"submit\" value=\"process\" size=\"20\" onClick>";
break;

Glowball · Oct 11, 2001

Wow... did you know that the whole page doesn't have to be in PHP? That's the beauty of scripting languages, you can script what you need and use it in conjunction with regular HTML code. For example, you can do

<?php case 3: ?>
<script language="JavaScript1.2" src="st3.js"></script>
<form method="post" action="form.php?st=4">
<input type="hidden" name="Hplan" value="<?php echo $Hplan; ?>">
...
Exp Month and Year: <?php echo $expMonth . "\" . $expYear; ?><br><br>
<?php if (!creditCardSame) { ?>
Billing Address(Line1): <?php echo $BILLadd1; ?><br><br>
...
<?php } else { ?>
...
<?php break; ?>

Etc. Also when you concatenate strings you need to use .= not += (which works to add numbers together).

Hope that helps!

imagetag · Oct 14, 2001

You should always be aware of the point, that you can use as many php scripts in you document as you like. Will say, that you use a louse html form and add some code where it is needed. If you want to change the values of a form after the data is entered you may should do that in a second document after the form validation. Any input field will have a corressponding variable in the target document of your form.
If you must generate a form like this, you could also look for html statements that repeat very often and put them in a variable. This would shorten your code alot, but the example above is more or less a usual html doc and should be treaten like that.

</imagetag>

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

please give me tips on simplifing this code (its my first php script)

Guest_imported

New member

Glowball

Programmer

imagetag

Programmer

Similar threads

Part and Inventory Search

Sponsor