Perl Module not getting called

[Nutthick]

I'm trying to place a subroutine in a perl module and although I have the syntax correct (nothing in the error log) the routine doesn't seem to be getting called.

The key items from the main script are as follows;

use filelog;
update_log2("Filename", "Name");

obviously the call is within the code lower down. The routine is getting called, as there is another local one after it that is running correctly.

My module code is in the same directory as my script and is called filelog.pm. It's contents are as follows;

sub update_log {
	$filename = $_[0];
	$track = $_[1];

	# Read the log and determine the next ID value
	$filelog = "/var/[URL unfurl="true"]www/cgi-bin/files.log";[/URL]
	$fileCount = "";
	$temp = "";
	$line2 = "";
	$line3 = "";

	open (FILES, $filelog) || die "Could not open file";
	while ($temp = <FILES>) {
		$fileCount = $temp;
		$line2 = <FILES>;
		$line3 = <FILES>;
	}
	close(FILES);

	$fileCount++;

	# Append the file
	open (FILES, ">>" . $filelog) || die "Could not open file for append";
	print FILES "$fileCount\n";
	print FILES "$filename\n";
	print FILES "$track\n";
	close(FILES);

	return;
}
1;

Is there any reason why this wouldn't be getting called?

Thanks

 

[Kirsle]

Your module needs to export the function. Else you'll have to call it as a function of the module,

filelog::update_log("filename", "name")

Also, in your example you called update_log2 when the function was named update_log, don't know if you intended to do that or not though.

 

[mbrooks]

You need to export the function. Use the Exporter module.

package [i]filelog[/i];

use vars qw( @ISA %EXPORT_TAGS @EXPORT_OK );

require Exporter;

@ISA = qw( Exporter );

%EXPORT_TAGS = (
    'all' => [
        qw(
          update_log
          )
    ]
);

@EXPORT_OK = ( @{ $EXPORT_TAGS{'all'} } );
[i]
sub update_log {
    $filename = $_[0];
    $track = $_[1];

    # Read the log and determine the next ID value
    $filelog = "/var/[URL unfurl="true"]www/cgi-bin/files.log";[/URL]
    $fileCount = "";
    $temp = "";
    $line2 = "";
    $line3 = "";

    open (FILES, $filelog) || die "Could not open file";
    while ($temp = <FILES>) {
        $fileCount = $temp;
        $line2 = <FILES>;
        $line3 = <FILES>;
    }
    close(FILES);

    $fileCount++;

    # Append the file
    open (FILES, ">>" . $filelog) || die "Could not open file for append";
    print FILES "$fileCount\n";
    print FILES "$filename\n";
    print FILES "$track\n";
    close(FILES);

    return;
}
[/i]
1; # always return true

M. Brooks

http://mbrooks.info

 

[Nutthick]

Well it's working, sort of. I put in the exporter code that mbrooks suggested, but I'm having to call the routine as

filelog::update_log("Filename","Name");

Does that mean my export code isn't working, or have I screwed up elsewhere?

 

[mbrooks]

You call it from within your script like this

#!/usr/bin/perl -w

use filelog qw( update_log );

# use it like
update_log("Filename","Name");

M. Brooks

http://mbrooks.info

 

[mbrooks]

Actually in this case use

#!/usr/bin/perl -w

use filelog qw( :all );

# use it like
update_log("Filename","Name");

M. Brooks

http://mbrooks.info

 

[Nutthick]

If I call it without filelog:: then I get an error

Undefined subroutine &main::update_log called at

 

[mbrooks]

O.K. lets back up here for a moment.

1. Make sure the module and script are located in the same directory.

If not you must specify use lib "path/to/module/dir/"

2. Make sure the module has a 1; located at the bottom of the file.

3. Use this to call the function of the module.

#!/usr/bin/perl -w

use filelog qw( :all );

# use it like
update_log("Filename","Name");

M. Brooks

http://mbrooks.info

 

[Nutthick]

Well as far as I can see I'm all OK

1. Everything is in the root cgi-bin
2. That last 3 lines of the pm are

1;

the full listing is below
3. All exactly as written

and my pm is as follows

package filelog;

use strict;
use vars qw( @ISA %EXPORT_TAGS @EXPORT_OK );
require Exporter;
@ISA = qw( Exporter );
%EXPORT_TAGS = (
	'all' => [
		qw(
		update_log
		)
	]
);

@EXPORT_OK = ( @{EXPORT_TAGS{'all'} } );

sub update_log {
	my ($filename) = $_[0];
	my ($track) = $_[1];

	# Read the log and determine the next ID value
	my ($filelog) = "/var/[URL unfurl="true"]www/cgi-bin/files.log";[/URL]
	my ($fileCount) = "";
	my ($temp) = "";
	my ($line2) = "";
	my ($line3) = "";

	open (FILES, $filelog) || die "Could not open file";
	while ($temp = <FILES>) {
		$fileCount = $temp;
		$line2 = <FILES>;
		$line3 = <FILES>;
	}
	close(FILES);

	$fileCount++;

	# Append the file
	open (FILES, ">>" . $filelog) || die "Could not open file for append";
	print FILES "$fileCount\n";
	print FILES "$filename\n";
	print FILES "$track\n";
	close(FILES);

	return;
}
1;

 

[mbrooks]

One last thing. Test the module on the command line.

% perl -c filelog.pm

If it still fails. Check your update_log() function.

You should declare your variables with my.

As of now your script would fail under use strict; mode.

M. Brooks

http://mbrooks.info

 

[mbrooks]

This is the test I am running on the CLI on my server. And it works fine.

filelog.pm

package filelog;

use vars qw( @ISA %EXPORT_TAGS @EXPORT_OK );

require Exporter;

@ISA = qw( Exporter );

%EXPORT_TAGS = (
    'all' => [
        qw(
          update_log
          )
    ]
);

@EXPORT_OK = ( @{ $EXPORT_TAGS{'all'} } );

sub update_log {
    my ( $name ) = @_;

    print "Update the log called - $name\n";

}

1; # always return true

filelog.pl

#!/usr/bin/perl -w

use strict;

use filelog qw( :all );

# use it like
update_log('mbrooks');

M. Brooks

http://mbrooks.info

 

[Nutthick]

Got it, I had typo'ed on your Exporter stuff, and had corrected it slightly based on the error log, so the syntax was perfect, but perfectly incorrect.

Thanks for all your help this week mbrooks. I would be in a very worried place this weekend if you hadn't helped me out.

 

[mbrooks]

No problem!

M. Brooks

http://mbrooks.info