Need some help on this sql code

[warmunger]

I get a syntax error in the last line of this code


INSERT INTO malazacompleted ( JOBCARDSID, [DATE], ContactFirstName, ContactLastName, CompanyName, Department, ADDRESS, PostalCode, PhoneNumber, MobilePhoneNumber, PurchaseOrderNumber, SerialNumber, PROBLEM, FREPORT, LABOUR, CHARGE, INVNO )
SELECT MALAZA.JOBCARDSID, MALAZA.DATE, MALAZA.ContactFirstName, MALAZA.ContactLastName, MALAZA.CompanyName, MALAZA.Department, MALAZA.ADDRESS, MALAZA.PostalCode, MALAZA.PhoneNumber, MALAZA.MobilePhoneNumber, MALAZA.PurchaseOrderNumber, MALAZA.SerialNumber, MALAZA.PROBLEM, MALAZA.FREPORT, MALAZA.LABOUR, MALAZA.CHARGE, MALAZA.INVNO
FROM MALAZA
WHERE (((MALAZA.JOBCARDSID)=[Forms]![MALAZA]![JOBCARDSID]));

please i need some help!!!

 

[Petemush]

Unless I'm being very blind, I can't see anything wrong. What's the code immediately around this bit?

Cheers,

Pete

 

[mincefish]

What data type is JOBCARDSID? Is it a number or a string?

 

[warmunger]

It tells the procedure to go and look at the jobcardsid value. Jobcardsid is the primary key. This allows you to copy specific rows in a table to another table instead of the whole table.

The data type is a number!

 

[warmunger]

Petemush i see you also replied to my other thread. This is the sql code for that query.Its works fine if I use it as a query but I want to make this query into a stored procedure now!!!

 

[warmunger]

Here is the specific error code I get

error 170: Line 14 incorrect syntax near "!"

Line 14 Being the last line in the code

Is there another way of doing something simular!!

 

[ClydeDoggie]

[Forms]![MALAZA]![JOBCARDSID]
I am assuming that the form you are referencing is named MALAZA and the control is name JOBCARDSID, is that the case? If it is, just as an aside, it's terribly confusing to not use standard naming conventions in your apps. See
thread181-293590.

 

[Petemush]

Can you post the entire procedure? Not just the SQL bit? Cheers!

Pete

 

[InsaneMember]

call me clueless... what's the ";" at the end for? does that change anything when trying to save it as a procedure? (i know i didn't have one on mine sql string)