MsgBox never displayed after for loop 1

[sidalam]

I am using the code below to find a student in an Excel spreadsheet however why does MsgBox("Name not found") ever get displayed. The code searches for a name in cells A4 to A14.

Private Sub CommandButton1_Click()
Dim findname As String
Dim counter As Integer
Dim cellRange As String
findname = InputBox("Enter student name")
For counter = 4 To 15
cellRange = "A" & counter
If Range(cellRange).Value = findname Then Exit For
Next counter
If counter = 15 Then
MsgBox ("Name not found")
Else
MsgBox ("Found at " & cellRange)
End If

End Sub

 

[Andrzejek]

In your code:

For counter = 4 To 15
    cellRange = "A" & counter
    If Range(cellRange).Value = findname Then Exit For
Next counter
[green]
'Outside of your For loop your variable [red]counter = 16[/red][/green]

If counter = 15 Then
    MsgBox ("Name not found")
Else
    MsgBox ("Found at " & cellRange)
End If

Have fun.

---- Andy

 

[sidalam]

Thanks Andrzejek

What is a quick way to check the output of a loop?
For example could I write to the console or text file for test purposes because my head always gets lost in loops for more complex code?

 

[Andrzejek]

I don't know what you mean by "What is a quick way to check the output of a loop?"

You can change you code a little:

Dim bln As Boolean
bln = False

For counter = 4 To 15
    cellRange = "A" & counter
    If Range(cellRange).Value = findname Then 
        MsgBox ("Found at " & cellRange)
        bln = True
        Exit For
    End If
Next counter

If bln = False Then
    MsgBox ("Name not found")
End If

What do you want to write inot a text file?

Have fun.

---- Andy