Minimize XSL Code

evilmungo · May 29, 2002

Ok I have the following XSL style sheet that works fine. The only problem is it's far too slow.

========================================================
<?xml version="1.0" encoding="ISO-8859-1"?>
<!-- <xsl:stylesheet xmlns:xsl="

http://www.w3.org/TR/WD-xsl">

-->
<xsl:stylesheet version="1.0" xmlns:xsl="

http://www.w3.org/1999/XSL/Transform">

<xsl:template match="/">
<table class="Dtable" border="0" cellspacing="0" cellpadding="3" width="100%">
<thead>
<th>Work Activity</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '02')
</xsl:attribute>
F
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '03')
</xsl:attribute>
M
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '04')
</xsl:attribute>
A
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '05')
</xsl:attribute>
M
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '06')
</xsl:attribute>
J
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '07')
</xsl:attribute>
J
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '08')
</xsl:attribute>
A
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '09')
</xsl:attribute>
S
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '10')
</xsl:attribute>
O
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '11')
</xsl:attribute>
N
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2002' , '12')
</xsl:attribute>
D
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2003' , '01')
</xsl:attribute>
J
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2003' , '02')
</xsl:attribute>
F
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2003' , '03')
</xsl:attribute>
M
</xsl:element>
</th>
<th>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('monthlybyworkactivity.xsl', '2003' , '04')
</xsl:attribute>
A
</xsl:element>
</th>
</thead>
<xsl:for-each select="xmldata/workactivity">
<tr>
<td>
<xsl:element name="a">
<xsl:attribute name="href">
javascript:switchView('yearlybyquestion.xsl','<xsl:value-of select="text"/>')
</xsl:attribute>
<xsl:value-of select="text"/>
</xsl:element>
</td>
<td class="before">
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
<xsl:for-each select="question/date[month='02' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="before">
<xsl:for-each select="question/date[month='03' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="before">
<xsl:for-each select="question/date[month='04' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="now">
<xsl:for-each select="question/date[month='05' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='06' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='07' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='08' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='09' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='10' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='11' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='12' and year='2002']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='01' and year='2003']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='02' and year='2003']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='03' and year='2003']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
<td class="after">
<xsl:for-each select="question/date[month='04' and year='2003']">
<xsl:if test="position()=1">
<xsl:element name="img">
<xsl:attribute name="src">
<xsl:value-of select="status"/>
</xsl:attribute>
<xsl:attribute name="alt">
<xsl:value-of select="responsible"/>
</xsl:attribute>
</xsl:element>
</xsl:if>
</xsl:for-each>
<img src="/icons/ecblank.gif" border="0" alt="" width="1" height="1" />
</td>
</tr>
</xsl:for-each>
</table>
</xsl:template>
</xsl:stylesheet>
==========================================================

Any suggestions on how to speed this up would be gratefully accepted.

Ben

uura · May 29, 2002

In each table element, you select all questions for that date, but only do something with the first (position()=1). Why not just select the first element and save yourself all the looping time. Don't know how much time it will save you, but if there are a lot of questions, it may be what is taking so long.

<xsl:for-each select="(question/date[month='04' and year='2003'])[1]">

That should select only the first node of the nodeset created by your previous select statement.

Fair warning, I haven't tried this one myself.

~~~~
"Common sense tells you that the world is flat."

MrTom · May 30, 2002

could you print a small example of the input xml and output?

evilmungo · May 30, 2002

Ok, first thanks to uura, that worked great, and has probably speeded it up quite a bit.

Heres a small portion of the XML that is passed into the stylesheet.

<?xml version="1.0" ?>
<xmldata>
<workactivity>
<text>Absence</text>
<question>
<text>A Review Appointment must be made for Jarvis Cocker on 03/10/2001</text>
<date>
<day>01</day>
<month>01</month>
<year>2002</year>
<responsible>John</responsible>
<status>2</status>
</date>
<date>
<day>11</day>
<month>01</month>
<year>2002</year>
<responsible>Steve</responsible>
<status>1</status>
</date>
<date>
<day>11</day>
<month>02</month>
<year>2002</year>
<responsible>Mark</responsible>
<status>4</status>
</date>
</question>
<question>
<text>My second question</text>
<date>
<day>21</day>
<month>11</month>
<year>2001</year>
<responsible>John</responsible>
<status>3</status>
</date>
<date>
<day>07</day>
<month>07</month>
<year>2002</year>
<responsible>Mark</responsible>
<status>1</status>
</date>
</question>
</workactivity>
</xmldata>

MrTom · May 30, 2002

there's no real reason why this should run slow.
if each question had many date fields then the
<xsl:for-each select="question/date[month='04' and year='2003']">

would start to cause problems since for each month you are rechecking the whole list. if the dates are always sorted then you might be able to use some shortcuts. i don't really understand the test for 'position()=1' - is it important only to print the first item for each month?

some tricks to help speed up the code a little - but reduce the size a lot would be to print the headers like....

<th>
<a href="javascript:switchView('monthlybyworkactivity.xsl', '2002' , '02')">F</a>
</th>

and then to print the date information you could use...

<xsl:variable name="date" select="question/date[month='03' and year='2003']"/>
<img src="{$date/status}" alt="{$date/responsible}"/>

if there is more than one date for that month it will just select the first one by default (test this tho as i'm doing this from memory)

to make the output more readable it is also useful to add

<xsl

utput method="xml" indent="yes"/>

to the top of the doc, under the initial <xsl:stylesheet> tag.

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Minimize XSL Code

evilmungo

Programmer

uura

Programmer

MrTom

Programmer

evilmungo

Programmer

MrTom

Programmer

Similar threads

Part and Inventory Search

Sponsor