Matching only certains characters

[jouell]

Is this the best perl code to match a string that can
only have letters, numbers,spaces,dash, forward slash, backslash, and pipe (|)?


#!/usr/bin/perl -w

$command=shift;

unless ($command=~ /^([-\w.\s\/\\\|]+)$/) {
print "Security error.\n";
exit (1);
}

 

[TrojanWarBlade]

yep,
Looks ok to me.


Trojan.

 

[regex7]

It also allows underscore (_) as this is included in \w.

 

[KevinADC]

there may also be no need for the parenthesis in that regexp since you appear to not be capturing the pattern in memory.

 

[jouell]

regex7:

Nice catch on the underscore! Didn't think of that. Thanks!


kevin:
Also thanks for the tip regarding the parens!

trojan:
thanks for your eyes!

 

[TrojanWarBlade]

Looks like my eyes are more tired than I thought!
;-)
Glad you got the feedback you wanted.


Trojan.