manipulating a string 2

[robUK2]

Hello,

I have a string "<sip:username@10.10.10.10:5060>"
I would like just to get the "username", and nothing else.

string callStatus = "<sip:username@10.10.10.10:5060>";
string usernameAndIP = callStatus.Remove(0, 5);
string[] username = usernameAndIP.Split('@');
this.lblCallStatus.Text = username[0].ToString();

I am using this code above. But and just Interested if there is a better more efficient way to do this.
Just looking to improve my code if that is possible, and also will this work for every situation that could arise. For example if the port number hasn't been included.

Many thanks,

 

[earthandfire]

Have a look at Regular Expressions - they are perfect for that sort of task.


Hope this helps.

 

[chrissie1]

Yeah but in this case you would end up with about the same lines of code.

And a lot less readable for most people (me included ;-)).

Christiaan Baes
Belgium

The future is out there
my blog

 

[earthandfire]

Two lines and easy to read:

			string callStatus = "<sip:username@10.10.10.10:5060>";
			lblCallStatus.Text = Regex.Match(callStatus, "(?<=\\<sip:)[a-z]+(?=@)").ToString();

Translates to:
return any number of characters that are preceeded by "[tt]<sip:[/tt]" and followed by "[tt]@[/tt]"

 

[chrissie1]

lines and even eassier to read

string callStatus = "<sip:username@10.10.10.10:5060>";
lblCallStatus.Text = callStatus.Remove(0, 5).Split('@')[0].ToString();

And shorter. ;-)

Christiaan Baes
Belgium

The future is out there
my blog

 

[chrissie1]

Long live fluent interfaces.

Christiaan Baes
Belgium

The future is out there
my blog

 

[earthandfire]

Just goes to prove that there is more than one way to skin a cat!