ListView display problems

[rickyoswald]

I have a ListView control that is being populated via a loop from a database. The loop is quite straightforward:

.MoveFirst
i = 1
Do While i < .RecordCount
frmMain.lstMainContacts.ListItems(i).SubItems(4) = !_[Phone]
.MoveNext
i = i + 1
Loop

This works okay except the first record shows up blank in the list! I thought this may be because arrays tend to start on 0 and my variable is starting on 1, however when I change it to 0 I get the error "Index out of bounds". I have looked on google and here for answers but cannot find anything specific to this problem.

 

[rickyoswald]

It is actually the last one that is not being displayed (the last record). I also pasted the wrong loop, the main one is:

Do While i < .RecordCount '+ 1
frmMain.lstMainContacts.ListItems.Add i
frmMain.lstMainContacts.ListItems(i).SubItems(1) = ![Surname]
frmMain.lstMainContacts.ListItems(i).SubItems(2) = ![Title]
frmMain.lstMainContacts.ListItems(i).SubItems(3) = ![FirstName]
.MoveNext
i = i + 1
Loop

 

[rickyoswald]

Does VB code actually run sequentially? It appears to process a block of code (inside a loop or with etc) then return values to the begining of the loop, execute them then move to the next block. This means my loop at the END of my with statment is effecting the begining of the block of code!

 

[bjd4jc]

Change your code to

Do While Not .EOF
   frmMain.lstMainContacts.ListItems.Add 
   frmMain.lstMainContacts.ListItems(i).SubItems(1) = ![Surname]
   frmMain.lstMainContacts.ListItems(i).SubItems(2) = ![Title]
   frmMain.lstMainContacts.ListItems(i).SubItems(3) = ![FirstName]
   .MoveNext
Loop

 

[rickyoswald]

Did you miss out i = i + 1 on purpose?

 

[bjd4jc]

yes,, but I forgot to change something else... I apologize!

Dim lItem as ListItem

Do While Not .EOF
   Set lItem = frmMain.lstMainContacts.ListItems.Add 
   lItem.SubItems(1) = ![Surname]
   lItem.SubItems(2) = ![Title]
   lItem.SubItems(3) = ![FirstName]
   .MoveNext
Loop

 

[bjd4jc]

The other thing to note is that with the code above the first column in the list will also be blank. Set set the text of the first column of each row do a

lItem.Text = "First Column Text

 

[rickyoswald]

Coincidently I already have a first column which is blank and hidden away. This is beacuase the first column cannot have text aligned in the center!