korn shell testing input parameters 2

[gkd]

Frieds,
./script.ksh $1 $2

i want to run a korn shell script only if $1 is equal to report or run and if $2 any number greater than zero.

Can someone advise me the efficient way to write this script.

 

[PHV]

What have you tried so far and where in your code are you stuck ?

Hope This Helps, PH.
FAQ219-2884
FAQ181-2886

 

[gkd]

Hi Here is the script that i have. it is fine, but is there a better way to do it?

#!/bin/ksh
if [ $1 = report ] || [ $1 = run ] && [ $2 -gt 0 ]
then
echo "This is correct: $0 $1 $2"
else
echo "USAGE:$0 <report|run> <number> "
fi

 

[PHV]

What about this ?

#!/bin/ksh
[ $# -eq 2 -a \( "$1" = report -o "$1" = run \) -a "$2" -gt 0 ] || {
  echo "USAGE:$0 <report|run> <number>"; exit 1
}
echo "This is correct: $0 $1 $2"

Hope This Helps, PH.
FAQ219-2884
FAQ181-2886

 

[fpmurphy]

Here is another way - using ksh93 regular expressions

if [[ $1 =~ ^(report|run)$  &&  $2 > 0 ]]
then
   echo "This is correct: $0 $1 $2"
else
   echo "USAGE:$0 <report|run> <number> "
fi

 

[gkd]

Thanks both of you.