Javascript not working in Mozilla

steve100 · Jan 22, 2004

Hi I have a simple form validation script which works fine in IE 6.0 and Opera 7.0. However it doesn't do anything in Mozilla 1.4 or Mozilla Firebird and I am not sure why.

I link to the script using an onsubmit event handler in the form tag:

<form method="post" action="someform.cgi" id="idname" onsubmit="return verify(this);" >

Within the head tags a script tag defines the location of the js file.

<script language="javascript" type="text/javascript" src="../scripts/somefile.js"></script>

Within the js file the script looks like this:

// This is the function that performs form verification. It is invoked
// from the onsubmit event handler. The handler should return whatever
// value this function returns.
function verify(f) {

var fname = -1;
var lname = -1;
var address = -1;
var postcode = -1;
var telephone = -1;
var region = -1;
var gender = -1;
var age = -1;
var faculty = -1;
var interest = -1;
var category = -1;
var experience = -1;
var membership = -1;
var contact = -1;
var issues = -1;

var msg = " ";
var empty_fields = "";

/* Verify first name is entered */

if (feedbackform.aafname.value != "&quot

{
fname = 1;
}

if (fname == -1) {
empty_fields += "first name" + "\n";
}

/* Verify last name is entered */

if (feedbackform.bblname.value != "&quot

{
lname = 1;
}

if (lname == -1) {
empty_fields += "last name" + "\n";
}

/* Verify address has been entered */

if (feedbackform.ccaddress.value != "&quot

{
address = 1;
}

if (address == -1) {
empty_fields += "address" + "\n";
}

/* Verify postcode has been entered */

if (feedbackform.ddpostcode.value != "&quot

{
postcode = 1;
}

if (postcode == -1) {
empty_fields += "postcode" + "\n";
}

/* Verify preferred telephone contact number has been entered */

if (feedbackform.ffphone.value != "&quot

{
telephone = 1;
}

if (telephone == -1) {
empty_fields += "telephone" + "\n";
}

/* Verify region has been entered */

if (feedbackform.ggregion.value != "&quot

{
region = 1;
}

if (region == -1) {
empty_fields += "region" + "\n";
}

/* Verify gender has been entered */

for (i=0; i<feedbackform.hhgender.length; i++) {
if (feedbackform.hhgender.checked) {
gender = 1;
}
}
if (gender == -1) {
empty_fields += "gender" + "\n";
}

/* Verify age has been entered */

for (i=0; i<feedbackform.iiage.length; i++) {
if (feedbackform.iiage.checked) {
age = 1;
}
}
if (age == -1) {
empty_fields += "age" + "\n";
}

/* Verify faculty has been entered */

if (feedbackform.jjfaculty.value != "&quot {
faculty = 1;
}

if (faculty == -1) {
empty_fields += "faculty" + "\n";
}

/* Verify interest has been entered */

if (feedbackform.kkinterest.value != "&quot {
interest = 1;
}

if (interest == -1) {
empty_fields += "main area of interest" + "\n";
}

/* Verify category has been entered */

if (feedbackform.lljobcategory.value != "&quot {
category = 1;
}

if (category == -1) {
empty_fields += "job category" + "\n";
}

/* Verify 'summary of experience' has been entered */

if (feedbackform.mmsummaryofexperience.value != "&quot {
experience = 1;
}

if (experience == -1) {
empty_fields += "summary of experience" + "\n";
}

/* Verify 'professional membership' has been entered */

if (feedbackform.nnprofessionalmembership.value != "&quot {
membership = 1;
}

if (membership == -1) {
empty_fields += "membership of professional bodies" + "\n";
}

/* Verify 'how contacted' has been entered */

for (i=0; i<feedbackform.oohowcontactedbyseeker.length; i++) {
if (feedbackform.oohowcontactedbyseeker.checked) {
contact = 1;
}
}
if (contact == -1) {
empty_fields += "preference for contact by career seeker" + "\n";
}

/* Verify 'issues to talk about' has been entered */

for (i=0; i<feedbackform.qqissuestotalkabout.length; i++) {
if (feedbackform.qqissuestotalkabout.checked) {
issues = 1;
}
}
if (issues == -1) {
empty_fields += "issues to talk about" + "\n";
}

/* Check if any required fields are empty, if they are give an error message with the field name */

if (empty_fields !="&quot {
msg +="______________________________________________________\n\n"
msg += "The form was not submitted because of the following error(s).\n";
msg += "- The following required field(s) are empty:" + "\n"
+empty_fields + "\n";
alert(msg);

/* Don't submit the form */
return false;

}

else {
/* Submit the form */
return true;
}

}

Does anyone know what the problem is - have I not used the correct DOM reference for Mozilla?

Thanks
Steve

BillyRayPreachersSon · Jan 22, 2004

Can you repost your JS, but this time wrap it in

Code:

code]

tags? Not doing so means we lose a lot of the meaning of the source - as you can no doubt see.

Can you also post the complete HTML?

Thanks,

Dan

steve100 · Jan 23, 2004

My complete HTML form

<form action="someform.cgi" method="post" name="feedbackform" id="feedbackform" onsubmit="return verify(this);">

<input type="hidden" name="mailto" value="someaddress"/>
<input type="hidden" name="mmsubj" value="Title- seeker form submission"/>
<input type="hidden" name="npage" value="someurl"/>

<table>
<tr>
<td class="lbl" id="left"><label for="fname">First name *</label></td>
<td id="right"><input name="aafname" type="text" id="fname"/></td>
</tr>
<tr>
<td class="lbl"><label for="lname">Family name *</label></td>
<td><input type="text" id="lname" name="bblname"/></td>
</tr>
<tr>
<td class="lbl"><label for="address">Address *</label></td>
<td><input type="text" id="address" name="ccaddress"/></td>
</tr>
<tr>
<td class="lbl"><label for="postcode">Postcode *</label></td>
<td><input type="text" id="postcode" name="ddpostcode"/></td>
</tr>
<tr>
<td class="lbl"><label for="email">E-mail </label></td>
<td><input type="text" id="email" name="ee_email"/></td>
</tr>
<tr>
<td class="lbl"><label for="phone">Preferred telephone contact number
*</label></td>
<td>
<ul>
<li>
<input type="text" id="phone" name="ffphone"/>
</li>
<li>
<input name="ffpreferredcontact" id="daytime" type="checkbox" value="daytimenumber" />
<label for="daytime">Day time number</label>
</li>
<li>
<input name="ffpreferredcontact" id="evening" type="checkbox" value="eveningnumber" />
<label for="evening">Evening number</label>
</li>
</ul></td>
</tr>
<tr>
<td class="lbl"><label for="pinumber">Personal Indicator (PI) number * </label></td>
<td><input type="text" id="pinumber" name="zzpinumber" /></td>
</tr>
<tr>
<td class="lbl"><label for="region">Region *</label></td>
<td><select name="ggregion" id="region">
<option selected="selected">--Please select--</option>
<option value="region1">Region 1</option>
<option value="region2">Region 2</option>
<option value="region3">Region 3</option>
<option value="region4">Region 4</option>
<option value="region5">Region 5</option>
<option value="region6">Region 6</option>
<option value="region7">Region 7</option>
<option value="region8">Region 8</option>
<option value="region9">Region 9</option>
<option value="region10">Region 10</option>
<option value="region11">Region 11</option>
<option value="region12">Region 12</option>
<option value="region13">Region 13</option>
</select></td>
</tr>
<tr>
<td class="lbl">Gender *</td>
<td>
<ul>
<li>
<input name="hhgender" id="male" type="radio" value="male" /><label for="male">Male</label>
</li>
<li>
<input name="hhgender" id="female" type="radio" value="female" /><label for="female">Female</label>
</li>
</ul>
</td>
</tr>
<tr>
<td class="lbl">Please indicate your age *</td>
<td>
<ul>
<li>
<input name="iiage" id="under_25" type="radio" value="under_25" /><label for="under_25">Under 25</label>
</li>
<li>
<input name="iiage" id="_25_39" type="radio" value="25_39" /><label for="_25_39">25 - 39</label>
</li>
<li>
<input name="iiage" id="_40_49" type="radio" value="40_49" /><label for="_40_49">40 - 49</label>
</li>
<li>
<input name="iiage" id="_50plus" type="radio" value="50+" /><label for="_50plus">50+</label>
</li>
</ul></td>
</tr>
<tr>
<td class="lbl"><label for="faculty">In which OU faculty have you studied the most? (Please indicate) *</label></td>
<td>
<select name="jjfaculty" id="faculty">
<option selected="selected">--Please select--</option>
<option value="arts">Arts</option>
<option value="languagestudies">Education and Language Studies</option>
<option value="health">Health and Social Welfare</option>
<option value="maths">Maths and Computing</option>
<option value="business">OU Business School</option>
<option value="science">Science</option>
<option value="socialscience">Social Science</option>
<option value="technology">Technology</option>
</select>
</td>
</tr>
<tr>
<td class="lbl">
<p>
<label for="interest">Main career area of interest *</label>
</p>
<p>
<label for="interest">Please be specific as this will help us to make
the most suitable links for you (e.g. Systems Analysis rather than simply
IT). If you are interested in teaching, please give level and subject
(e.g. Secondary school history).</label>
</p></td>
<td><input name="kkinterest" type="text" id="interest" size="40" /></td>
</tr>
<tr>
<td class="lbl"><label for="jobcategory">Please select the most appropriate job category that relates to the main career area you are interested in. *</label></td>
<td><select name="lljobcategory" id="jobcategory">
<option value="Administration">Administration</option>
<option value="Advertising">Advertising, Promotion and Marketing</option>
<option value="Animal">Animal and Plant Resources</option>
<option value="Buying">Buying, Selling and Retailing</option>
<option value="Creative_Arts">Creative Arts, Design and Crafts</option>
<option value="Education">Education</option>
<option value="Employment_Labour">Employment and Labour</option>
<option value="Engineering">Engineering</option>
<option value="Finance">Finance</option>
<option value="Health_Care">Health Care</option>
<option value="Hotel, Catering and Hotel">Hotel, Catering and Accommodation
Services</option>
<option value="Information_Services">Information Services</option>
<option value="Information_Technology">Information Technology and
Management Services</option>
<option value="Insurance_Pensions">Insurance and Pensions</option>
<option value="Law_Enforcement">Law Enforcement and Protection</option>
<option value="Legal_Services">Legal Services</option>
<option value="Leisure_Recreation">Leisure and Recreation Services</option>
<option value="Manufacturing_Processing">Manufacturing and Processing</option>
<option value="Physical_Resources">Physical Resources and the Environment</option>
<option value="Property_Construction">Property and Construction</option>
<option value="Publishing">Publishing, Media and Performing Arts</option>
<option value="Scientific_Services">Scientific Services</option>
<option value="Social_Pastoral_Care">Social and Pastoral Care</option>
<option value="Transport_Distribution]">Transport and Distribution</option>
<option selected="selected">--Please select--</option>
</select></td>
</tr>
<tr>
<td class="lbl">Please indicate the issues you would like to talk about.
(You may select more than one).*</td>
<td>
<ul>
<li>
<input name="mmissuestotalkabout" id="jobcontent" type="checkbox" value="jobcontent" /><label>Job content</label>
</li>
<li>
<input name="mmissuestotalkabout" id="howtofindajob" type="checkbox" value="howtofindajob" /><label for="howtofindajob">How to find a job</label>
</li>
<li>
<input name="mmissuestotalkabout" id="promotion" type="checkbox" value="promotion" /><label for="promotion">Promotion (how to progress)</label>
</li>
<li>
<input name="mmissuestotalkabout" id="selfemployment" type="checkbox" value="selfemployment" /><label for="selfemployment">Self-employment</label>
</li>
<li>
<input name="mmissuestotalkabout" id="training" type="checkbox" value="training" /><label for="training">Training</label>
</li>
<li>
<input name="mmissuestotalkabout" id="volunteering" type="checkbox" value="volunteering" /><label for="volunteering">Volunteering</label>
</li>
<li>
<input name="mmissuestotalkabout" id="shadowing" type="checkbox" value="shadowing" /><label for="shadowing">Work shadowing/experience</label>
</li>
<li><input type="checkbox" id="otherchk" name="qqissuestotalkabout" value="other" /><label for="other">Other (please describe)</label><input name="mmissuestotalkabout" type="text" id="other" size="40" /></li>
</ul>
</td>
</tr>
<tr>
<td></td>
<td><input type="submit" name="submit" value="submit"/></td>
</tr>
</table>
</form>

BillyRayPreachersSon · Jan 23, 2004

>> Can you repost your JS, but this time wrap it in

Code:

code]

tags?

Can you please post your JS code, as I asked, using

Code:

code]

tags to surround it? Not doing so means we lose bits of the code.

I don't ask these things for no reason, and having to ask twice is very annoying.

Dan

steve100 · Jan 23, 2004

Code:

function verify(f) {

   var fname = -1;
   var lname = -1;
   var address = -1;
   var postcode = -1;
   var telephone = -1;
   var pinumber = -1;
   var region = -1;   
   var gender = -1;
   var age = -1;
   var faculty = -1;
   var interest = -1;
   var category = -1; 
   var issues = -1; 
   
   var msg = &quot; &quot;;
   var empty_fields = &quot;&quot;;
  	
  
   /* Verify first name is entered */
  
   if (feedbackform.aafname.value != &quot;&quot;) {
       fname = 1;
       }
      
   if (fname == -1) {
	  empty_fields += &quot;first name&quot; + &quot;\n&quot;;     
	  }
	
	/* Verify last name is entered */
	
   if (feedbackform.bblname.value != &quot;&quot;) {
       lname = 1;
       }
      
   if (lname == -1) {
	 empty_fields += &quot;last name&quot; + &quot;\n&quot;;     
	 }
	
   /* Verify address has been entered */
   
   if (feedbackform.ccaddress.value != &quot;&quot;) {
       address = 1;
       }
      
   if (address == -1) {
	  empty_fields += &quot;address&quot; + &quot;\n&quot;;     
	  }
   
   
   /* Verify postcode has been entered */
   
   if (feedbackform.ddpostcode.value != &quot;&quot;) {
       postcode = 1;
       }
      
   if (postcode == -1) {
	  empty_fields += &quot;postcode&quot; + &quot;\n&quot;;     
	  }
   
   /* Verify preferred telephone contact number has been entered */
   
   if (feedbackform.ffphone.value != &quot;&quot;) {
       telephone = 1;
       }
      
   if (telephone == -1) {
	  empty_fields += &quot;telephone&quot; + &quot;\n&quot;;     
	  }
	  
  
  /* Verify preferred pinumber contact number has been entered */
   
   if (feedbackform.zzpinumber.value != &quot;&quot;) {
       pinumber = 1;
       }
      
   if (pinumber == -1) {
	  empty_fields += &quot;pi number&quot; + &quot;\n&quot;;     
	  }
   
   /* Verify region has been entered */
   
  if (feedbackform.ggregion.value != &quot;&quot;) {
       region = 1;
       }
      
   if (region == -1) {
	  empty_fields += &quot;region&quot; + &quot;\n&quot;;     
	  }
   
   
    /* Verify gender has been entered */
   	
	for (i=0; i<feedbackform.hhgender.length; i++) {
       if (feedbackform.hhgender[i].checked) {
       gender = 1;
       }
      }
      if (gender == -1) {
	  empty_fields += &quot;gender&quot; + &quot;\n&quot;;     
	  }
	 
	  /* Verify age has been entered */	 
	 
	 for (i=0; i<feedbackform.iiage.length; i++) {
       if (feedbackform.iiage[i].checked) {
       age = 1;
       }
      }
      if (age == -1) {	
	  empty_fields += &quot;age&quot; + &quot;\n&quot;; 	 	 
      }
	 
	 
	 /* Verify faculty has been entered */	
	 
	 if (feedbackform.jjfaculty.value != &quot;&quot;) {
       faculty = 1;
       }
      
     if (faculty == -1) {
	  empty_fields += &quot;faculty&quot; + &quot;\n&quot;;     
	  }
	 

     /* Verify interest has been entered */	
	 
     if (feedbackform.kkinterest.value != &quot;&quot;) {
       interest = 1;
       }
      
     if (interest == -1) {
	  empty_fields += &quot;main area of interest&quot; + &quot;\n&quot;;     
	  }


	  /* Verify category has been entered */	
	 
	 if (feedbackform.lljobcategory.value != &quot;&quot;) {
       category = 1;
       }
      
     if (category == -1) {
	  empty_fields += &quot;job category&quot; + &quot;\n&quot;;     
	  }
	 
	 
	 
	 
	 
	 /* Verify 'issues to talk about' has been entered */
	 
	 for (i=0; i<feedbackform.mmissuestotalkabout.length; i++) {
       if (feedbackform.mmissuestotalkabout[i].checked) {
       issues = 1;
       }
      }
      if (issues == -1) {
	  empty_fields += &quot;issues to talk about&quot; + &quot;\n&quot;;     
	  }
	 
	 
 /* Check if any required fields are empty, if they are give an error message with the field name */
	 
	 if (empty_fields !=&quot;&quot;) {
     msg +=&quot;______________________________________________________\n\n&quot;
     msg += &quot;The form was not submitted because of the following error(s).\n&quot;;	 
     msg += &quot;- The following required field(s) are empty:&quot; + &quot;\n&quot;
                +empty_fields + &quot;\n&quot;;
     alert(msg);
	 
	 /* Don't submit the form */
     return false;
	 
     }
	 
	 else {	 
	 /* Submit the form */
	 return true;
	 }
	 

}

BillyRayPreachersSon · Jan 23, 2004

Steve,

Thanks for reposting using the code tags - as you can see, information was lost during the first post.

Turning the Javascript console on in Mozilla immediately showed the problem - feedbackform wasn't defined.

As it happens, IE (and other browsers) are more forgiving.

If you add the following line to the top of your verify function:

Code:

var feedbackform = document.forms['feedbackform'];

Then all will work as you expect.

Hope this helps,

Dan

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Javascript not working in Mozilla

steve100

Technical User

BillyRayPreachersSon

Programmer

steve100

Technical User

BillyRayPreachersSon

Programmer

steve100

Technical User

BillyRayPreachersSon

Programmer

Similar threads

Part and Inventory Search

Sponsor