innerhtml escaping correct?

[smitheroo]

Hello,

Does anyone know why this isn't working? (on the last line of the script - 'out.innerHTML').

I presumed that I could add 'table' 'tr' and 'td' tags because it was working when I just had a radio button in the script.

I'm going to try combining innerhtml tags at some stage as I have a feeling the way I've written it might be overkill.

thanks
ian

<script type="text/javascript">
function copy() {
var sel = document.getElementById("problem2");
var text = sel.options[sel.selectedIndex].value;
var sel2 = document.getElementById("product2");
var text2 = sel2.options[sel2.selectedIndex].value;
var sel3 = document.getElementById("process2");
var text3 = sel3.options[sel3.selectedIndex].value;
var out = document.getElementById("output");
out.innerHTML += "<table>" + "<tr>" + "<td>" + "<input type=\"radio\" name=\"ouputradio\">" "<\/td>" + "<td>" + text + "<\/td>" + "<td>" + text2  + "<\/td>" + "<td>" + text3 + "<\/td>" + "<td>" + "<\/td>" + "<\/tr>"+ "<\/table>";
}
 </script>

 

[feherke]

Hi

No need to escape forward slash ( / ). No need to concatenate the string by tags. Not a brilliant idea to create a separate [tt]table[/tt] for each row.

out.innerHTML += "<table><tr><td><input type=\"radio\" name=\"ouputradio\"></td><td>" + text + "</td><td>" + text2  + "</td><td>" + text3 + "</td><td></td></tr></table>";

Feherke.

http://rootshell.be/~feherke/

 

[smitheroo]

That's got it. Well done. thanks.

I'm just doing a standalone training html, so it's not going to be examined by anyone technical.

cheers
Ian

 

[smitheroo]

Hi,

Me again. just got a quick question.

How do I amend this script so that it works with text boxes ('amount' and 'comment'), it's origianlly written for three drop downs.

I've tried changed selectedindex to 'text' but i think i'm overlooking something else to change.

best regards

Ian

<script type="text/javascript">
function copy() {
var sel = document.getElementById("actiondrop");
var text = sel.options[sel.selectedIndex].value;
var sel2 = document.getElementById("amount");
var text2 = sel2.options[sel2.selectedIndex].value;
var sel3 = document.getElementById("comment");
var text3 = sel3.options[sel3.selectedIndex].value;
var out = document.getElementById("output");
out.innerHTML += "<table border=\"0\"><tr><td align=\"left\" width=\"30%\">" + text2 + "</td><td align=\"left\" width=\"20%\">" + text  + "</td><td align=\"left\" width=\"40%\">" + text3 + "</td><td></td></tr></table>";
}
 </script>

 

[feherke]

Hi

I do not really understand what your are trying. But [tt]Text[/tt] object has no [tt]selectedIndex[/tt] or [tt]text[/tt] property, only [tt]value[/tt].

( I suggest to read DevGuru for quick JavaScript reference, personally I like it. )


Feherke.

http://rootshell.be/~feherke/