Indexing Error

[liamba]

Hi,
Im getting an error and i have no idea what it means.Hoping someone could shed some light on it for me.Thank you

Cannot apply indexing with [] to an expression of type 'int'

Here is the code
public void FindMaxValue()
{
objDataTable = objDataSet.Tables["tblScore"];
foreach (int drowRow in objDataTable.Rows)
{
if (drowRow["Total"] > decMaxValve)
{
decMaxValve = drowRow["Total"];
}
}
decXScale = ImageWidth / (objDataTable.Rows.Count - 1);
decYScale = ImageHeight / decMaxValve;
}

 

[litton1]

this line is wrong

foreach (int drowRow in objDataTable.Rows)

should be
foreach(DataRow...

Age is a consequence of experience

 

[liamba]

Hi,

After changing to a data row im still getting a error

Operator '>' cannot be applied to operands of type 'object' and 'decimal'

What i am trying to do is loop throw all the "Total" columns in my datatable and pick out the highest

public void FindMaxValue()
{
objDataTable = objDataSet.Tables["tblScore"];
foreach (DataRow drowRow in objDataTable.Rows)
{
if (drowRow["Total"] > decMaxValue)
{
decMaxValue = drowRow["Total"];
}
}
decXScale = ImageWidth / (objDataTable.Rows.Count - 1);
decYScale = ImageHeight / decMaxValue;
}

maybe a better way to do this?
Thank you

 

[TipGiver]

. Operator '>' cannot be applied to operands of type 'object' and 'decimal'

> Do proper casting.


. maybe a better way to do this?

> Yes. Have a look at the datatable's '.Select' method!



Regards

 

[TipGiver]

I don;t know if i helped enough...

The .Select method has a criteria and a sort arguments (both strings). One way is to set the sort: "Total DESC" and grab te 1st item. This will be the max!


Regards

 

[litton1]

you could give this a try

public void FindMaxValue()
{
    int myInt = 0;
    objDataTable = objDataSet.Tables["tblScore"];
    foreach (DataRow drowRow in objDataTable.Rows)
    {
       myInt = Int32.Parse(drowRow["Total"].ToString());
       if (myInt > decMaxValue)
       {
           decMaxValue = drowRow["Total"];
       }
     } 
     decXScale = ImageWidth / (objDataTable.Rows.Count - 1);
     decYScale = ImageHeight / decMaxValue;
    }

Age is a consequence of experience

 

[litton1]

Typo ALERT, typing in MS Word sorry

change this:
decMaxValue = drowRow["Total"];
to:
decMaxValue = myInt

also i should add, if there is a chance that myInt could be 'null' then use Int32.TryParse so you will always be safe

Age is a consequence of experience

 

[liamba]

Thats works perfectly.
Thanks very much.

 

[robertfah]

Just curious....

what is the main difference between:

myInt = Int32.Parse(drowRow["Total"].ToString());

and

Convert.ToInt32(drowRow["Total"].ToString());