if then else basically how to do it?????

cazeno · Sep 25, 2000

k my problem is always the same....1. evrything seems to be rigth and no error is coming up but the whole if loop or also case is ignored
2. an expected statement error message is coming up
here is my code if u can help me would be nice...really

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<%@LANGUAGE="VBScript"%>


<%If Request("tablename&quot

="" Then%>

<title>main</title>
<body bgcolor="#0066FF" text="#FFFFFF">
<p><b><font size="+2">Please choose a table you want to display:</font></b></p>
<p> </p>
<p> </p>
<p> </p>
<p> </p>
<form name="form1" method="post" action="b.asp">
<div align="center">
<select name="tablename" size="4">
<option value="item" selected>item</option>
<option value="cust" >cust</option>
<option value="prod" >prod</option>
<option value="site" >site</option>
</select>
<input type="submit" name="Button" value="Submit">
</div>
</form>

<%Else

DIM tablename
DIM SQLQuery

tablename = Request.Form("tablename&quot

set myConnection = Server.CreateObject("ADODB.Connection&quot

myConnection.Open "DSN=ph;UID=sa"
SQLQuery = "select * from " & tablename %>

<% If Request.QueryString(SQLQuery)="select * from item" Then
SQLQuery = "select item_id,descr,serial from item"%>
<% elseif Request("SQLQuery&quot

="select * from cust" Then
SQLQuery = "select cust_id,descr,address,phone from cust"%>
<% elseif Request("SQLQuery&quot

="select * from prod" Then
SQLQuery = "select prod_id,descr from prod"%>
<% elseif Request("SQLQuery&quot

="select * from site" Then
SQLQuery = "select site_id,descr,address from site"%>
<%else%>
nix

<%end if%>
<%end if%>
<%end if%>
<%end if%>

<% set RSTitleList = myConnection.Execute(SQLQuery)%>

<p> </p>
<table cellpadding=2 cellspacing=0 border=0 bordercolor="#000000" bgcolor="#FFCCCC">
<tr bgcolor="#cccccc">
<% for each field in RSTitleList.Fields %>
<th><%=field.Name%></th>
<% next %>
</tr>
<% WHILE NOT RSTitleList.EOF %>
<tr>
<% for each field in RSTitleList.Fields %>
<td><small><%=field.Value%></small></td>
<% next %>
</tr>
<%
RSTitleList.MoveNext
Wend
end if
%>
</table>
</head>

caz [sig][/sig]

RobSchultz · Sep 25, 2000

Well, first of all you need to remove some of the asp preprocessor directives (<%...%>). You only need to use these if you want to go back and forth between html and asp. In your if/then/else loop you aren't using any html so the code may just be getting confused. Try this...

Code:

dim sqlQuery
sqlQuery = Request.QueryString(&quot;SQLQuery&quot;)

If sqlQuery=&quot;select * from item&quot; Then
 SQLQuery = &quot;select item_id,descr,serial from item&quot;

 elseif sqlQuery=&quot;select * from cust&quot; Then
  SQLQuery = &quot;select cust_id,descr,address,phone from cust&quot;

  elseif sqlQuery=&quot;select * from prod&quot; Then
   SQLQuery = &quot;select prod_id,descr from prod&quot;

   elseif sqlQuery=&quot;select * from site&quot; Then
    SQLQuery = &quot;select site_id,descr,address from site&quot;
   end if

  end if

 end if        

end if

Notice also the use of but a single call to the request object. This lessens some of the overhead in the asp server.

The use of the case statement should be considered here as it makes use of a more logical construct...

Code:

dim sqlQuery
sqlQuery = Request.QueryString(&quot;SQLQuery&quot;)

Select Case sqlQuery
 Case &quot;select * from item&quot;
  SQLQuery = &quot;select item_id,descr,serial from item&quot;
 Case &quot;select * from cust&quot;
  SQLQuery = &quot;select cust_id,descr,address,phone from cust&quot;
 Case &quot;select * from prod&quot;
  SQLQuery = &quot;select prod_id,descr from prod&quot;
 Case &quot;select * from site&quot;
  SQLQuery = &quot;select site_id,descr,address from site&quot;
 Case Else
  Response.Write &quot;No Match&quot;
End Select

Speaking of case. The SQLQuery in either instance must exactly match (case included) the expression. You may want to consider making each side uppercase ( UCASE(string) ) before evaluation.

Hope this helps, [sig]<p>Rob<br><a href=mailto:robschultz@yahoo.com>robschultz@yahoo.com</a><br>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
"Focus on the solution to the problem,<br>
not the obstacles in the way."<br>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[/sig]

cazeno · Sep 26, 2000

i figured this one out .... if you have an if statement and multiple elseif's you only have to end it with a single end if. not like in vb where for each if must be an end if
k it works so .... thx for help anyway
caz [sig][/sig]

RobSchultz · Sep 26, 2000

Ooops. You're right. I know quite a few languages and sometimes get confused on syntax. But, yes, you did figure it out.

Later, [sig]<p>Rob<br><a href=mailto:robschultz@yahoo.com>robschultz@yahoo.com</a><br>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
"Focus on the solution to the problem,<br>
not the obstacles in the way."<br>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[/sig]

someone · Sep 27, 2000

also, is this right... (im not the greatest no all about code but..)

<%If Request("tablename&quot

="" Then%>

should it be request.form("tablename&quot

....

just a guess..

Bye

junnantes · Sep 27, 2000

someone,

Request("xx&quot

is just a shortcut for Request.Form("xx&quot

so either is applicable.

just a tip! [sig]<p>Jun Nantes<br><a href=mailto:bhudz@junnantes.com>bhudz@junnantes.com</a><br><a href=

http://www.junnantes.com>Jun

Nantes Official Internet Site</a><br>[/sig]

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

if then else basically how to do it?????

cazeno

Technical User

RobSchultz

Programmer

cazeno

Technical User

RobSchultz

Programmer

someone

Programmer

junnantes

MIS

Similar threads

Part and Inventory Search

Sponsor