Help with script

[uadmin]

Hi all

I have created a script but evey time i run it the script lets me enter the users id and then goes down to done .#!/usr/bin/sh
########################################
# Script to add users to HP-UX #
# Author: Simon Peter Wickham #
# Date: 04/12/01 #
########################################


ID="ID"
NAME="NAME"
GROUP="GROUP"

until [ "$ID" = "E|e" ]

do
read ID?"Please enter ID or press E to exit: "
if
print "The user has been added - THANK YOU "
exit 0
then


print "Please enter user name: "
read NAME
else

print "Please enter a group: "
read GROUP
print "The ID you entered is $ID and the name you have entered is $NAME"
sleep 2
useradd -m -s /usr/bin/sh -g $GROUP -c $NAME $ID
passwd $ID
fi
done

The problem i have is that it will not alloow me to set up any of the other variables could anyone help as it seems to be with the else statement.

Thanks
simon

Simon Peter Wickham
Email: s.wickham@zoom.co.uk

 

[MikeLacey]

Simon,

the lines:

if
print "The user has been added - THANK YOU "

you have an 'if' there with no test after it....
Mike
michael.j.lacey@ntlworld.com
Email welcome if you're in a hurry or something -- but post in tek-tips as well please, and I will post my reply here as well.

 

[aigles]

Hi Simon,

A version of your script ...
Add input checking for NAME and GROUP ...
Add error checking for useradd command ...


while :
do
echo "Please enter ID or press E to exit: "
read ID
[ "$ID" = "E" -o "$ID" = "e" ] && exit
[ -n "$ID" ] && break
done

echo "Please enter user name: "
read NAME

print "Please enter a group: "
read GROUP

print "The ID you entered is $ID and the name you have entered is $NAME"
sleep 2
useradd -m -s /usr/bin/sh -g $GROUP -c $NAME $ID
passwd $ID

print "The user has been added - THANK YOU "
exit 0

Jean Pierre.

 

[uadmin]

Thanks guys i will give this a try.


Regards
Simon Simon Peter Wickham
Email: s.wickham@zoom.co.uk

 

[uadmin]

Just one question in the line :
[ -n "$ID" ] && break
is this a test command which i have read checks to see if the line is greater then 0.

thanks
Simon
Simon Peter Wickham
Email: s.wickham@zoom.co.uk

 

[aigles]

Yes, "-n" checks that the argument is not empty string.
To test for an empty string use "-z"

Jean Pierre.

 

[uadmin]

Thanks Simon Peter Wickham
Email: s.wickham@zoom.co.uk