Help !!! code working in IE not in Firefox 1

[RaceAap]

Hi,

I have a piece of javascript that works very nice in IE but doesn't work in a Firefox browser..



function Check_Prod()
{
theForm = document.order_form;
var total = 0;
for ( i = 1 ; i <= nr_of_prod ; i++ ) {
if(theForm.elements['Product' + i].checked == true) {
tmp_pric = 0;
theForm.elements['price'+ i].value = theForm.elements['price_hid' + i ].value;
tmp_pric = new Number(theForm.elements['price_hid' + i ].value);
total = total + tmp_pric;
} else {
theForm.elements['price'+ i].value = "";
}
}
total = total.toFixed(2);
if (total == 0 ){
theForm.elements['Price_tot'].value = "";
} else {
theForm.elements['Price_tot'].value = total;
}

}

Thanx,

Lon

 

[JontyMC]

What error do you get?

 

[RaceAap]

The scripts checks if a checkbox is clicked and than puts a value in a textbox whichs corresponds to that checkbox..
But in Firefox the textbox stays empty..

for an example check:

http://webshop.besteljetelefoon.nu/index.php?a=0448BLOK&p=hfgsz

Thanx,

Lon

 

[MOrac]

Change

theForm = document.order_form;

(which is IE DOM specific) to

theForm = document.forms.order_form;

(which isn't).

 

[trollacious]

Actually, you should use the associative array syntax:

theForm = document.forms['order_form'];

Lee

 

[elegidito]

Or if you're feeling creative...

theForm = document.getElementsByTagName("FORM")["orderForm"];

"It is the mark of an educated mind to be able to entertain a thought without accepting it." - Aristotle

 

[MOrac]

Lee, the form document.forms['order_form'] is syntactically identical to document.forms.order_form. Or to document['forms']['order_form'] if you want an example of why this is a silly thing to say. The permanent DOM elements are not differently addressed than the impermanent ones.

The ['...'] notation is for use with variable structures or structures referring to items with broken identifiers - for instance, the use of spaces, which is allowed in name tags though not in id tags, yet a and form element name tags are directly inserted into the DOM tree. It doesn't make sense to use the document.forms but then to insist on ['order_form'] notation.

 

[RaceAap]

MOrac, thanks for your reply it solved the problem.



Thanx,

Lon

 

[trollacious]

I was under the impression from what I've read here that some browsers only accepted the associative array format for all forms and elements references. Sorry about that.

Lee

 

[MOrac]

<grins> Can you imagine referring to a nested media component of a CSS form by associative arrays only? *shudders*

Especially if you're paranoid and check each element exists on the way down the tree...