Getting Duplicate Values in Hash

[TommyIndigo]

The snippet of code I'm pasting below is supposed to add a new record ONLY IF it doesn't already exists. For some reason, it is adding the record twice. Any ideas? I'm rather new to "hashes of hashes", so any advice would help. Somewhere in the "if" block is where I suspect the problem. Thanks!

#Add users to the global user list
my $UsersDataFilePath = "$ExaminedProjectPath/users/data.txt";

my $TempCGIObject;
my $UserID;
  
# Open the Document Data File in read mode
open(DATAFILE1, &quot;<$UsersDataFilePath&quot;);
# Instantiate a new CGI object for each record in the user data file and store object
# reference in a hash table keyed on the unique ID field
while (!eof(DATAFILE1))
 {
  $TempCGIObject = CGI->new(\*DATAFILE1);
  #Only add if user isn't already on this list
  $UserID=($TempCGIObject->param('UserID'));

  if (!defined($GlobalUserList{$UserID}))
  {
   $GlobalUserList{$UserID}=$UserID;
   $GlobalUserList{$UserID}{EmailAddress}=($TempCGIObject->param('EmailAddress'));
   $GlobalUserList{$UserID}{DomainName}	= ($TempCGIObject->param('DomainName'));
   $GlobalUserList{$UserID}{UserName} =	($TempCGIObject->param('UserName'));
   }#end if
 }#end while
  
# Close the data file
close(DATAFILE1);

 

[PaulTEG]

Are you trimming the key to make sure that
"elvis" isn't determined to be the same as
" elvis" or
"elvis "

Try throwing an else to your if to record "duplicates "

--Just a thought
Paul

 

[TommyIndigo]

Good idea...I'll try that! Thanks

 

[siberian]

I think Paul is right on here. I would toss in a line

print ":$UserID:\n" ;

right after I assigned the UserID. This is just for debug but immediately shows you exactly what you are using as a key.

You can also use Data:umper on your final data structure to see where you are going wrong. Data:umper is a fantastic tool for this sort of debug.

 

[pheuvel]

Gday,

According to the perlfunc reference,
"When used on a hash element, it tells you whether the value is defined, not whether the key exists in the hash. Use exists for the latter purpose."

So your checking line should read:
if (!exists($GlobalUserList{$UserID}))