Explode a Session

[d0nny]

OK, I can't understand this.

As part of my shopping cart, I have a session called 'cart' whihc should have the product ID and the quantity in it.
I call a funtion called 'getNumItems...

function getNumItems() {
     $cart = $_SESSION['cart'];
     if (!$cart) {
          return '<p>No items</p>';
     } else {
          // Parse the cart session variable
          $items = explode(',',$cart);
          $s = (count($items) > 1) ? 's':'';
          return '<p>items: <a href="/includes/shoppingcart.php">'.count($items).' item'.$s.'</a></p>';
     }
}

The issue I have is that if there is more than 0 items in the cart, it always returns 1.
So if I have 1 item in the cart this function returns 1, but if I have 2 or more, it still returns 1!

I did put a 'print_r($cart)' in the function and I got this:

Array ( 
   [0] => Array (
      [productid] => 83
      [qty] => 2
    )
   [1] => Array (
      [productid] => 98
      [qty] => 2
   )
)

Actually, not that I write that, the array doesn't look right!
Can someone please put me straight??

 

[jpadie]

if $cart is already an array, why are you exploding it?

that array looks fine. however i would have the productid as the primary key of each array element. that way it is very easy to adjust quantities without iterating the whole array.

i would also store the offered price in the cart array as it is always possible that the price has changed between putting the item in the cart and checkout. that way you can test for this change and if it has happened you can warn the consumer of the price change before they make the purchase.

i suggest your function might work if you did the following

function getNumItems() {
     $c = empty($_SESSION['cart']) ? 0 : count($_SESSION['cart']);
     $s = ($c > 1) ? 's':'';
     return $s > 1 ?  '<p>items: <a href="/includes/shoppingcart.php">'.$c.' item'.$s.'</a></p>' : '<p>No items</p>';
}

 

[d0nny]

Hi Justin, I thought you might answer this one!

But I've substituted my original code for your code and it always returns 'No Items'.
I have tried changing the 'return $s > 1' part to 'return $s > 0' as I want a true asnwer if the there are more than 0 items in the cart (is this right?) but I still get 'No Items' returned.

 

[jpadie]

sorry. brain fart whilst typing the above

function getNumItems() {
     $c = empty($_SESSION['cart']) ? 0 : count($_SESSION['cart']);
     $s = ($c > 1) ? 's':'';
     return [red]$c > 0[/red] ?  '<p>items: <a href="/includes/shoppingcart.php">'.$c.' item'.$s.'</a></p>' : '<p>No items</p>';
}