Dodgy if statement need help 1

[maverickmonster]

I have an If statement in a VBA excel application but it does not seam to work properly, it does not seam to fire the right statements they must be done in this order could any one help or make any suggestions ?

Thanks

If (Sheets(1).Cells(X, 55) = "Y") Then
GoTo pro1
ElseIf (Sheets(1).Cells(X, 54) = "C" And Sheets(1).Cells(X, 56) = "N") Then
GoTo pro2
ElseIf (Sheets(1).Cells(X, 45) = "V") Or (Sheets(1).Cells(X, 45) = "C") And Sheets(1).Cells(X, 54) = "U" And Sheets(1).Cells(X, 55) = "N" And Sheets(1).Cells(X, 56) = "Y" And (Sheets(1).Cells(X, 45) = "I") Or (Sheets(1).Cells(X, 45) = "F") Then
GoTo pro3
ElseIf (Sheets(1).Cells(X, 45) = "V") Or (Sheets(1).Cells(X, 45) = "C") And (Sheets(1).Cells(X, 54) = "U") Or (Sheets(1).Cells(X, 54) = "C") And Sheets(1).Cells(X, 55) = "N" And Sheets(1).Cells(X, 56) = "Y" And (Sheets(1).Cells(X, 56) = "N") Then
GoTo pro4
ElseIf (Sheets(1).Cells(X, 45) = "I") Or (Sheets(1).Cells(X, 45) = "F") Then
GoTo pro5
ElseIf ((Sheets(1).Cells(X, 45) = "V") Or (Sheets(1).Cells(X, 45) = "C")) And Sheets(1).Cells(X, 54) = "U" And Sheets(1).Cells(X, 55) = "N" And Sheets(1).Cells(X, 56) = "N" And Sheets(1).Cells(X, 45) = "F" Then
GoTo pro6
ElseIf (Sheets(1).Cells(X, 45) = "V") Or (Sheets(1).Cells(X, 45) = "C") And Sheets(1).Cells(X, 54) = "U" And Sheets(1).Cells(X, 55) = "N" And Sheets(1).Cells(X, 56) = "N" And Sheets(1).Cells(X, 45) = "I" Then
GoTo pro7
ElseIf (Sheets(1).Cells(X, 45) = "V") Or (Sheets(1).Cells(X, 45) = "C") And Sheets(1).Cells(X, 54) = "U" And Sheets(1).Cells(X, 55) = "N" And Sheets(1).Cells(X, 56) = "N" And Sheets(1).Cells(X, 45) = "N" Then
GoTo pro8

 

[Digsy]

Well for starters (as far as i can see)

ElseIf (Sheets(1).Cells(X, 45) = "V") Or (Sheets(1).Cells(X, 45) = "C") And Sheets(1).Cells(X, 54) = "U" And Sheets(1).Cells(X, 55) = "N" And Sheets(1).Cells(X, 56) = "Y" And (Sheets(1).Cells(X, 45) = "I") Or (Sheets(1).Cells(X, 45) = "F") Then
        GoTo pro3

will never fire because you are checking if the value of Sheets(1).Cells(X, 45) is either V or C and either I or F. As the value of Sheets(1).Cells(X, 45) can't be both either V or C and either I or F then this will never fire.

I suggest you use more brackets around the various parts of your If/ElseFf statements so that it is clearer (to yourself and others)what exactly they are testing. This would be a good first step if nothing else.

HTH

Dave

 

[Digsy]

Ooops pushed enter too soon

The brackets will also sort out any order of precedence issues that may be causing your code not to work, I believe that 'And' has a higher order of precedence than 'Or' but not 100% certain on that.

Dave