Do/while problem? 2

[frozenpeas]

Hello.

Here is the page in question:

http://www.frozen-peas.com/fp/temp/portfolio/

I am creating links from the database results and this is where my problem is. It seems that no matter what I do, I can generate only one link from the database records.

mysql_select_db($database_connect, $connect);
if(!$type){
	$type = "web";
}
$query_myQuery = "SELECT * FROM folio WHERE type = '".$type."'";
$myQuery = mysql_query($query_myQuery, $connect) or die("Could not access database. ".mysql_error());
$row_myQuery = mysql_fetch_assoc($myQuery);
$totalRows_myQuery = mysql_num_rows($myQuery);
mysql_free_result($myQuery);

<?
$curRow = 0;
if($row_myQuery){
	do{
		$curRow++;
	?>
	<div id="folioPiece">
		<a href="<? echo $_SERVER['PHP_SELF']."?type=".$type."&project=".$row_myQuery['name'];?>"><img src="<? echo $type;?>/images/th_<? echo $row_myQuery['pic'];?>" width="35" height="35" border="0" class="folioThumb" title="<? echo $row_myQuery['name'];?>" /></a><span class="folioThumb"><? echo $row_myQuery['name'];?></span>
		<div id="folioCorner"><a href="<? echo $_SERVER['PHP_SELF']."?type=".$type."&project=".$row_myQuery['name'];?>"><img src="../images/foliopiece_corner.gif" border="0" width="14" height="14" title="view project" /></a></div>
	</div>
</div>
<? }while($curRow<$totalRows_myQuery);
}
?>

For the only result displayed, $curRow has a value of 1. However, $totalRows_myQuery has a value of 3.

I suspect it may be the while section of my loop that I am having trouble with.

Thanks everyone.

frozenpeas

 

[chessbot]

Why use do..while?

<?
if($row_myQuery){
    [red]for ($curRow = 0; $curRow<$totalRows_myQuery; $curRow++) {[/red]
    ?>
    <div id="folioPiece">
        <a href="<? echo $_SERVER['PHP_SELF']."?type=".$type."&project=".$row_myQuery['name'];?>"><img src="<? echo $type;?>/images/th_<? echo $row_myQuery['pic'];?>" width="35" height="35" border="0" class="folioThumb" title="<? echo $row_myQuery['name'];?>" /></a><span class="folioThumb"><? echo $row_myQuery['name'];?></span>
        <div id="folioCorner"><a href="<? echo $_SERVER['PHP_SELF']."?type=".$type."&project=".$row_myQuery['name'];?>"><img src="../images/foliopiece_corner.gif" border="0" width="14" height="14" title="view project" /></a></div>
    </div>
</div>
<?   }
}
?>

--Chessbot

There is a level of Hell reserved for probability theorists in which every monkey that types on a typewriter produces a Shakespearean sonnet.

 

[frozenpeas]

Thanks, Chessbot. However, that did not solve my problem.

http://www.frozen-peas.com/fp/temp/portfolio/

It is still returning only one result. Can you see anything I've done wrong?

Thanks again.

frozenpeas

 

[chessbot]

How about cleaning up a little?

<?
if($row_myQuery)
{
  for ($curRow = 0; $curRow<$totalRows_myQuery; $curRow++)
  {
    echo '<div id="folioPiece">\n';
    echo '<a href="' . $_SERVER['PHP_SELF'] . '?type=' . $type . '&project=' . $row_myQuery['name'] . '">\n';
    echo '<img src="' . $type . '/images/th_' . $row_myQuery['pic'] . '" width="35" height="35" border="0" class="folioThumb" title="' . $row_myQuery['name'] . '" />\n';
    echo '</a>\n';
    echo '<span class="folioThumb">\n';
    echo $row_myQuery['name'] . '\n';
    echo '</span>\n';
    echo '<div id="folioCorner">\n';
    echo '<a href="' . $_SERVER['PHP_SELF'] . '?type=' . $type . '&project=' . $row_myQuery['name'] . '">\n';
    echo '<img src="../images/foliopiece_corner.gif" border="0" width="14" height="14" title="view project" />\n';
    echo '</a>\n';
    echo '</div>\n';
    echo '</div>\n';
    echo '</div>\n';
  }
}
?>

See anything that doesn't work?

--Chessbot

There is a level of Hell reserved for probability theorists in which every monkey that types on a typewriter produces a Shakespearean sonnet.

 

[frozenpeas]

Still doesn't work. This is a real pickle.

frozenpeas

 

[chessbot]

1. You seem to have an extra </div>.
2. Why are these divs all given the same id? Id is supposed to be unique.

--Chessbot

There is a level of Hell reserved for probability theorists in which every monkey that types on a typewriter produces a Shakespearean sonnet.

 

[kenrbnsn]

Why bother with the loop structure you're trying to use, when a simple While loop will work fine:

while ($row_myQuery = mysql_fetch_assoc($myQuery))
{    ?>
    <div id="folioPiece">
        <a href="<? echo $_SERVER['PHP_SELF']."?type=".$type."&project=".$row_myQuery['name'];?>"><img src="<? echo $type;?>/images/th_<? echo $row_myQuery['pic'];?>" width="35" height="35" border="0" class="folioThumb" title="<? echo $row_myQuery['name'];?>" /></a><span class="folioThumb"><? echo $row_myQuery['name'];?></span>
        <div id="folioCorner"><a href="<? echo $_SERVER['PHP_SELF']."?type=".$type."&project=".$row_myQuery['name'];?>"><img src="../images/foliopiece_corner.gif" border="0" width="14" height="14" title="view project" /></a></div>
    </div>
</div>
<? } ?>

I think this is easier to understand and debug.

Ken

 

[frozenpeas]

Chessbot,

I'm fairly new to CSS and it completely slipped my mind that div ids have to be unique.

I switched them to classes but am still having the other problems.

I'll keep working away at it... I'm sure I'll be back.

Thanks.

frozenpeas

 

[frozenpeas]

I cleaned up my code a bit, got rid of that extra </div> and am using classes where (I think) I should be.

<?
if($row_myQuery){
	do{
	?>
	<div class="folioPiece">
		<a href="<? echo $_SERVER['PHP_SELF']."?type=".$type."&project=".$row_myQuery['name'];?>"><img src="<? echo $type;?>/images/th_<? echo $row_myQuery['pic'];?>" width="35" height="35" border="0" class="folioThumb" title="<? echo $row_myQuery['name'];?>" /></a><span class="folioThumb"><? echo $row_myQuery['name'];?></span>
		<div class="folioCorner">
			<a href="<? echo $_SERVER['PHP_SELF']."?type=".$type."&project=".$row_myQuery['name'];?>"><img src="../images/foliopiece_corner.gif" border="0" width="14" height="14" title="view project" /></a>
		</div>
	</div>
<? }while(@$row = mysql_fetch_assoc($myQuery));
}
?>

The way this currently works, is still only one result is shown. I get this error:

Warning: mysql_fetch_assoc(): 3 is not a valid MySQL result resource in /temp/portfolio/index.php on line 66

which refers to this line:

while(@$row = mysql_fetch_assoc($myQuery));

(I am surpressing that error for now - I have to present it in class tomorrow)

Now, when I try this (which to my understanding is what I *should* be doing):

while($row_myQuery = mysql_fetch_assoc($myQuery))

I get the same singular result, repeatedly.

Am I using the proper while condition? Thanks again, everyone.

frozenpeas

 

[Westbury]

Make sure that your call to mysql_free_result($myQuery) is after you have finished with $myQuery, else it will delete the results stored in $myQuery.

If it aint broke, redesign it!

 

[frozenpeas]

That was it, Westbury. Thanks.

frozenpeas