Displaying as HTML 1

[IWIT]

I have a program the same as the code before and I was wondering how you can display this as HTML in a browser. As in I have a file that I wish to display the contents of as a web page.

Thank You

#!/usr/bin/perl
use strict;
use warnings;
use CGI "Vars";
use 5.004;
use Fcntl qw(:DEFAULT :flock);
use CGI::Carp qw(fatalsToBrowser);

my ($filename, @all, $list, @items, $item);


$filename = "msgs";

open(MYFILE,"< $filename");
@all=<MYFILE>;

$list ="@all";
@items = split /__FINISH__\n/ , $list;


for my $item (@items)
{
	my($name, $email, $subject, $text) =split /\n/, $item, 4;
	
print "Name:- $name\n";
print "Email:- $email\n";
print "Subject:- $subject\n";
print "Message:- $text\n";
}

 

[duncdude]

I really am not too sure I understand... if you mean you would like to be able to display any text file in a browser then save it as .txt and it will just display...

http://www.my-mot.co.uk/tek-tips/dtennant9.txt

Kind Regards
Duncan

 

[IWIT]

what I meant by it is that I have the above program which takes the information from the file "msgs" and returns it to the screen. This above program works on our Samba server using its software. What I want to do is have the same output but in Internet Exploer. I know that to do this I need to add HTML tags. I have included below my first attempt. The below attempt does not work.

#!/usr/bin/perl

use strict;
use warnings;
use CGI "Vars";
use 5.004;
use Fcntl qw(:DEFAULT :flock);
use CGI::Carp qw(fatalsToBrowser);


my($query, $fname, $date, @all, $list, @items, $title);

$query = new CGI;                 # Object captures the command line 
$fname=$query->param('private_file');

#
# if there as a parameter private_file, use that name as the data file
# otherwise default to data.txt.
#
if (defined $fname)
{
    $title="Experimental bulletin board for $fname";
}
else
{
    $title="Experimantal bulletin board";
    $fname="../board.data";
}


#
# now get exclusive access
#

sysopen(FH, "$fname", O_RDONLY)
        or die "can't open $fname: $!";
flock(FH, LOCK_EX)
        or die "can't lock $fname: $!";

seek FH,0,0;     # now go to start

@all=<FH> or die "Could not open file\n";
close FH;

$list ="@all";
@items = split /__ITEM__\n/, $list;
print $query->header,
    $query->start_html(-title=>$title,
		       -style=>{'src' => '../mystyle.css'}),
    $query->h1 ($title),

    '<div class="indent"><div class="shaded"><p>This is an experimental
    bulletin board that only offers the most elementary features. If
    it proves to be useful, more features may be added in the
    future.</p></div></div><br><br>',

    $query->hr;

my $count = 1;
for my $item (@items)
{
    my($date, $name, $email, $subject, $text)=split /\n/, $item,5;
    $text = join('<br>',split(/\n/,$text));
    print <<FINE
<b>Item: $count</b><br>
From: <a href=\"mailto:$email\">$name</A><br>
Date: $date<br>
Subject: $subject<br>
<br>
    $text
<hr>
FINE
    ;
    $count++;
}

print $query->end_html;

 

[philote]

Check your web server logs for errors and report them. Is anything being displayed on the web browser when you access this script?

 

[IWIT]

Sorry that was the wrong code. I am getting the following errors in the browser from the below code.


Software error:
Not enough arguments for sysopen at f:\student-homes\01\0100358\cgi-bin\display.pl line 17, near ""$filename")"
Global symbol "$Subject" requires explicit package name at f:\student-homes\01\0100358\cgi-bin\display.pl line 36.
Execution of f:\student-homes\01\0100358\cgi-bin\display.pl aborted due to compilation errors.

#!/usr/bin/perl
use strict;
use warnings;
use CGI "Vars";
use 5.004;
use Fcntl qw(:DEFAULT :flock);
use CGI::Carp qw(fatalsToBrowser);


my ($query,$filename, @all, $list, @items, $item);

$query = new CGI;
$filename=$query->param('private_file');

$filename = "msgs";

sysopen(MYFILE,"$filename");
flock(MYFILE, LOCK_EX);
seek MYFILE,0,0;	#now go to start

@all=<MYFILE>;
close MYFILE;

$list ="@all";
@items = split /__FINISH__\n/ , $list;

print $query->header,
      $query->start_html,
      $query->hr;
	
my $count = 1;
for my $item (@items)
{
	my($name, $email, $subject, $text) =split /\n/, $item, 5;
	$text = join('<br>',split(/\n/,$text));
	print <<FINE
<b>Item: $count</b><br>
From:$name<br>
Email:$email<br>
Subject: $Subject<br>
<br>
     $text
<hr>
FINE
    ;
    $count++;
}

print $query->end_html;

 

[arn0ld]

are you testing your code before submitting it to the browser?

perl -c script.cgi

and
./script.cgi xxx

you need an additional parameter for sysopen
perl here documents are
func <<"EHERE";

 

[philote]

Like arn0ld and the errors said, not enough arguments to sysopen.
Perldoc for sysopen:

http://www.perldoc.com/perl5.8.0/pod/func/sysopen.html

And the other error is basically saying you didn't declare $Subject.... instead you declared $subject - variable names are case-sensitive.

 

[PaulTEG]

Why are you using sysopen at all, if all you're doing is reading the file?

open FH, "<myfile.txt";
print "<pre>\n";
while (<FH>) {
  print $_;
}
close FH;
print "</pre>\n";

--Paul

 

[IWIT]

I have now changed the program so that the variable subject are both the same and I have also changed the sysopen to just open. my previous errors have now gone and I now have new ones.


CGI Error
The specified CGI application misbehaved by not returning a complete set of HTTP headers. The headers it did return are:

open(MYFILE,"< $filename");

 

[arn0ld]

are you at all testing your code before submitting it to the browser?

perl script.cgi xxxx

 

[IWIT]

It actually works now. The problem before was that it was running on a Windows Server and when I moved it to a UNIX one it worked.