Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Register Log in
  • Congratulations Mike Lewis on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

Could somebody have a look at this

Status
Not open for further replies.
finnoscar

finnoscar

Technical User
Aug 17, 2002
55
0
0
GB
Could somebody have a look at this and tell me what if anything is missing from it:

<%@ LANGUAGE = JavaScript%>
<HTML>
<HEAD>
<meta name=&quot;Microsoft Theme&quot; content=&quot;indust 110, default&quot;>
</HEAD>
<BODY>
<%


// Connect to database
var adoConnection = Server.CreateObject(&quot;ADODB.Connection&quot;);
adoConnection.Open(&quot;DSN=DogDSN&quot;);
var adoRecordset;

// Create SQL to update pups info in Breeders table
var mySQL = &quot;UPDATE Breeders SET PupsAvailable ='&quot; & Request.Form(&quot;txtPupsAvailable&quot;)&&quot;'&quot;
& &quot;WHERE BreederNo =&quot;Val(Request.Form(&quot;txtBreederNo&quot;));


// Execute SQL to update breeder pups info
adoConnection.Execute(mySQL);


// Recordset not needed after this so close it and allow release of memory
adoRecordset.Close();
adoRecordset = null;



Response.Write(&quot;<H2><CENTER>Your Details have been updated successfully&quot; +
&quot;</CENTER></H2>&quot;);
%>
</BODY>
</HTML>
 
Sort by date Sort by votes
there's a ' missing in the SQL
var mySQL = &quot;UPDATE Breeders SET PupsAvailable ='&quot; & Request.Form(&quot;txtPupsAvailable&quot;)&&quot;'&quot;
& &quot;WHERE BreederNo =&quot;Val(Request.Form(&quot;txtBreederNo&quot;)&quot;; hope I helped!
[roll2]
admin@onpntwebdesigns.com
 
Upvote 0 Downvote
I get a missing & at &quot; WHERE BreederNo =&quot; & Val(Request.Form(&quot;txtBreederNo&quot;)), and you'll want to put a space before WHERE

so it should look like
Code: 
mySQL = &quot;UPDATE Breeders SET PupsAvailable ='&quot; &  Request.Form(&quot;txtPupsAvailable&quot;) & &quot;'&quot; 
& &quot; WHERE BreederNo =&quot; & Val(Request.Form(&quot;txtBreederNo&quot;))
Tom
 
Upvote 0 Downvote
Do I have to declare the two variables txtPupsAvailable and txtBreederNo like this

var int_BreederNo = new Integer(Request.Form(&quot;txtBreederNo&quot;))
var str_PupsAvailable = new String(Request.Form(&quot;txtPupsAvailable&quot;))
 
Upvote 0 Downvote
Do I need to declare these 2 variables and do I need an if statement like

if (int_BreederNo!=&quot;undefined&quot; && str_PupsAvailable!=&quot;undefined&quot;)

in order to read in these 2 values from a form like this

</SCRIPT>
<meta name=&quot;Microsoft Theme&quot; content=&quot;indust 110, default&quot;>
</HEAD>
<BODY>
Please enter your Breeder Number and Update Information
<BR>
<FORM ACTION=&quot;Update.asp&quot; METHOD=POST NAME=form4 LANGUAGE=JavaScript
onsubmit=&quot;return form4_onsubmit()&quot;>

Breeder Number
<BR>
<INPUT TYPE=&quot;text&quot; NAME=txtBreederNo MAXLENGTH=50>
<BR>
Pups Available
<BR>
<INPUT TYPE=&quot;text&quot; NAME=txtPupsAvailable MAXLENGTH=3>
<BR>
<INPUT TYPE=&quot;submit&quot; VALUE=&quot;Send Details&quot; ID=submit4 NAME=submit4>
</FORM>

</BODY>
</HTML>

Could somebody help with this question?
 
Upvote 0 Downvote
It probably would be safer, if you assume the user will always enter values in both.
It appears you have onSubmit code already set up, so if you add the following to your form4_onsubmit function:
Code: 
if (form4.txtBreederNo.Value.toString().length == 0){
   alert(&quot;You have forgotten to enter the breeder number.&quot;);
   form4.txtBreederNo.focus();
   return false;
}
if (form4.txtPupsAvailable.Value.toString().length == 0){
   alert(&quot;You have forgotten to enter the number of available pups.&quot;);
   form4.txtPupsAvailable.focus();
   return false;
}
Don't forget that the last line should be a return true in the event that it passed all conditions in the function.

If you do this client-side you shouldn't need to check again on the server side, but you could with
Code: 
If Request.Form(&quot;txtPupsAvailable&quot;) <> &quot;&quot; AND Request.Form(&quot;txtBreederNo&quot;) <> &quot;&quot; Then
   'Do your database submit
Else
   'Redirect back to form
End If
Hope that was what you were looking for
-Tarwn ------------ My Little Dictionary ---------
Reverse Engineering - The expensive solution to not paying for proper documentation
 
Upvote 0 Downvote
Status
Not open for further replies.

Similar threads

penguinspeaks
  • Locked
  • Question
Parse a database field that is comma delimited and input the results into another table
Replies
0
Views
144
penguinspeaks
penguinspeaks
leifoet
  • Locked
  • Question
Wrong code in a href ?
Replies
1
Views
141
leifoet
leifoet
leifoet
  • Locked
  • Question
How to check if a datatable is empty ?
Replies
0
Views
150
leifoet
leifoet
leifoet
  • Locked
  • Question
Using date picker gives an error message, only at application start
Replies
1
Views
143
MarkSweetland
MarkSweetland
penguinspeaks
  • Locked
  • Question
Start loop from a specified point
Replies
0
Views
128
penguinspeaks
penguinspeaks

Part and Inventory Search

Sponsor

Back
Top