Comparing two binary files? 1

[redgenie]

I'm having trouble comparing 2 binary files, can anyone give me a pointer to what I'm doing wrong in the following function:

private function filesSame(FileName1, FileName2)

	Const adTypeBinary = 1

	'Create Stream objects
	Dim BinaryStream1, BinaryStream2
	Set BinaryStream1 = CreateObject("ADODB.Stream")
	Set BinaryStream2 = CreateObject("ADODB.Stream")

	'Specify stream type - we want To get binary data.
	BinaryStream1.Type = adTypeBinary
	BinaryStream2.Type = adTypeBinary

	'Open the stream
	BinaryStream1.Open
	BinaryStream2.Open

	'Load the file data from disk To stream object
	BinaryStream1.LoadFromFile FileName1
	BinaryStream2.LoadFromFile FileName2

	'Open the stream And get binary data from the object
	BinaryFile1 = BinaryStream1.Read
	BinaryFile2 = BinaryStream2.Read

	if BinaryFile1 <> BinaryFile2 then
		filesSame = false
	else
		filesSame = true
	end if

end function

Any help would be greatly appreciated!

 

[DreXor]

only thing i can see in here is the possibility of larger files might be exceeding the bounds of the variables :

'Open the stream And get binary data from the object
BinaryFile1 = BinaryStream1.Read
BinaryFile2 = BinaryStream2.Read

perhaps pass the values into binaryfile1(0) and binaryfile2(0)

DreX
aKa - Robert

 

[redgenie]

No that doesn't work unfortunately. The error I get is a Type Mismatch on the following line:

if BinaryFile1 <> BinaryFile2 then

 

[DreXor]

try if strcomp(binaryfile1,binaryfile2,vbbinarycompare)

DreX
aKa - Robert

 

[JohnYingling]

Perhaps BinaryStream1.Read produces Byte array which now must be compared element by element with BinaryFile2.

http://www.VBResizer.com

Forms/Controls Resizing/Tabbing

http://www.VBCompare.com

Compare Code

http://www.VBSortGen.com

Generate Sort Class in VB

http://www.Vbcompare.com/Check.Htm(1979

Check To MS)

 

[redgenie]

I think your right because even though I am not getting the Type Mismatch error it returns false when comparing two files which are exactly the same.

I'll have a look into the links you provided, thanks!

 

[DreXor]

:-D

thought you might like these links :

http://www.freevbcode.com/ShowCode.asp?ID=5393

(vb.net)

http://www.freevbcode.com/ShowCode.asp?ID=574

(vb5/6)

DreX
aKa - Robert

 

[redgenie]

Great stuff, thank you very much guys. You've been very kind