Comma Seperated List String 1

[autumnEND]

Im trying to build up a string using substrings, and if there are more than one substring seperate them with a comma.

The maximum number of possible substrings is 7

Below is an example of how i get the string value

if (Convert.ToInt32(dr["country_england"]) == 1)
{
strEng = "England";
}

the final string will be :

strAreas = strEngland + strWales + strScotland etc

what would be the best way to build up the string, and to seperate them with a comma if there is more than one substring .

Any help would be greatly appreciated, Thanks.

 

[autumnEND]

I managed to sort it , by creating a function that added a comma and then remove the comma if its not needed.

private bool addComma()
{
if (strAreas != "")
{
strAreas += "," ;
strAreasTrim = strAreas.TrimEnd(',');
return true;
}

}

Im sure theres possibly a better way to do it, but it works for now .

 

[mit99mh]

I know you said you'd sorted out your prob but this is what I tend to do:


string a = "a," + "b," + "c,";

string b = a.Substring( 0, a.LastIndexOf( ',' ) );

Cheers

 

[autumnEND]

thanks for the reply, ill give that a try, it seems a better idea compaired to the solution i came up with, thanks again .

 

[earthandfire]

You could also have a look at the .Join method of string which will do what you require.


Hope this helps.

 

[phinoppix]

Because .net strings are immutable, you might want to consider using StringBuilder, much cheaper to use.

System.Text.StringBuilder bufTxt = new StringBuilder();
...

// Here you get a little overhead evaluating the conditions
// but much less compared to TrimEnd() because it's actually
// returning a new string object without the ending character
// making it appear as if trimmed.
if(strEngland.Length > 0) {
  if(bufTxt.Length > 0) bufTxt.Append(",");
  bufTxt.Append( strEngland );
}

 

[misterstick]

elegant solution to a perennial problem.

now, why didn't i think of that?



mr s. <