closing connection

[dvannoy]

question....

is con.close() enough to close the connection ? or should I also add con.dispose() ?

I have been getting a message stating "Timeout expired. the timeout period elapsed prior to a connection from the pool. This may have occurred because all pooled connections were in use and max pool size was reached.


any info would be appreciated

 

[jbenson001]

This should not happen in newer versions of the framework since the have enhanced garbage collection. Since I don't know what version or your exact code, I suspect connections are being left open. The best thing to do is to get into the habit of using "Using" statements when opening connections to the DB. The "Using" will close the connection for you automatically once data is returned or an error occurs.

 

[dvannoy]

okay, I understand. is the below code fine or did I miss something. since I'm using "try" do I need to dispose or con ?

Using con As SqlConnection = New SqlConnection(My_Con)

Dim cmd As New SqlCommand

cmd.Connection = con
cmd.CommandType = CommandType.StoredProcedure
cmd.CommandText = "My SP"


Try
con.Open()
cmd.ExecuteNonQuery()

Catch ex As Exception
error handling
Finally
message to user
End Try
End If

End Using

 

[bborissov]

Better use using:

 using (var sqlConn = new SqlConnection(ConnectionString))
{
 sqlConn.Open();
....
sqlConn.Close();
}

I used Close and Dispose and have troubles, but when I started to use using() the problems gone

Borislav Borissov
VFP9 SP2, SQL Server

 

[dvannoy]

okay, thanks

I thought of the whole purpose of "using" was that the connection was closed automatically and you don't need to do a con.close() ? I guess it wouldn't hurt

 

[jbenson001]

With a Using statement you don't need to specifically close the connection. That is the major point of using a Using statment.