Changing variable values

[bill1one]

I have text boxes on my form for users to enter a range of numbers that they would like to see in the database. I would like to query to ignore the range if the user does not enter anything in the box.

To do this, I basically said if the variables are empty to reassign them with the minimum and maximum number possible.

Here is the code I have for that:

$min = $_POST['min'];
$max = $_POST['max'];

if ($min == "") {
$minNew = 0;
}
else {
$minNew = $min;
}

if ($max == "") {
$maxNew = 2000;
}
else {
$maxNew = $max;
}

It works fine, but seems clunky. Is there a more effecient way to do this?

Any help would be appreciated. I am using MySQL 5.0 and PHP 5.1.4

 

[feherke]

Hi

It could be written as :

$min = $_POST['min'];
$max = $_POST['max'];

$minNew = $min == "" ? 0 : $min;
$maxNew = $max == "" ? 2000 : $max;

But what if the value of [tt]$_POST['max'][/tt] is "Intelligent Work Forums for Computer Professionals" ? You will accept it just because it is not equal with "" ?

Feherke.

http://rootshell.be/~feherke/

 

[jpadie]

foreach(array('min','max') as $var){
 ${$var}New = !empty($_POST[$var]) ? $_POST[$var] : (($var === 'min') ? 0 : 2000);
}

i think that would work.

 

[bill1one]

Both worked fine. Thanks a million. In response to

But what if the value of $_POST['max'] is "Intelligent Work Forums for Computer Professionals" ? You will accept it just because it is not equal with "" ?

I have a javascript to handle that. Thanks for pointing it out.

 

[feherke]

Hi

I have a javascript to handle that.

You should never trust in anything coming from the client. Client-side validation is useful only to decrease the bandwidth usage and increase the interaction.

Feherke.

http://rootshell.be/~feherke/

 

[jpadie]

as a partial fix you could do this

foreach(array('min','max') as $var){
 ${$var}New = !empty($_POST[$var]) ? float_val($_POST[$var]) : (($var === 'min') ? 0 : 2000);
}