CDONTS Reply Question 1

vanillapod · Nov 14, 2002

Hi, I've setup a mailing list and was wondering, if one of the emails sent out doesn't exist where will the delivery failure notice email go to?

Cheers

vanillapod · Nov 15, 2002

Another question! My code works as below....

2 recordsets, one with email addresses other with details that need sendinging.

Repeat Recordset1
Create Mail oobject
Some HTML (a kinda intro...)**
Repeat Recordset2
Details
Next Recordset2
Email to: details etc
Next recordset1

Basically the first person ion the list to be sent an email gets it fine, it looks good. The second person gets the mail fine but right at the end the part 'Some HTML**' (see above) is repeated once. The third person on the list gets this bit twice, the fourth three times and so on...

Can anyone help me with this? Please!

GaryC123 · Nov 15, 2002

Can u post ur full code re the email part, and how many emails are getting sent out in one go? Saturday 12.00

20.00

3.00am

Sunday [img http

mwolf00 · Nov 15, 2002

Question #2'

When creating your body (some HTML) you are probably concatenating.

htmlBody = htmlBody & " more text "...

Make sure that you clear htmlBody....

htmlBody = ""

Before you continue with the second iteration of your loop.

As to question #1, I'm not sure on that one....

[laser]

-- Just trying to help... LOL [ponder]

vanillapod · Nov 15, 2002

<%
While ((Repeat1__numRows <> 0) AND (NOT Recordset1.EOF))
%>
<%
Dim objMail
Dim MyCDONTSMail13
Set objMail = Server.CreateObject("CDONTS.NewMail&quot

'MyCDONTSMail3.AttachFile Server.MapPath("/logo12.jpg&quot

'objMail.AttachURL "E:\internalaudit\images\pencil.gif", "myImage2.gif"

HTML = HTML & "<HTML>"
HTML = HTML & "<HEAD>"
HTML = HTML & "<TITLE>Vanilla Pod Gigs</TITLE>"
HTML = HTML & "</HEAD>"
HTML = HTML & "<BODY bgcolor=""#000000"">"
HTML = HTML & ""
'HTML = HTML & "<A HREF=""

http://www.vanillapod.org"">"

'HTML = HTML & "<IMG SRC=""myImage.jpg""></A> "
HTML = HTML & ""
HTML = HTML & "Vanilla Pod Gigs Mailing List"
HTML = HTML & ""
HTML = HTML & ""
HTML = HTML & " (Please do not reply to this email!)"
HTML = HTML & ""
HTML = HTML & ""
HTML = HTML & ""
HTML = HTML & ""
HTML = HTML & "New gigs has been posted on the Vanilla Pod website see below for details:"
HTML = HTML & ""
HTML = HTML & ""%>

<%
Dim Repeat2__numRows
Repeat2__numRows = -1
Dim Repeat2__index
Repeat2__index = 0
Recordset2_numRows = Recordset2_numRows + Repeat2__numRows
%>

<%
While ((Repeat2__numRows <> 0) AND (NOT Recordset2.EOF))
HTML = HTML & ""
HTML = HTML & ""
HTML = HTML & "Date: "
HTML = HTML & "</Font"
HTML = HTML & ""
HTML = HTML & (Recordset2.Fields.Item("One&quot

.Value)
HTML = HTML & "</Font"
HTML = HTML & ""
HTML = HTML & " - Venue: "
HTML = HTML & "</Font"
HTML = HTML & ""
HTML = HTML & (Recordset2.Fields.Item("Venue&quot

.Value)
HTML = HTML & "</Font"
HTML = HTML & ""
HTML = HTML & " - Other Bands: "
HTML = HTML & "</Font"
HTML = HTML & ""
HTML = HTML & (Recordset2.Fields.Item("Bands&quot

.Value)
HTML = HTML & "</Font"
HTML = HTML & "<hr>"
HTML = HTML & ""
HTML = HTML & ""
HTML = HTML & ""
Repeat2__index=Repeat2__index+1
Repeat2__numRows=Repeat2__numRows-1
Recordset2.MoveNext()
Wend
HTML = HTML & ""
HTML = HTML & "visit "
HTML = HTML & "<a href=""Biog.htm"">

http://www.vanillapod.org

</a>"
HTML = HTML & " for the news, pitures, mp3s and other stuff info. If you did not ask to be on this list or want to be removed, please email "
HTML = HTML & "<a href=""mailto:MailingList@vanillapod.org""> mailinglist@vanillapod.org </a>"
HTML = HTML & " with Remove in the subject (or you can reply to this email with 'remove' in the subject)."
HTML = HTML & ""
HTML = HTML & ""
HTML = HTML & ""
HTML = HTML & ""
HTML = HTML & ""

HTML = HTML & ""

HTML = HTML & "</BODY>"
HTML = HTML & "</HTML>"

objMail.From = "Vanilla Pod"
objMail.Subject = "New gig posted..."

'you need TO add these lines FOR the mail
'to be sent in HTML format
objMail.BodyFormat = 0
objMail.MailFormat = 0

objMail.To = (Recordset1.Fields.Item("Email&quot

.Value)
objMail.Value("Reply-To&quot

= "mailinglist@vanillapod.org"
objMail.Body = HTML
objMail.Send

Response.write("An Email Has Been Sent To &quot

Response.write(Recordset1.Fields.Item("Email&quot

.Value)
Response.write("&quot

set objMail = nothing
htmlBody = ""
%>
<%
Repeat1__index=Repeat1__index+1
Repeat1__numRows=Repeat1__numRows-1
Recordset1.MoveNext()
Wend
%>

vanillapod · Nov 15, 2002

there ya go! I just added and tried the htmlBody = "" and its still doing it... have i put it in the right place?

Cheers for the help!

mwolf00 · Nov 15, 2002

<%
While ((Repeat1__numRows <> 0) AND (NOT Recordset1.EOF))
%>
<%
Dim objMail
Dim MyCDONTSMail13
Set objMail = Server.CreateObject("CDONTS.NewMail&quot

'MyCDONTSMail3.AttachFile Server.MapPath("/logo12.jpg&quot

'objMail.AttachURL "E:\internalaudit\images\pencil.gif", "myImage2.gif"
HTML = ""
HTML = HTML & "<HTML>"
HTML = HTML & "<HEAD>"
HTML = HTML & "<TITLE>Vanilla Pod Gigs</TITLE>"
HTML = HTML & "</HEAD>"
-- Just trying to help... LOL [ponder]

vanillapod · Nov 15, 2002

mwolf00 cheers for that... now the first email sent is fine but the subsequent emails only have the header text, they don't have the second repeated region at all or if they do its not writing anything!

mwolf00 · Nov 15, 2002

It looks like you might need to use two separate HTML strings. One that is used on all emails and is never erased. The second is specific to that email. Note the way I concatenated "specificBody" - save a lot of typing...

mainBody = "Place your main HTML body here"
mainEnd = "Place any closing tags from mainBody here"

do while not RS.EOF
specificBody = "Start recordSet specific body here " &_
"and continue to create your string with concatentation "&_
"just like you were doing before."

objMail.body = mainBody & specificBody & mainEnd
RS.movenext
loop -- Just trying to help... LOL [ponder]

vanillapod · Nov 15, 2002

Could you explain that a bit more? Sorry for being slooow! Where do i put that / what does it replace all of the HTML = HTML & stuff???

Cheers

mwolf00 · Nov 15, 2002

I need to understand your two recordsets and how you loop through them a little bit more. What is in RS1? RS2? -- Just trying to help... LOL [ponder]

vanillapod · Nov 15, 2002

Here's the recordsets... i'm using Ultradev to create these for me...

<%
set Recordset1 = Server.CreateObject("ADODB.Recordset&quot

Recordset1.ActiveConnection = MM_TEsting1_STRING
Recordset1.Source = "SELECT Name, Email, Id FROM List"
Recordset1.CursorType = 0
Recordset1.CursorLocation = 2
Recordset1.LockType = 3
Recordset1.Open()
Recordset1_numRows = 0
%>
<%
set Recordset2 = Server.CreateObject("ADODB.Recordset&quot

Recordset2.ActiveConnection = MM_TESTING_STRING
Recordset2.Source = "SELECT one, venue, bands, posted FROM GigsAll where posted = Date()"
Recordset2.CursorType = 0
Recordset2.CursorLocation = 2
Recordset2.LockType = 3
Recordset2.Open()
Recordset2_numRows = 0
%>
<%
Dim Repeat1__numRows
Repeat1__numRows = -1
Dim Repeat1__index
Repeat1__index = 0
Recordset1_numRows = Recordset1_numRows + Repeat1__numRows
%>
<%
While ((Repeat1__numRows <> 0) AND (NOT Recordset1.EOF))
%>

mwolf00 · Nov 15, 2002

I think I understand. You don't really want to nest these loops - you are making the server work too hard.

To create your,email body, do this:

mainBody = "<HTML><TABLE><TR><TH colspan=4>Concerts</TH></TR>"&_
"<TR>"&_
"<TH>One</TH>"&_
"<TH>Venue</TH>"&_
"<TH>Bands</TH>"&_
"<TH>Posted</TH>"&_
"</TR>"
DO WHILE NOT recordset2.EOF
if bgColor = "grey" THEN bgColor = "white" ELSE bgColor = "grey"
mainBody = mainBody &_
"<TR bgColor='"&bgColor&"'>"&_
"<TD>" & recordset2("one&quot

& "</TD>" &_
"<TD>" & recordset2("venue&quot

& "</TD>" &_
"<TD>" & recordset2("bands&quot

& "</TD>" &_
"<TD>" & recordset2("posted&quot

& "</TD>" &_
"</TR">
recordset2.MOVENEXT
LOOP

'now that the body is created, mail it

DO WHILE NOT recordset1.EOF
Set objMail = Server.CreateObject("CDONTS.NewMail&quot

with objMail
.From = "Vanilla Pod"
.Subject = "New gig posted..."
.BodyFormat = 0
.MailFormat = 0
.To = (Recordset1.Fields.Item("Email&quot

.Value)
.Value("Reply-To&quot

= "mailinglist@vanillapod.org"
.Body = mainBody
.send
end with
set objMail = nothing
recordset1.MOVENEXT
LOOP -- Just trying to help... LOL [ponder]

vanillapod · Nov 15, 2002

Cheers for helping me with this! Anyway I ran it and got an error and had to remove the "</TR"> after the following lines...

"<TD>" & recordset2("one&quot

& "</TD>" &_
"<TD>" & recordset2("venue&quot

& "</TD>" &_
"<TD>" & recordset2("bands&quot

& "</TD>" &_
"<TD>" & recordset2("posted&quot

& "</TD>" &_

Now its saying it expects a wend at the end of my code... here's everything as i have it...

<%@LANGUAGE="VBSCRIPT"%>

<%
set Recordset1 = Server.CreateObject("ADODB.Recordset&quot

Recordset1.ActiveConnection = MM_TEsting1_STRING
Recordset1.Source = "SELECT Name, Email, Id FROM List"
Recordset1.CursorType = 0
Recordset1.CursorLocation = 2
Recordset1.LockType = 3
Recordset1.Open()
Recordset1_numRows = 0
%>
<%
set Recordset2 = Server.CreateObject("ADODB.Recordset&quot

Recordset2.ActiveConnection = MM_TESTING_STRING
Recordset2.Source = "SELECT one, venue, bands, posted FROM GigsAll where posted = Date()"
Recordset2.CursorType = 0
Recordset2.CursorLocation = 2
Recordset2.LockType = 3
Recordset2.Open()
Recordset2_numRows = 0
%>
<%
Dim Repeat1__numRows
Repeat1__numRows = -1
Dim Repeat1__index
Repeat1__index = 0
Recordset1_numRows = Recordset1_numRows + Repeat1__numRows
%>
<%
While ((Repeat1__numRows <> 0) AND (NOT Recordset1.EOF))
%>
<%
mainBody = "<HTML><TABLE><TR><TH colspan=4>Concerts</TH></TR>"&_
"<TR>"&_
"<TH>One</TH>"&_
"<TH>Venue</TH>"&_
"<TH>Bands</TH>"&_
"<TH>Posted</TH>"&_
"</TR>"
DO WHILE NOT recordset2.EOF
if bgColor = "grey" THEN bgColor = "white" ELSE bgColor = "grey"
mainBody = mainBody &_
"<TR bgColor='"&bgColor&"'>"&_
"<TD>" & recordset2("one&quot

& "</TD>" &_
"<TD>" & recordset2("venue&quot

& "</TD>" &_
"<TD>" & recordset2("bands&quot

& "</TD>" &_
"<TD>" & recordset2("posted&quot

& "</TD>" &_

recordset2.MOVENEXT
LOOP

'now that the body is created, mail it

DO WHILE NOT recordset1.EOF
Set objMail = Server.CreateObject("CDONTS.NewMail&quot

with objMail
.From = "Vanilla Pod"
.Subject = "New gig posted..."
.BodyFormat = 0
.MailFormat = 0
.To = (Recordset1.Fields.Item("Email&quot

.Value)
.Value("Reply-To&quot

= "mailinglist@vanillapod.org"
.Body = mainBody
.send
end with
set objMail = nothing
recordset1.MOVENEXT
LOOP
%>
<%
Recordset2.Close()
%>
<%
Recordset1.Close()
%>

mwolf00 · Nov 15, 2002

All of the opening and closing of your delimiters (%><%) is unecessary and makes the code harder to read.
<%@LANGUAGE="VBSCRIPT"%>

<%
set Recordset1 = Server.CreateObject("ADODB.Recordset&quot

Recordset1.ActiveConnection = MM_TEsting1_STRING
Recordset1.Source = "SELECT Name, Email, Id FROM List"
Recordset1.CursorType = 0
Recordset1.CursorLocation = 2
Recordset1.LockType = 3
Recordset1.Open()
Recordset1_numRows = 0

set Recordset2 = Server.CreateObject("ADODB.Recordset&quot

Recordset2.ActiveConnection = MM_TESTING_STRING
Recordset2.Source = "SELECT one, venue, bands, posted FROM GigsAll where posted = Date()"
Recordset2.CursorType = 0
Recordset2.CursorLocation = 2
Recordset2.LockType = 3
Recordset2.Open()
Recordset2_numRows = 0

'I don't know what you want these 5 lines for
Dim Repeat1__numRows
Repeat1__numRows = -1
Dim Repeat1__index
Repeat1__index = 0
Recordset1_numRows = Recordset1_numRows + Repeat1__numRows

'The follwing line was the problem - not needed in my code
'While ((Repeat1__numRows <> 0) AND (NOT Recordset1.EOF))

mainBody = "<HTML><TABLE><TR><TH colspan=4>Concerts</TH></TR>"&_
"<TR>"&_
"<TH>One</TH>"&_
"<TH>Venue</TH>"&_
"<TH>Bands</TH>"&_
"<TH>Posted</TH>"&_
"</TR>"
DO WHILE NOT recordset2.EOF
if bgColor = "grey" THEN bgColor = "white" ELSE bgColor = "grey"
mainBody = mainBody &_
"<TR bgColor='"&bgColor&"'>"&_
"<TD>" & recordset2("one&quot

& "</TD>" &_
"<TD>" & recordset2("venue&quot

& "</TD>" &_
"<TD>" & recordset2("bands&quot

& "</TD>" &_
"<TD>" & recordset2("posted&quot

& "</TD>" &_
recordset2.MOVENEXT
LOOP

'now that the body is created, mail it'

DO WHILE NOT recordset1.EOF
Set objMail = Server.CreateObject("CDONTS.NewMail&quot

with objMail
.From = "Vanilla Pod"
.Subject = "New gig posted..."
.BodyFormat = 0
.MailFormat = 0
.To = (Recordset1.Fields.Item("Email&quot

.Value)
.Value("Reply-To&quot

= "mailinglist@vanillapod.org"
.Body = mainBody
.send
end with
set objMail = nothing
recordset1.MOVENEXT
LOOP

Recordset2.Close()

Recordset1.Close()
%> -- Just trying to help... LOL [ponder]

vanillapod · Nov 15, 2002

WOW! That's great mwolf00 thanks loads, see what you mean about the <%%>'s as well, love the alternating green stripes as well!.... cheers

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

CDONTS Reply Question 1

vanillapod

MIS

vanillapod

MIS

GaryC123

Programmer

mwolf00

Programmer

vanillapod

MIS

vanillapod

MIS

mwolf00

Programmer

vanillapod

MIS

mwolf00

Programmer

vanillapod

MIS

mwolf00

Programmer

vanillapod

MIS

mwolf00

Programmer

vanillapod

MIS

mwolf00

Programmer

vanillapod

MIS

Similar threads

Part and Inventory Search

Sponsor