Can't find error in simple javascript 1

[PulsarSL]

Hey -- When I have this javascript in my file and try to execute a function defined after it, the function is never executed. When I remove this piece, it works fine. This leads me to believe that there is something wrong with this bit. Is this a correct assumption? And do you see anything wrong with this? Thanks

Pulsar

function findOffset(alphabet, ch)
{
var findOffset = alphabet.indexOf(ch) - 1

If (findOffset == -1) {
return -5
} else {
return findOffset
}

}

The part that gives me trouble is the If...Else statement. I threw the rest in to give you some context. Thx.

 

[friendlyposter]

Looks like a nasty capital I in If...


If (findOffset == -1) {

Looks like a variable has same name as the function ...


function findOffset(alphabet, ch)
{
var findOffset = alphabet.indexOf(ch) - 1

 

[trollacious]

Your logic has a flaw in it, too. Because you subtract 1 from the index of a character, you could possibly get a value of -2, if the character you're checking for is not in the string called alphabet.

Lee

 

[BillyRayPreachersSon]

Putting some semicolon terminators in wouldn't go amiss, either.

Hope this helps,
Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[PulsarSL]

Thanks, changing the capital I to lowercase and changing the variable name fixed it. I'm porting this from VB where a variable of the same name as the function is returned, so I guess that's how that slipped in there.

Pulsar