beginners problem styling using an id

[daantje]

For my website I had to add javascript with my PHP site in order to get the anchor tag from the current page. This in order to compare it to the id of an <span> tag in the page. Javascript is not my strong side. So of course the script doesn't work.This is the problem:


Here is my PHP/javascript code:

$output .= "<script type=\"text/javascript\">
if( \"#term{$term->tid}\" == location.hash){
document.all[\"term{$term->tid}\"].style.color=\"red\"
</script>";
$output .= "<span id=\"term{$term->tid}\">{$term->name}</span>";

This code looks as folows in the source code of the page......

<script type="text/javascript">
  if( "#term1" == location.hash){
    document.all["term1"].style.color="red"
  }
</script>
<span id="term1">Termname</span>

This all worked fine when I used document.write instead of the line styling the term....so the line.....

document.all[\"term{$term->tid}\"].style.color=\"red\"

otherwise

document.all["term1"].style.color="red"

.....is causing the trouble.

It looks fine to me...I have no idea what went wrong because the "Termname" does not turn red. Anyone have any ideas??

Thanx

 

[monksnake]

instead of using this line

document.all["term1"].style.color="red"

change it to

document.getElementById("term1").style.color = "#ff0000";

I don't think FF understands document.all
PHP

document.getElementById(\"term{$term->tid}\").style.color=\"#ff0000\"

if that doesn't change it red, then put an alert

alert("#term1" == location.hash);

<.

 

[feherke]

Hi

I don't think FF understands document.all

Actually it does, but only in Quirks Mode, just like Opera and Konqueror. They all were forced to this step by the huge amount of webmasters unaware of web standards. :-(

Feherke.

http://rootshell.be/~feherke/

 

[daantje]

I am using FireFox so that's probably it. I tried using

<script type=\"text/javascript\">
if( \"#term{$term->tid}\" == location.hash){
document.getElementById(\"term{$term->tid}\").style.color=\"#ff0000\";
}
</script>";

But that didn't work either. When I put the alert in I get a true as alert. So it is the line..

document.getElementById(\"term{$term->tid}\").style.color=\"#ff0000\";

Any suggestions?
thanx

 

[monksnake]

Here is a suggestion. Does this element exist yet when you run the script to turn it red?

<span id="term1">Termname</span>

I'm guessing no. Put that script anywhere physically below the <span>.

<.

 

[daantje]

Actually it does....see the top of the forum.

Could it have anything to do with the fact that I already assigned a color to it using css. But this loads before the javascript does right...so that couldn't be it...could it?

 

[monksnake]

Actually it does....see the top of the forum

I see this:

<script type="text/javascript">
  if( "#term1" == location.hash){
    document.all["term1"].style.color="red"
  }
</script>
<span id="term1">Termname</span>

This would not work.

<span id="term1">Termname</span>
<script type="text/javascript">
  if( "#term1" == location.hash){
    document.all["term1"].style.color="red"
  }
</script>

This would.

<.

 

[daantje]

I already tried that....without result

 

[daantje]

Could it have anything to do with my CMS....I use Drupal..it might be in conflict or somthing...I don't get any errors though

 

[monksnake]

Could it have anything to do with my CMS....I use Drupal

To be honest I have no idea what Drupal is.

I saw above you said something about your CSS definition, you can try taking that out to see if anything happens.

There is a conflict somewhere, cause this is elementary (making the font of a <span> a different color)

It could also be possible you have 2 elements with the same id.

I'm just throwing stuff out there, cause I'm not sure what the conflict is.

<.