Basic login form validation problem 1

[newbie425]

Hi,

I'm using a basic login script to control access to a page.

This is my script (in the head tag):
<script language="javascript">
<!--//
function dbLogin (form)
{
if (loginform.login.value=="dashboard") {
if (loginform.password.value=="PsWd123") {
window.location="dashboard.html";
}
else {
alert("Incorrect Password!");
}
}
else {
alert("Incorrect Login!");
}
}
//-->
</script>

This is my form tag:
<form name="loginform" onSubmit="dbLogin(this.form)">

This is my submit button:
<input type="submit" value="Submit">

I've tried it another way as well...

form tag: <form name="loginform">
submit btn: <input type="submit" value="Submit" onClick="dashboardLogin(this.form);">

Neither way redirects me to dashboard.html when the login and password are correct.

What am I missing??? Please help! Thanks!!

 

[bean1234]

try changing the parameter name to 'loginform'

 

[newbie425]

Hi bean1234,

Thanks for your reply. I changed the parameter name, but it still didn't work. You mean

onSubmit="dbLogin(this.form)"
CHANGE TO
onSubmit="dashboardLogin(loginform)"

right?


Does it matter that I'm working on a shared drive right now (this is my development environment) and not a web server?

Thanks.

 

[newbie425]

Oops, I'm confusing my functions. I meant

onSubmit="dbLogin(this.form)"
CHANGE TO
onSubmit="dbLogin(loginform)"

 

[stewartwebb]

Could you not change your button to this:-

<input type="button" value="Submit" onClick="dbLogin();">

and your javascript to this

function dbLogin ()
{
   if (document.loginform.login.value=="dashboard") {
         if (document.loginform.password.value=="PsWd123") {
          window.location="dashboard.html";
        }
        else {
          alert("Incorrect Password!");
        }
   }
   else {
        alert("Incorrect Login!");
    }
}

Hope this helps

Stewart.

 

[newbie425]

Thanks that did work. The only thing is I need the button to be of type submit. Originally, I had an image instead of a button and I got a complaint that the user can't just hit enter so I'm switching to a button. Is there a way to fix that with the image?

Thanks stewart.

 

[delpierro]

onclick = "this.form.submit()

 

[stewartwebb]

Checking for keyCode 13 is another option.

 

[newbie425]

Hi delpierro,

That onclick was for the image? This is what I had:
<a href="javascript:dbLogin(this.form)"><img src="images/submit.jpg" alt="" border="0">

I changed to:
<a href="javascript:dbLogin(this.form)" onclick = "loginform.submit()"><img src="images/submit.jpg" alt="" border="0">

I was getting an error on "this.form".

Hitting Enter doesn't work.

 

[newbie425]

stewart,

how do you check for keycode 13?

thanks.

 

[stewartwebb]

On delpierro's idea, did you close your <a> tag?

Not sure the effect this will have but in your example code you haven't included </a>

 

[newbie425]

good eyes, i didn't close the a tag at first, but i did now and it still didn't work...

should i go back to using the button? if so, is there i can make it work using <input type=submit> instead of type=button?

thanks much!

 

[newbie425]

I tried checking keycode 13. It didn't work. I get the orginal problem where I'm not directed to the next page.

 

[monksnake]

I'll show you what I see is wrong:
(from original post)

<script language="javascript">
<!--//
function dbLogin()
{
   if (loginform.login.value=="dashboard") {
       if (loginform.password.value!="PsWd123") {
          alert("Incorrect Password!");
          [!]return false;[/!]
       }
   }
   else {
        alert("Incorrect Login!");
        [!]return false;[/!]
    }
[!]return true;[/!]
}
//-->
</script>

This is my form tag:
<form [!]action="dashboard.html" method="post"[/!] name="loginform" onSubmit="[!]return[/!] dbLogin()">

This is my submit button:
<input type="submit" value="Submit">

<.

 

[newbie425]

That worked! Thanks!

 

[monksnake]

Glad to help.

I like greedo.

<.