auto increment.. 1

[perlone]

I have a file called weapons.txt and it contains the following:

Shot Gun
Counter Strike
Strike Forces


And on the main script, I have the following:

$count_weapons=1;
foreach $weapons (@weapons) {
$weapon_list .= &quot;$weapons<BR>&quot;;
$count_weapons++;
}

When i run the script, it counting 4 instead of 3. I also tried with $count_weapons = 0 and the results were the same. Is it something has to do with the new line?

 

[goBoating]

Your weapon count needs to start at zero, not one. Before the first interation of your loop you have zero weapons, not one.

just loose the line =>'$count_weapons=1;'

Another slant....... you could get the length of an array like,
@weapons = ('first','second','third');
$num_weapons = $#weapons;


keep the rudder amid ship and beware the odd typo

 

[perlone]

Like I said earlier i did tried giving the value 0 but the results were same but i never thought of the $num_weapons = $#weapons. Thanks.

 

[perlone]

Still not working and I cannot do this:
@weapons = ('first','second','third');

Because it's reading from a file called weapons.txt. Here's my full code now:

open(F, &quot;$basedir/$email/weapons.cgi&quot;
@weapons = <F>;
close(F);

$count_weapons = 0;
foreach $weapons (@weapons) {
$weapon_list .= $weapons&quot;<BR>&quot;;
$count_weapons++;
}

 

[izivt]

is this what you are trying to do???

open(F, &quot;weapons.txt&quot;
while(<F>)
{
chop;
@weapons = <F>;
}
close(F);
$count_weapons = @weapons;

$string=join(&quot;<BR>&quot;,@weapons);
print $string;

 

[izivt]

@weapons=<F> should be this

@weapons=(@weapons,$_);

 

[tsdragon]

Instead of looping thru the file and adding each line to the array (which would be better done with push anyway), just do like you were doing before and use @weapons = <F>. If you need to remove the \n from the end of each record you can do this:

@weapons = map(chomp,@weapons);

Note that $#weapons will give you the subscript of the last element of @weapons, not the number of entries. scalar(@weapons) will give you the number of entries.

The way isivt gave for printing the array will work great. You may also want to add a &quot;<br>&quot; to the end of the string too.
Tracy Dryden
tracy@bydisn.com

Meddle not in the affairs of dragons,
For you are crunchy, and good with mustard.