a tiny syntax error for new commer

[szzxy]

Hello, I am a self-taught new user to perl. Could anyone please take a look at my script and tell me what is going wrong '
[error msg]
syntax error at gene_key.pl line 15, near "){"
syntax error at gene_key.pl line 23, near "}"



#!/usr/local/bin/perl -w
use strict;

open (file1, $ARGV[0]);

my $gene;
my $rs;
my $tf;
my $ds;
my %gene_key;
my @genes



while(<file1>){

if ($_=~/^(.+)\t+(.+)\t+(.+)\t(.+)$/){
$gene=$1;
$rs=$2;
$tf=$3;
$ds=$4;
}



push (@genes, $gene);

foreach $gene (@genes){

$gene_key{$gene}=($3." ".$2." ".$4)

}


foreach $gene(keys %gene_key){

my @gene_table;

push (@gene_table, $gene," ",$gene_key{$gene});

print "$gene.' '.$gene_key{$gene}";

}


}

close (file1);

 

[feherke]

Hi

Missing semicolon ( ; ) at the end of line 11 :

[b]my[/b] [navy]@genes[/navy][highlight][teal];[/teal][/highlight]

Feherke.

http://free.rootshell.be/~feherke/

 

[terryISO]

And another missing semi-colon here:

$gene_key{$gene}=($3." ".$2." ".$4)

Should be
$gene_key{$gene}=($3." ".$2." ".$4);

 

[feherke]

Hi

And another missing semi-colon here:

Every simple statement must be terminated with a semicolon, unless it is the final statement in a block, in which case the semicolon is optional.

man perlsyn | Simple Statements

Feherke.

http://free.rootshell.be/~feherke/

 

[szzxy]

Seems like I still have a lot to learn. Thanks a lot for all the replies.

 

[Annihilannic]

Feherke, while it is technically optional, I would always encourage people to use one anyway to avoid later confusion and syntax errors should they add more code to the block.

Annihilannic.

 

[feherke]

Hi

Neither I recommended it, especially not for beginners. I just pointed out that the semicolon's absence mentioned by terryISO does not generate error.

( Personally I omit the semicolon only after the [tt]sub[/tt]s' last statement, the implicitly returned one. That way if I put more statements after that, will throw error instead of returning something undesired. I know I should always use explicit [tt]return[/tt]... )

Feherke.

http://free.rootshell.be/~feherke/

 

[stevexff]

szzxy

Try using one of the many programmer's editors available - jedit is pretty good (and free), but everybody has their own favourites. The coloured syntax highlighting provided by the editor will help you to see the syntax errors as you are coding the program.

Steve

[small]"Every program can be reduced by one instruction, and every program has at least one bug. Therefore, any program can be reduced to one instruction which doesn't work." (Object:erlDesignPatterns)[/small]